fix: consolidate registryConfig application logic

It should happen whenever we read a manifest anyways.

Tests were also rewritten to be real.

1 files changed, 211 insertions, 113 deletions

diff --git a/tap-snapshots/test/lib/commands/publish.js.test.cjs b/tap-snapshots/test/lib/commands/publish.js.test.cjs
index dec772783..c6f757e8a 100644
--- a/tap-snapshots/test/lib/commands/publish.js.test.cjs
+++ b/tap-snapshots/test/lib/commands/publish.js.test.cjs
@@ -5,153 +5,251 @@
  * Make sure to inspect the output below.  Do not ignore changes!
  */
 'use strict'
-exports[`test/lib/commands/publish.js TAP private workspaces colorless > should output all publishes 1`] = `
+exports[`test/lib/commands/publish.js TAP dry-run > must match snapshot 1`] = `
 Array [
-  "+ @npmcli/b@1.0.0",
+  Array [
+    "",
+  ],
+  Array [
+    "",
+    "package: test-package@1.0.0",
+  ],
+  Array [
+    "=== Tarball Contents ===",
+  ],
+  Array [
+    "",
+    "87B package.json",
+  ],
+  Array [
+    "=== Tarball Details ===",
+  ],
+  Array [
+    "",
+    String(
+      name:          test-package                            
+      version:       1.0.0                                   
+      filename:      test-package-1.0.0.tgz                  
+      package size:  160 B                                   
+      unpacked size: 87 B                                    
+      shasum:{sha}
+      integrity:{sha}
+      total files:   1                                       
+    ),
+  ],
+  Array [
+    "",
+    "",
+  ],
+  Array [
+    "",
+    "Publishing to https://registry.npmjs.org/ (dry-run)",
+  ],
 ]
 `
 
-exports[`test/lib/commands/publish.js TAP private workspaces colorless > should publish all non-private workspaces 1`] = `
-Array [
-  Object {
-    "_id": "@npmcli/b@1.0.0",
-    "name": "@npmcli/b",
-    "readme": "ERROR: No README data found!",
-    "version": "1.0.0",
-  },
-]
+exports[`test/lib/commands/publish.js TAP has auth for scope configured registry > new package version 1`] = `
++ @npm/test-package@1.0.0
 `
 
-exports[`test/lib/commands/publish.js TAP private workspaces with color > should output all publishes 1`] = `
+exports[`test/lib/commands/publish.js TAP ignore-scripts > new package version 1`] = `
++ test-package@1.0.0
+`
+
+exports[`test/lib/commands/publish.js TAP json > must match snapshot 1`] = `
 Array [
-  "+ @npmcli/b@1.0.0",
+  Array [
+    "",
+    "Publishing to https://registry.npmjs.org/",
+  ],
 ]
 `
 
-exports[`test/lib/commands/publish.js TAP private workspaces with color > should publish all non-private workspaces 1`] = `
+exports[`test/lib/commands/publish.js TAP json > new package json 1`] = `
+{
+  "id": "test-package@1.0.0",
+  "name": "test-package",
+  "version": "1.0.0",
+  "size": 160,
+  "unpackedSize": 87,
+  "shasum": "{sha}",
+  "integrity": "{sha}",
+  "filename": "test-package-1.0.0.tgz",
+  "files": [
+    {
+      "path": "package.json",
+      "size": 87,
+      "mode": 420
+    }
+  ],
+  "entryCount": 1,
+  "bundled": []
+}
+`
+
+exports[`test/lib/commands/publish.js TAP no auth dry-run > must match snapshot 1`] = `
++ test-package@1.0.0
+`
+
+exports[`test/lib/commands/publish.js TAP no auth dry-run > warns about auth being needed 1`] = `
 Array [
-  Object {
-    "_id": "@npmcli/b@1.0.0",
-    "name": "@npmcli/b",
-    "readme": "ERROR: No README data found!",
-    "version": "1.0.0",
-  },
+  Array [
+    "",
+    "This command requires you to be logged in to https://registry.npmjs.org/ (dry-run)",
+  ],
 ]
 `
 
-exports[`test/lib/commands/publish.js TAP workspaces all workspaces > should output all publishes 1`] = `
+exports[`test/lib/commands/publish.js TAP re-loads publishConfig.registry if added during script process > new package version 1`] = `
++ test-package@1.0.0
+`
+
+exports[`test/lib/commands/publish.js TAP respects publishConfig.registry, runs appropriate scripts > new package version 1`] = `
+
+`
+
+exports[`test/lib/commands/publish.js TAP tarball > must match snapshot 1`] = `
 Array [
-  "+ workspace-a@1.2.3-a",
-  "+ workspace-b@1.2.3-n",
-  "+ workspace-n@1.2.3-n",
+  Array [
+    "",
+  ],
+  Array [
+    "",
+    "package: test-tar-package@1.0.0",
+  ],
+  Array [
+    "=== Tarball Contents ===",
+  ],
+  Array [
+    "",
+    String(
+      26B index.js    
+      98B package.json
+    ),
+  ],
+  Array [
+    "=== Tarball Details ===",
+  ],
+  Array [
+    "",
+    String(
+      name:          test-tar-package                        
+      version:       1.0.0                                   
+      filename:      test-tar-package-1.0.0.tgz              
+      package size:  218 B                                   
+      unpacked size: 124 B                                   
+      shasum:{sha}
+      integrity:{sha}
+      total files:   2                                       
+    ),
+  ],
+  Array [
+    "",
+    "",
+  ],
+  Array [
+    "",
+    "Publishing to https://registry.npmjs.org/",
+  ],
 ]
 `
 
-exports[`test/lib/commands/publish.js TAP workspaces all workspaces > should publish all workspaces 1`] = `
+exports[`test/lib/commands/publish.js TAP tarball > new package json 1`] = `
++ test-tar-package@1.0.0
+`
+
+exports[`test/lib/commands/publish.js TAP workspaces all workspaces - color > all public workspaces 1`] = `
++ workspace-a@1.2.3-a
++ workspace-b@1.2.3-n
++ workspace-n@1.2.3-n
+`
+
+exports[`test/lib/commands/publish.js TAP workspaces all workspaces - color > warns about skipped private workspace in color 1`] = `
 Array [
-  Object {
-    "_id": "workspace-a@1.2.3-a",
-    "name": "workspace-a",
-    "readme": "ERROR: No README data found!",
-    "repository": Object {
-      "type": "git",
-      "url": "http://repo.workspace-a/",
-    },
-    "version": "1.2.3-a",
-  },
-  Object {
-    "_id": "workspace-b@1.2.3-n",
-    "bugs": Object {
-      "url": "https://github.com/npm/workspace-b/issues",
-    },
-    "homepage": "https://github.com/npm/workspace-b#readme",
-    "name": "workspace-b",
-    "readme": "ERROR: No README data found!",
-    "repository": Object {
-      "type": "git",
-      "url": "git+https://github.com/npm/workspace-b.git",
-    },
-    "version": "1.2.3-n",
-  },
-  Object {
-    "_id": "workspace-n@1.2.3-n",
-    "name": "workspace-n",
-    "readme": "ERROR: No README data found!",
-    "version": "1.2.3-n",
-  },
+  Array [
+    "publish",
+    "Skipping workspace \\u001b[32mworkspace-p\\u001b[39m, marked as \\u001b[1mprivate\\u001b[22m",
+  ],
 ]
 `
 
-exports[`test/lib/commands/publish.js TAP workspaces json > should output all publishes as json 1`] = `
+exports[`test/lib/commands/publish.js TAP workspaces all workspaces - no color > all public workspaces 1`] = `
++ workspace-a@1.2.3-a
++ workspace-b@1.2.3-n
++ workspace-n@1.2.3-n
+`
+
+exports[`test/lib/commands/publish.js TAP workspaces all workspaces - no color > warns about skipped private workspace 1`] = `
 Array [
-  String(
-    {
-      "workspace-a": {
-        "id": "workspace-a@1.2.3-a"
-      },
-      "workspace-b": {
-        "id": "workspace-b@1.2.3-n"
-      },
-      "workspace-n": {
-        "id": "workspace-n@1.2.3-n"
-      }
-    }
-  ),
+  Array [
+    "publish",
+    "Skipping workspace workspace-p, marked as private",
+  ],
 ]
 `
 
-exports[`test/lib/commands/publish.js TAP workspaces json > should publish all workspaces 1`] = `
-Array [
-  Object {
-    "_id": "workspace-a@1.2.3-a",
+exports[`test/lib/commands/publish.js TAP workspaces json > all workspaces in json 1`] = `
+{
+  "workspace-a": {
+    "id": "workspace-a@1.2.3-a",
     "name": "workspace-a",
-    "readme": "ERROR: No README data found!",
-    "repository": Object {
-      "type": "git",
-      "url": "http://repo.workspace-a/",
-    },
     "version": "1.2.3-a",
+    "size": 162,
+    "unpackedSize": 82,
+    "shasum": "{sha}",
+    "integrity": "{sha}",
+    "filename": "workspace-a-1.2.3-a.tgz",
+    "files": [
+      {
+        "path": "package.json",
+        "size": 82,
+        "mode": 420
+      }
+    ],
+    "entryCount": 1,
+    "bundled": []
   },
-  Object {
-    "_id": "workspace-b@1.2.3-n",
-    "bugs": Object {
-      "url": "https://github.com/npm/workspace-b/issues",
-    },
-    "homepage": "https://github.com/npm/workspace-b#readme",
+  "workspace-b": {
+    "id": "workspace-b@1.2.3-n",
     "name": "workspace-b",
-    "readme": "ERROR: No README data found!",
-    "repository": Object {
-      "type": "git",
-      "url": "git+https://github.com/npm/workspace-b.git",
-    },
     "version": "1.2.3-n",
+    "size": 171,
+    "unpackedSize": 92,
+    "shasum": "{sha}",
+    "integrity": "{sha}",
+    "filename": "workspace-b-1.2.3-n.tgz",
+    "files": [
+      {
+        "path": "package.json",
+        "size": 92,
+        "mode": 420
+      }
+    ],
+    "entryCount": 1,
+    "bundled": []
   },
-  Object {
-    "_id": "workspace-n@1.2.3-n",
+  "workspace-n": {
+    "id": "workspace-n@1.2.3-n",
     "name": "workspace-n",
-    "readme": "ERROR: No README data found!",
     "version": "1.2.3-n",
-  },
-]
-`
-
-exports[`test/lib/commands/publish.js TAP workspaces one workspace > should output one publish 1`] = `
-Array [
-  "+ workspace-a@1.2.3-a",
-]
+    "size": 140,
+    "unpackedSize": 42,
+    "shasum": "{sha}",
+    "integrity": "{sha}",
+    "filename": "workspace-n-1.2.3-n.tgz",
+    "files": [
+      {
+        "path": "package.json",
+        "size": 42,
+        "mode": 420
+      }
+    ],
+    "entryCount": 1,
+    "bundled": []
+  }
+}
 `
 
-exports[`test/lib/commands/publish.js TAP workspaces one workspace > should publish given workspace 1`] = `
-Array [
-  Object {
-    "_id": "workspace-a@1.2.3-a",
-    "name": "workspace-a",
-    "readme": "ERROR: No README data found!",
-    "repository": Object {
-      "type": "git",
-      "url": "http://repo.workspace-a/",
-    },
-    "version": "1.2.3-a",
-  },
-]
+exports[`test/lib/commands/publish.js TAP workspaces one workspace - success > single workspace 1`] = `
++ workspace-a@1.2.3-a
 `