src: make the npm source comply with `standard`

This is a huge set of mostly mechanical changes. Going forward, all
changes to the npm source base are expected to comply with `standard`,
and it's been integrated into the test suite to enforce that. There are
a few notes below about specific classes of changes that need to be
handled specially for npm's code base.

standard: "Expected error to be handled."

`standard` only expects errors spelled "err" to be handled.
`npm-registry-mock` never actually invokes its callback with an error,
so in some cases I just changed it to be spelled "er" and called it
good.

standard: "Expected a "break" statement before 'case'."

This behavior is actually on purpose, and I don't feel like rewriting
the affected code right now (or, you know, ever). So I added code
comments disabling the checks in the three applicable changes.

standard: "x is a function."

Rebinding functions created via declarations (as opposed to expressions)
is a no-no?

PR-URL: https://github.com/npm/npm/pull/8668

1 files changed, 38 insertions, 39 deletions

diff --git a/test/tap/00-config-setup.js b/test/tap/00-config-setup.js
index 33581eb13..a6687d116 100644
--- a/test/tap/00-config-setup.js
+++ b/test/tap/00-config-setup.js
@@ -1,32 +1,32 @@
-var path = require("path")
-var userconfigSrc = path.resolve(__dirname, "..", "fixtures", "config", "userconfig")
-exports.userconfig = userconfigSrc + "-with-gc"
-exports.globalconfig = path.resolve(__dirname, "..", "fixtures", "config", "globalconfig")
-exports.builtin = path.resolve(__dirname, "..", "fixtures", "config", "builtin")
-exports.malformed = path.resolve(__dirname, "..", "fixtures", "config", "malformed")
+var path = require('path')
+var userconfigSrc = path.resolve(__dirname, '..', 'fixtures', 'config', 'userconfig')
+exports.userconfig = userconfigSrc + '-with-gc'
+exports.globalconfig = path.resolve(__dirname, '..', 'fixtures', 'config', 'globalconfig')
+exports.builtin = path.resolve(__dirname, '..', 'fixtures', 'config', 'builtin')
+exports.malformed = path.resolve(__dirname, '..', 'fixtures', 'config', 'malformed')
 exports.ucData =
   { globalconfig: exports.globalconfig,
-    email: "i@izs.me",
-    "env-thing": "asdf",
-    "init.author.name": "Isaac Z. Schlueter",
-    "init.author.email": "i@izs.me",
-    "init.author.url": "http://blog.izs.me/",
-    "init.version": "1.2.3",
-    "proprietary-attribs": false,
-    "npm:publishtest": true,
-    "_npmjs.org:couch": "https://admin:password@localhost:5984/registry",
-    "npm-www:nocache": "1",
-    nodedir: "/Users/isaacs/dev/js/node-v0.8",
-    "sign-git-tag": true,
-    message: "v%s",
-    "strict-ssl": false,
-    "tmp": process.env.HOME + "/.tmp",
-    _auth: "dXNlcm5hbWU6cGFzc3dvcmQ=",
+    email: 'i@izs.me',
+    'env-thing': 'asdf',
+    'init.author.name': 'Isaac Z. Schlueter',
+    'init.author.email': 'i@izs.me',
+    'init.author.url': 'http://blog.izs.me/',
+    'init.version': '1.2.3',
+    'proprietary-attribs': false,
+    'npm:publishtest': true,
+    '_npmjs.org:couch': 'https://admin:password@localhost:5984/registry',
+    'npm-www:nocache': '1',
+    nodedir: '/Users/isaacs/dev/js/node-v0.8',
+    'sign-git-tag': true,
+    message: 'v%s',
+    'strict-ssl': false,
+    'tmp': process.env.HOME + '/.tmp',
+    _auth: 'dXNlcm5hbWU6cGFzc3dvcmQ=',
     _token:
-     { AuthSession: "yabba-dabba-doodle",
-       version: "1",
-       expires: "1345001053415",
-       path: "/",
+     { AuthSession: 'yabba-dabba-doodle',
+       version: '1',
+       expires: '1345001053415',
+       path: '/',
        httponly: true } }
 
 // set the userconfig in the env
@@ -38,31 +38,30 @@ Object.keys(process.env).forEach(function (k) {
 })
 process.env.npm_config_userconfig = exports.userconfig
 process.env.npm_config_other_env_thing = 1000
-process.env.random_env_var = "asdf"
-process.env.npm_config__underbar_env_thing = "underful"
+process.env.random_env_var = 'asdf'
+process.env.npm_config__underbar_env_thing = 'underful'
 process.env.NPM_CONFIG_UPPERCASE_ENV_THING = 42
 
 exports.envData = {
   userconfig: exports.userconfig,
-  "_underbar-env-thing": "underful",
-  "uppercase-env-thing": "42",
-  "other-env-thing": "1000"
+  '_underbar-env-thing': 'underful',
+  'uppercase-env-thing': '42',
+  'other-env-thing': '1000'
 }
 exports.envDataFix = {
   userconfig: exports.userconfig,
-  "_underbar-env-thing": "underful",
-  "uppercase-env-thing": 42,
-  "other-env-thing": 1000
+  '_underbar-env-thing': 'underful',
+  'uppercase-env-thing': 42,
+  'other-env-thing': 1000
 }
 
-
 if (module === require.main) {
   // set the globalconfig in the userconfig
-  var fs = require("fs")
+  var fs = require('fs')
   var uc = fs.readFileSync(userconfigSrc)
-  var gcini = "globalconfig = " + exports.globalconfig + "\n"
+  var gcini = 'globalconfig = ' + exports.globalconfig + '\n'
   fs.writeFileSync(exports.userconfig, gcini + uc)
 
-  console.log("1..1")
-  console.log("ok 1 setup done")
+  console.log('1..1')
+  console.log('ok 1 setup done')
 }