src: make the npm source comply with `standard`

This is a huge set of mostly mechanical changes. Going forward, all
changes to the npm source base are expected to comply with `standard`,
and it's been integrated into the test suite to enforce that. There are
a few notes below about specific classes of changes that need to be
handled specially for npm's code base.

standard: "Expected error to be handled."

`standard` only expects errors spelled "err" to be handled.
`npm-registry-mock` never actually invokes its callback with an error,
so in some cases I just changed it to be spelled "er" and called it
good.

standard: "Expected a "break" statement before 'case'."

This behavior is actually on purpose, and I don't feel like rewriting
the affected code right now (or, you know, ever). So I added code
comments disabling the checks in the three applicable changes.

standard: "x is a function."

Rebinding functions created via declarations (as opposed to expressions)
is a no-no?

PR-URL: https://github.com/npm/npm/pull/8668

1 files changed, 4 insertions, 7 deletions

diff --git a/test/tap/00-verify-bundle-deps.js b/test/tap/00-verify-bundle-deps.js
index 92818142a..75ea81c59 100644
--- a/test/tap/00-verify-bundle-deps.js
+++ b/test/tap/00-verify-bundle-deps.js
@@ -1,17 +1,14 @@
-var fs = require("fs")
-var path = require("path")
-var test = require("tap").test
+var test = require('tap').test
 
-var manifest = require("../../package.json")
+var manifest = require('../../package.json')
 var deps = Object.keys(manifest.dependencies)
-var dev = Object.keys(manifest.devDependencies)
 var bundled = manifest.bundleDependencies
 
-test("all deps are bundled deps or dev deps", function (t) {
+test('all deps are bundled deps or dev deps', function (t) {
   deps.forEach(function (name) {
     t.assert(
       bundled.indexOf(name) !== -1,
-      name + " is in bundledDependencies"
+      name + ' is in bundledDependencies'
     )
   })