src: make the npm source comply with `standard`

This is a huge set of mostly mechanical changes. Going forward, all
changes to the npm source base are expected to comply with `standard`,
and it's been integrated into the test suite to enforce that. There are
a few notes below about specific classes of changes that need to be
handled specially for npm's code base.

standard: "Expected error to be handled."

`standard` only expects errors spelled "err" to be handled.
`npm-registry-mock` never actually invokes its callback with an error,
so in some cases I just changed it to be spelled "er" and called it
good.

standard: "Expected a "break" statement before 'case'."

This behavior is actually on purpose, and I don't feel like rewriting
the affected code right now (or, you know, ever). So I added code
comments disabling the checks in the three applicable changes.

standard: "x is a function."

Rebinding functions created via declarations (as opposed to expressions)
is a no-no?

PR-URL: https://github.com/npm/npm/pull/8668

1 files changed, 70 insertions, 65 deletions

diff --git a/test/tap/adduser-always-auth.js b/test/tap/adduser-always-auth.js
index 6a451b451..3ec819000 100644
--- a/test/tap/adduser-always-auth.js
+++ b/test/tap/adduser-always-auth.js
@@ -1,142 +1,147 @@
-var fs = require("fs")
-var path = require("path")
-var rimraf = require("rimraf")
-var mr = require("npm-registry-mock")
+var fs = require('fs')
+var path = require('path')
+var rimraf = require('rimraf')
+var mr = require('npm-registry-mock')
 
-var test = require("tap").test
-var common = require("../common-tap.js")
+var test = require('tap').test
+var common = require('../common-tap.js')
 
-var opts = {cwd : __dirname}
-var outfile = path.resolve(__dirname, "_npmrc")
+var opts = {cwd: __dirname}
+var outfile = path.resolve(__dirname, '_npmrc')
 var responses = {
-  "Username" : "u\n",
-  "Password" : "p\n",
-  "Email"    : "u@p.me\n"
+  'Username': 'u\n',
+  'Password': 'p\n',
+  'Email': 'u@p.me\n'
 }
 
-function mocks(server) {
+function mocks (server) {
   server.filteringRequestBody(function (r) {
     if (r.match(/\"_id\":\"org\.couchdb\.user:u\"/)) {
-      return "auth"
+      return 'auth'
     }
   })
-  server.put("/-/user/org.couchdb.user:u", "auth")
-    .reply(201, {username : "u", password : "p", email : "u@p.me"})
+  server.put('/-/user/org.couchdb.user:u', 'auth')
+    .reply(201, { username: 'u', password: 'p', email: 'u@p.me' })
 }
 
-test("npm login", function (t) {
-  mr({port : common.port, plugin : mocks}, function (er, s) {
+test('npm login', function (t) {
+  mr({ port: common.port, plugin: mocks }, function (er, s) {
     var runner = common.npm(
     [
-      "login",
-      "--registry", common.registry,
-      "--loglevel", "silent",
-      "--userconfig", outfile
+      'login',
+      '--registry', common.registry,
+      '--loglevel', 'silent',
+      '--userconfig', outfile
     ],
     opts,
     function (err, code) {
-      t.notOk(code, "exited OK")
-      t.notOk(err, "no error output")
-      var config = fs.readFileSync(outfile, "utf8")
-      t.like(config, /:always-auth=false/, "always-auth is scoped and false (by default)")
+      t.notOk(code, 'exited OK')
+      t.notOk(err, 'no error output')
+      var config = fs.readFileSync(outfile, 'utf8')
+      t.like(config, /:always-auth=false/, 'always-auth is scoped and false (by default)')
       s.close()
       rimraf(outfile, function (err) {
-        t.ifError(err, "removed config file OK")
+        t.ifError(err, 'removed config file OK')
         t.end()
       })
     })
 
-    var o = "", e = "", remaining = Object.keys(responses).length
-    runner.stdout.on("data", function (chunk) {
+    var o = ''
+    var e = ''
+    var remaining = Object.keys(responses).length
+    runner.stdout.on('data', function (chunk) {
       remaining--
       o += chunk
 
-      var label = chunk.toString("utf8").split(":")[0]
+      var label = chunk.toString('utf8').split(':')[0]
       runner.stdin.write(responses[label])
 
       if (remaining === 0) runner.stdin.end()
     })
-    runner.stderr.on("data", function (chunk) { e += chunk })
+    runner.stderr.on('data', function (chunk) { e += chunk })
   })
 })
 
-test("npm login --always-auth", function (t) {
-  mr({port : common.port, plugin : mocks}, function (er, s) {
+test('npm login --always-auth', function (t) {
+  mr({ port: common.port, plugin: mocks }, function (er, s) {
     var runner = common.npm(
     [
-      "login",
-      "--registry", common.registry,
-      "--loglevel", "silent",
-      "--userconfig", outfile,
-      "--always-auth"
+      'login',
+      '--registry', common.registry,
+      '--loglevel', 'silent',
+      '--userconfig', outfile,
+      '--always-auth'
     ],
     opts,
     function (err, code) {
-      t.notOk(code, "exited OK")
-      t.notOk(err, "no error output")
-      var config = fs.readFileSync(outfile, "utf8")
-      t.like(config, /:always-auth=true/, "always-auth is scoped and true")
+      t.notOk(code, 'exited OK')
+      t.notOk(err, 'no error output')
+      var config = fs.readFileSync(outfile, 'utf8')
+      t.like(config, /:always-auth=true/, 'always-auth is scoped and true')
       s.close()
       rimraf(outfile, function (err) {
-        t.ifError(err, "removed config file OK")
+        t.ifError(err, 'removed config file OK')
         t.end()
       })
     })
 
-    var o = "", e = "", remaining = Object.keys(responses).length
-    runner.stdout.on("data", function (chunk) {
+    var o = ''
+    var e = ''
+    var remaining = Object.keys(responses).length
+    runner.stdout.on('data', function (chunk) {
       remaining--
       o += chunk
 
-      var label = chunk.toString("utf8").split(":")[0]
+      var label = chunk.toString('utf8').split(':')[0]
       runner.stdin.write(responses[label])
 
       if (remaining === 0) runner.stdin.end()
     })
-    runner.stderr.on("data", function (chunk) { e += chunk })
+    runner.stderr.on('data', function (chunk) { e += chunk })
   })
 })
 
-test("npm login --no-always-auth", function (t) {
-  mr({port : common.port, plugin : mocks}, function (er, s) {
+test('npm login --no-always-auth', function (t) {
+  mr({ port: common.port, plugin: mocks }, function (er, s) {
     var runner = common.npm(
     [
-      "login",
-      "--registry", common.registry,
-      "--loglevel", "silent",
-      "--userconfig", outfile,
-      "--no-always-auth"
+      'login',
+      '--registry', common.registry,
+      '--loglevel', 'silent',
+      '--userconfig', outfile,
+      '--no-always-auth'
     ],
     opts,
     function (err, code) {
-      t.notOk(code, "exited OK")
-      t.notOk(err, "no error output")
-      var config = fs.readFileSync(outfile, "utf8")
-      t.like(config, /:always-auth=false/, "always-auth is scoped and false")
+      t.notOk(code, 'exited OK')
+      t.notOk(err, 'no error output')
+      var config = fs.readFileSync(outfile, 'utf8')
+      t.like(config, /:always-auth=false/, 'always-auth is scoped and false')
       s.close()
       rimraf(outfile, function (err) {
-        t.ifError(err, "removed config file OK")
+        t.ifError(err, 'removed config file OK')
         t.end()
       })
     })
 
-    var o = "", e = "", remaining = Object.keys(responses).length
-    runner.stdout.on("data", function (chunk) {
+    var o = ''
+    var e = ''
+    var remaining = Object.keys(responses).length
+    runner.stdout.on('data', function (chunk) {
       remaining--
       o += chunk
 
-      var label = chunk.toString("utf8").split(":")[0]
+      var label = chunk.toString('utf8').split(':')[0]
       runner.stdin.write(responses[label])
 
       if (remaining === 0) runner.stdin.end()
     })
-    runner.stderr.on("data", function (chunk) { e += chunk })
+    runner.stderr.on('data', function (chunk) { e += chunk })
   })
 })
 
-
-test("cleanup", function (t) {
+test('cleanup', function (t) {
   rimraf.sync(outfile)
-  t.pass("cleaned up")
+  t.pass('cleaned up')
   t.end()
 })