src: make the npm source comply with `standard`

This is a huge set of mostly mechanical changes. Going forward, all
changes to the npm source base are expected to comply with `standard`,
and it's been integrated into the test suite to enforce that. There are
a few notes below about specific classes of changes that need to be
handled specially for npm's code base.

standard: "Expected error to be handled."

`standard` only expects errors spelled "err" to be handled.
`npm-registry-mock` never actually invokes its callback with an error,
so in some cases I just changed it to be spelled "er" and called it
good.

standard: "Expected a "break" statement before 'case'."

This behavior is actually on purpose, and I don't feel like rewriting
the affected code right now (or, you know, ever). So I added code
comments disabling the checks in the three applicable changes.

standard: "x is a function."

Rebinding functions created via declarations (as opposed to expressions)
is a no-no?

PR-URL: https://github.com/npm/npm/pull/8668

1 files changed, 85 insertions, 85 deletions

diff --git a/test/tap/bugs.js b/test/tap/bugs.js
index 51ba5d3fe..a0a3be1b8 100644
--- a/test/tap/bugs.js
+++ b/test/tap/bugs.js
@@ -1,151 +1,151 @@
-if (process.platform === "win32") {
-  console.error("skipping test, because windows and shebangs")
-  return
+if (process.platform === 'win32') {
+  console.error('skipping test, because windows and shebangs')
+  process.exit(0)
 }
 
-var common = require("../common-tap.js")
-var mr = require("npm-registry-mock")
+var common = require('../common-tap.js')
+var mr = require('npm-registry-mock')
 
-var test = require("tap").test
-var rimraf = require("rimraf")
-var fs = require("fs")
-var path = require("path")
+var test = require('tap').test
+var rimraf = require('rimraf')
+var fs = require('fs')
+var path = require('path')
 var join = path.join
-var outFile = path.join(__dirname, "/_output")
+var outFile = path.join(__dirname, '/_output')
 
 var opts = { cwd: __dirname }
 
-test("setup", function (t) {
-  var s = "#!/usr/bin/env bash\n" +
-          "echo \"$@\" > " + JSON.stringify(__dirname) + "/_output\n"
-  fs.writeFileSync(join(__dirname, "/_script.sh"), s, "ascii")
-  fs.chmodSync(join(__dirname, "/_script.sh"), "0755")
-  t.pass("made script")
+test('setup', function (t) {
+  var s = '#!/usr/bin/env bash\n' +
+          'echo \"$@\" > ' + JSON.stringify(__dirname) + '/_output\n'
+  fs.writeFileSync(join(__dirname, '/_script.sh'), s, 'ascii')
+  fs.chmodSync(join(__dirname, '/_script.sh'), '0755')
+  t.pass('made script')
   t.end()
 })
 
-test("npm bugs underscore", function (t) {
-  mr({port : common.port}, function (er, s) {
+test('npm bugs underscore', function (t) {
+  mr({ port: common.port }, function (er, s) {
     common.npm([
-      "bugs", "underscore",
-      "--registry=" + common.registry,
-      "--loglevel=silent",
-      "--browser=" + join(__dirname, "/_script.sh")
+      'bugs', 'underscore',
+      '--registry=' + common.registry,
+      '--loglevel=silent',
+      '--browser=' + join(__dirname, '/_script.sh')
     ], opts, function (err, code, stdout, stderr) {
-      t.ifError(err, "bugs ran without issue")
-      t.notOk(stderr, "should have no stderr")
-      t.equal(code, 0, "exit ok")
-      var res = fs.readFileSync(outFile, "ascii")
+      t.ifError(err, 'bugs ran without issue')
+      t.notOk(stderr, 'should have no stderr')
+      t.equal(code, 0, 'exit ok')
+      var res = fs.readFileSync(outFile, 'ascii')
       s.close()
-      t.equal(res, "https://github.com/jashkenas/underscore/issues\n")
+      t.equal(res, 'https://github.com/jashkenas/underscore/issues\n')
       rimraf.sync(outFile)
       t.end()
     })
   })
 })
 
-test("npm bugs optimist - github (https://)", function (t) {
-  mr({port : common.port}, function (er, s) {
+test('npm bugs optimist - github (https://)', function (t) {
+  mr({ port: common.port }, function (er, s) {
     common.npm([
-      "bugs", "optimist",
-      "--registry=" + common.registry,
-      "--loglevel=silent",
-      "--browser=" + join(__dirname, "/_script.sh")
+      'bugs', 'optimist',
+      '--registry=' + common.registry,
+      '--loglevel=silent',
+      '--browser=' + join(__dirname, '/_script.sh')
     ], opts, function (err, code, stdout, stderr) {
-      t.ifError(err, "bugs ran without issue")
-      t.notOk(stderr, "should have no stderr")
-      t.equal(code, 0, "exit ok")
-      var res = fs.readFileSync(outFile, "ascii")
+      t.ifError(err, 'bugs ran without issue')
+      t.notOk(stderr, 'should have no stderr')
+      t.equal(code, 0, 'exit ok')
+      var res = fs.readFileSync(outFile, 'ascii')
       s.close()
-      t.equal(res, "https://github.com/substack/node-optimist/issues\n")
+      t.equal(res, 'https://github.com/substack/node-optimist/issues\n')
       rimraf.sync(outFile)
       t.end()
     })
   })
 })
 
-test("npm bugs npm-test-peer-deps - no repo", function (t) {
-  mr({port : common.port}, function (er, s) {
+test('npm bugs npm-test-peer-deps - no repo', function (t) {
+  mr({ port: common.port }, function (er, s) {
     common.npm([
-      "bugs", "npm-test-peer-deps",
-      "--registry=" + common.registry,
-      "--loglevel=silent",
-      "--browser=" + join(__dirname, "/_script.sh")
+      'bugs', 'npm-test-peer-deps',
+      '--registry=' + common.registry,
+      '--loglevel=silent',
+      '--browser=' + join(__dirname, '/_script.sh')
     ], opts, function (err, code, stdout, stderr) {
-      t.ifError(err, "bugs ran without issue")
-      t.notOk(stderr, "should have no stderr")
-      t.equal(code, 0, "exit ok")
-      var res = fs.readFileSync(outFile, "ascii")
+      t.ifError(err, 'bugs ran without issue')
+      t.notOk(stderr, 'should have no stderr')
+      t.equal(code, 0, 'exit ok')
+      var res = fs.readFileSync(outFile, 'ascii')
       s.close()
-      t.equal(res, "https://www.npmjs.org/package/npm-test-peer-deps\n")
+      t.equal(res, 'https://www.npmjs.org/package/npm-test-peer-deps\n')
       rimraf.sync(outFile)
       t.end()
     })
   })
 })
 
-test("npm bugs test-repo-url-http - non-github (http://)", function (t) {
-  mr({port : common.port}, function (er, s) {
+test('npm bugs test-repo-url-http - non-github (http://)', function (t) {
+  mr({ port: common.port }, function (er, s) {
     common.npm([
-      "bugs", "test-repo-url-http",
-      "--registry=" + common.registry,
-      "--loglevel=silent",
-      "--browser=" + join(__dirname, "/_script.sh")
+      'bugs', 'test-repo-url-http',
+      '--registry=' + common.registry,
+      '--loglevel=silent',
+      '--browser=' + join(__dirname, '/_script.sh')
     ], opts, function (err, code, stdout, stderr) {
-      t.ifError(err, "bugs ran without issue")
-      t.notOk(stderr, "should have no stderr")
-      t.equal(code, 0, "exit ok")
-      var res = fs.readFileSync(outFile, "ascii")
+      t.ifError(err, 'bugs ran without issue')
+      t.notOk(stderr, 'should have no stderr')
+      t.equal(code, 0, 'exit ok')
+      var res = fs.readFileSync(outFile, 'ascii')
       s.close()
-      t.equal(res, "https://www.npmjs.org/package/test-repo-url-http\n")
+      t.equal(res, 'https://www.npmjs.org/package/test-repo-url-http\n')
       rimraf.sync(outFile)
       t.end()
     })
   })
 })
 
-test("npm bugs test-repo-url-https - non-github (https://)", function (t) {
-  mr({port : common.port}, function (er, s) {
+test('npm bugs test-repo-url-https - non-github (https://)', function (t) {
+  mr({ port: common.port }, function (er, s) {
     common.npm([
-      "bugs", "test-repo-url-https",
-      "--registry=" + common.registry,
-      "--loglevel=silent",
-      "--browser=" + join(__dirname, "/_script.sh")
+      'bugs', 'test-repo-url-https',
+      '--registry=' + common.registry,
+      '--loglevel=silent',
+      '--browser=' + join(__dirname, '/_script.sh')
     ], opts, function (err, code, stdout, stderr) {
-      t.ifError(err, "bugs ran without issue")
-      t.notOk(stderr, "should have no stderr")
-      t.equal(code, 0, "exit ok")
-      var res = fs.readFileSync(outFile, "ascii")
+      t.ifError(err, 'bugs ran without issue')
+      t.notOk(stderr, 'should have no stderr')
+      t.equal(code, 0, 'exit ok')
+      var res = fs.readFileSync(outFile, 'ascii')
       s.close()
-      t.equal(res, "https://www.npmjs.org/package/test-repo-url-https\n")
+      t.equal(res, 'https://www.npmjs.org/package/test-repo-url-https\n')
       rimraf.sync(outFile)
       t.end()
     })
   })
 })
 
-test("npm bugs test-repo-url-ssh - non-github (ssh://)", function (t) {
-  mr({port : common.port}, function (er, s) {
+test('npm bugs test-repo-url-ssh - non-github (ssh://)', function (t) {
+  mr({ port: common.port }, function (er, s) {
     common.npm([
-      "bugs", "test-repo-url-ssh",
-      "--registry=" + common.registry,
-      "--loglevel=silent",
-      "--browser=" + join(__dirname, "/_script.sh")
+      'bugs', 'test-repo-url-ssh',
+      '--registry=' + common.registry,
+      '--loglevel=silent',
+      '--browser=' + join(__dirname, '/_script.sh')
     ], opts, function (err, code, stdout, stderr) {
-      t.ifError(err, "bugs ran without issue")
-      t.notOk(stderr, "should have no stderr")
-      t.equal(code, 0, "exit ok")
-      var res = fs.readFileSync(outFile, "ascii")
+      t.ifError(err, 'bugs ran without issue')
+      t.notOk(stderr, 'should have no stderr')
+      t.equal(code, 0, 'exit ok')
+      var res = fs.readFileSync(outFile, 'ascii')
       s.close()
-      t.equal(res, "https://www.npmjs.org/package/test-repo-url-ssh\n")
+      t.equal(res, 'https://www.npmjs.org/package/test-repo-url-ssh\n')
       rimraf.sync(outFile)
       t.end()
     })
   })
 })
 
-test("cleanup", function (t) {
-  fs.unlinkSync(join(__dirname, "/_script.sh"))
-  t.pass("cleaned up")
+test('cleanup', function (t) {
+  fs.unlinkSync(join(__dirname, '/_script.sh'))
+  t.pass('cleaned up')
   t.end()
 })