src: make the npm source comply with `standard`

This is a huge set of mostly mechanical changes. Going forward, all
changes to the npm source base are expected to comply with `standard`,
and it's been integrated into the test suite to enforce that. There are
a few notes below about specific classes of changes that need to be
handled specially for npm's code base.

standard: "Expected error to be handled."

`standard` only expects errors spelled "err" to be handled.
`npm-registry-mock` never actually invokes its callback with an error,
so in some cases I just changed it to be spelled "er" and called it
good.

standard: "Expected a "break" statement before 'case'."

This behavior is actually on purpose, and I don't feel like rewriting
the affected code right now (or, you know, ever). So I added code
comments disabling the checks in the three applicable changes.

standard: "x is a function."

Rebinding functions created via declarations (as opposed to expressions)
is a no-no?

PR-URL: https://github.com/npm/npm/pull/8668

1 files changed, 12 insertions, 13 deletions

diff --git a/test/tap/cache-add-unpublished.js b/test/tap/cache-add-unpublished.js
index fe26929fc..fe6807f19 100644
--- a/test/tap/cache-add-unpublished.js
+++ b/test/tap/cache-add-unpublished.js
@@ -1,22 +1,21 @@
-var common = require("../common-tap.js")
-var test = require("tap").test
-var mr = require("npm-registry-mock")
+var common = require('../common-tap.js')
+var test = require('tap').test
 
-test("cache add", function (t) {
+test('cache add', function (t) {
   setup(function (er, s) {
     if (er) {
       throw er
     }
     common.npm([
-      "cache",
-      "add",
-      "superfoo",
-      "--registry=http://localhost:1337/"
+      'cache',
+      'add',
+      'superfoo',
+      '--registry=http://localhost:1337/'
     ], {}, function (er, c, so, se) {
       if (er) throw er
-      t.ok(c, "got non-zero exit code")
-      t.equal(so, "", "nothing printed to stdout")
-      t.similar(se, /404 Not Found: superfoo/, "got expected error")
+      t.ok(c, 'got non-zero exit code')
+      t.equal(so, '', 'nothing printed to stdout')
+      t.similar(se, /404 Not Found: superfoo/, 'got expected error')
       s.close()
       t.end()
     })
@@ -24,9 +23,9 @@ test("cache add", function (t) {
 })
 
 function setup (cb) {
-  var s = require("http").createServer(function (req, res) {
+  var s = require('http').createServer(function (req, res) {
     res.statusCode = 404
-    res.end("{\"error\":\"not_found\"}\n")
+    res.end('{\"error\":\"not_found\"}\n')
   })
   s.listen(1337, function () {
     cb(null, s)