src: make the npm source comply with `standard`

This is a huge set of mostly mechanical changes. Going forward, all
changes to the npm source base are expected to comply with `standard`,
and it's been integrated into the test suite to enforce that. There are
a few notes below about specific classes of changes that need to be
handled specially for npm's code base.

standard: "Expected error to be handled."

`standard` only expects errors spelled "err" to be handled.
`npm-registry-mock` never actually invokes its callback with an error,
so in some cases I just changed it to be spelled "er" and called it
good.

standard: "Expected a "break" statement before 'case'."

This behavior is actually on purpose, and I don't feel like rewriting
the affected code right now (or, you know, ever). So I added code
comments disabling the checks in the three applicable changes.

standard: "x is a function."

Rebinding functions created via declarations (as opposed to expressions)
is a no-no?

PR-URL: https://github.com/npm/npm/pull/8668

1 files changed, 20 insertions, 19 deletions

diff --git a/test/tap/config-basic.js b/test/tap/config-basic.js
index d5a950a8e..82fa8ab58 100644
--- a/test/tap/config-basic.js
+++ b/test/tap/config-basic.js
@@ -1,57 +1,58 @@
-var test = require("tap").test
-var npmconf = require("../../lib/config/core.js")
-var common = require("./00-config-setup.js")
-var path = require("path")
+var test = require('tap').test
+var npmconf = require('../../lib/config/core.js')
+var common = require('./00-config-setup.js')
+var path = require('path')
 
 var projectData = {
-  "save-prefix": "~",
-  "proprietary-attribs": false
+  'save-prefix': '~',
+  'proprietary-attribs': false
 }
 
 var ucData = common.ucData
 var envData = common.envData
 var envDataFix = common.envDataFix
 
-var gcData = { "package-config:foo": "boo" }
+var gcData = { 'package-config:foo': 'boo' }
 
 var biData = {}
 
-var cli = { foo: "bar", umask: 022 }
+var cli = { foo: 'bar', umask: parseInt('022', 8) }
 
-var expectList =
-[ cli,
+var expectList = [
+  cli,
   envDataFix,
   projectData,
   ucData,
   gcData,
-  biData ]
+  biData
+]
 
 var expectSources = {
   cli: { data: cli },
   env: {
     data: envDataFix,
     source: envData,
-    prefix: ""
+    prefix: ''
   },
   project: {
-    path: path.resolve(__dirname, "..", "..", ".npmrc"),
-    type: "ini",
+    path: path.resolve(__dirname, '..', '..', '.npmrc'),
+    type: 'ini',
     data: projectData
   },
   user: {
     path: common.userconfig,
-    type: "ini",
+    type: 'ini',
     data: ucData
   },
   global: {
     path: common.globalconfig,
-    type: "ini",
+    type: 'ini',
     data: gcData
   },
   builtin: { data: biData }
 }
 
-test("no builtin", function (t) {
+test('no builtin', function (t) {
   npmconf.load(cli, function (er, conf) {
     if (er) throw er
     t.same(conf.list, expectList)
@@ -59,8 +60,8 @@ test("no builtin", function (t) {
     t.same(npmconf.rootConf.list, [])
     t.equal(npmconf.rootConf.root, npmconf.defs.defaults)
     t.equal(conf.root, npmconf.defs.defaults)
-    t.equal(conf.get("umask"), 022)
-    t.equal(conf.get("heading"), "npm")
+    t.equal(conf.get('umask'), parseInt('022', 8))
+    t.equal(conf.get('heading'), 'npm')
     t.end()
   })
 })