src: make the npm source comply with `standard`

This is a huge set of mostly mechanical changes. Going forward, all
changes to the npm source base are expected to comply with `standard`,
and it's been integrated into the test suite to enforce that. There are
a few notes below about specific classes of changes that need to be
handled specially for npm's code base.

standard: "Expected error to be handled."

`standard` only expects errors spelled "err" to be handled.
`npm-registry-mock` never actually invokes its callback with an error,
so in some cases I just changed it to be spelled "er" and called it
good.

standard: "Expected a "break" statement before 'case'."

This behavior is actually on purpose, and I don't feel like rewriting
the affected code right now (or, you know, ever). So I added code
comments disabling the checks in the three applicable changes.

standard: "x is a function."

Rebinding functions created via declarations (as opposed to expressions)
is a no-no?

PR-URL: https://github.com/npm/npm/pull/8668

1 files changed, 28 insertions, 28 deletions

diff --git a/test/tap/config-edit.js b/test/tap/config-edit.js
index 97a54d2ec..f9e09aba3 100644
--- a/test/tap/config-edit.js
+++ b/test/tap/config-edit.js
@@ -1,39 +1,39 @@
-var fs = require("fs")
-var path = require("path")
+var fs = require('fs')
+var path = require('path')
 
-var mkdirp = require("mkdirp")
-var rimraf = require("rimraf")
-var test = require("tap").test
-var common = require("../common-tap.js")
+var mkdirp = require('mkdirp')
+var rimraf = require('rimraf')
+var test = require('tap').test
+var common = require('../common-tap.js')
 
-var pkg = path.resolve(__dirname, "npm-global-edit")
+var pkg = path.resolve(__dirname, 'npm-global-edit')
 
 var editorSrc = function () {/*
 #!/usr/bin/env node
-var fs = require("fs")
+var fs = require('fs')
 if (fs.existsSync(process.argv[2])) {
-  console.log("success")
+  console.log('success')
 } else {
-  console.log("error")
+  console.log('error')
   process.exit(1)
 }
-*/}.toString().split("\n").slice(1, -1).join("\n")
-var editorPath = path.join(pkg, "editor")
+*/}.toString().split('\n').slice(1, -1).join('\n')
+var editorPath = path.join(pkg, 'editor')
 
-test("setup", function (t) {
+test('setup', function (t) {
   cleanup(function (er) {
-    t.ifError(er, "old directory removed")
+    t.ifError(er, 'old directory removed')
 
-    mkdirp(pkg, "0777", function (er) {
+    mkdirp(pkg, '0777', function (er) {
       fs.writeFileSync(editorPath, editorSrc)
-      fs.chmodSync(editorPath, "0777")
-      t.ifError(er, "created package directory correctly")
+      fs.chmodSync(editorPath, '0777')
+      t.ifError(er, 'created package directory correctly')
       t.end()
     })
   })
 })
 
-test("saving configs", function (t) {
+test('saving configs', function (t) {
   var opts = {
     cwd: pkg,
     env: {
@@ -43,26 +43,26 @@ test("saving configs", function (t) {
   }
   common.npm(
     [
-      "config",
-      "--prefix", pkg,
-      "--global",
-      "edit"
+      'config',
+      '--prefix', pkg,
+      '--global',
+      'edit'
     ],
     opts,
     function (err, code, stdout, stderr) {
-      t.ifError(err, "command ran without issue")
+      t.ifError(err, 'command ran without issue')
 
-      t.equal(stderr, "", "got nothing on stderr")
-      t.equal(code, 0, "exit ok")
-      t.equal(stdout, "success\n", "got success message")
+      t.equal(stderr, '', 'got nothing on stderr')
+      t.equal(code, 0, 'exit ok')
+      t.equal(stdout, 'success\n', 'got success message')
       t.end()
     }
   )
 })
 
-test("cleanup", function (t) {
+test('cleanup', function (t) {
   cleanup(function (er) {
-    t.ifError(er, "test directory removed OK")
+    t.ifError(er, 'test directory removed OK')
     t.end()
   })
 })