src: make the npm source comply with `standard`

This is a huge set of mostly mechanical changes. Going forward, all
changes to the npm source base are expected to comply with `standard`,
and it's been integrated into the test suite to enforce that. There are
a few notes below about specific classes of changes that need to be
handled specially for npm's code base.

standard: "Expected error to be handled."

`standard` only expects errors spelled "err" to be handled.
`npm-registry-mock` never actually invokes its callback with an error,
so in some cases I just changed it to be spelled "er" and called it
good.

standard: "Expected a "break" statement before 'case'."

This behavior is actually on purpose, and I don't feel like rewriting
the affected code right now (or, you know, ever). So I added code
comments disabling the checks in the three applicable changes.

standard: "x is a function."

Rebinding functions created via declarations (as opposed to expressions)
is a no-no?

PR-URL: https://github.com/npm/npm/pull/8668

1 files changed, 17 insertions, 12 deletions

diff --git a/test/tap/dedupe.js b/test/tap/dedupe.js
index c6106f814..4c3424818 100644
--- a/test/tap/dedupe.js
+++ b/test/tap/dedupe.js
@@ -25,32 +25,31 @@ var json = {
 }
 
 var shrinkwrap = {
-  name: "dedupe",
-  version: "0.0.0",
+  name: 'dedupe',
+  version: '0.0.0',
   dependencies: {
     clean: {
-      version: "2.1.6",
+      version: '2.1.6',
       dependencies: {
         checker: {
-          version: "0.5.2",
+          version: '0.5.2',
           dependencies: {
-            async: { version: "0.2.10" }
+            async: { version: '0.2.10' }
           }
         },
-        minimist: { version: "0.0.5" }
+        minimist: { version: '0.0.5' }
       }
     },
     optimist: {
-      version: "0.6.0",
+      version: '0.6.0',
       dependencies: {
-        wordwrap: { version: "0.0.2" },
-        minimist: { version: "0.0.5" }
+        wordwrap: { version: '0.0.2' },
+        minimist: { version: '0.0.5' }
       }
     }
   }
 }
 
-
 test('setup', function (t) {
   t.comment('test for https://github.com/npm/npm/issues/4675')
   setup(function () {
@@ -78,8 +77,14 @@ test('dedupe finds the common module and moves it up one level', function (t) {
         t.notOk(code, 'npm dedupe exited with code')
 
         t.ok(existsSync(path.join(pkg, 'node_modules', 'minimist')), 'minimist module exists')
-        t.notOk(existsSync(path.join(pkg, 'node_modules', 'clean','node_modules','minimist')), 'no clean/minimist')
-        t.notOk(existsSync(path.join(pkg, 'node_modules', 'optimist','node_modules','minimist')), 'no optmist/minimist')
+        t.notOk(
+          existsSync(path.join(pkg, 'node_modules', 'clean', 'node_modules', 'minimist')),
+          'no clean/minimist'
+        )
+        t.notOk(
+          existsSync(path.join(pkg, 'node_modules', 'optimist', 'node_modules', 'minimist')),
+          'no optmist/minimist'
+        )
         t.end()
       }
     )