src: make the npm source comply with `standard`

This is a huge set of mostly mechanical changes. Going forward, all
changes to the npm source base are expected to comply with `standard`,
and it's been integrated into the test suite to enforce that. There are
a few notes below about specific classes of changes that need to be
handled specially for npm's code base.

standard: "Expected error to be handled."

`standard` only expects errors spelled "err" to be handled.
`npm-registry-mock` never actually invokes its callback with an error,
so in some cases I just changed it to be spelled "er" and called it
good.

standard: "Expected a "break" statement before 'case'."

This behavior is actually on purpose, and I don't feel like rewriting
the affected code right now (or, you know, ever). So I added code
comments disabling the checks in the three applicable changes.

standard: "x is a function."

Rebinding functions created via declarations (as opposed to expressions)
is a no-no?

PR-URL: https://github.com/npm/npm/pull/8668

1 files changed, 8 insertions, 8 deletions

diff --git a/test/tap/false-name.js b/test/tap/false-name.js
index 89e890e37..1e2a4d43d 100644
--- a/test/tap/false-name.js
+++ b/test/tap/false-name.js
@@ -54,14 +54,14 @@ test('not every pkg.name can be required', function (t) {
     function (err, code) {
       t.ifErr(err, 'install finished without error')
       t.equal(code, 0, 'install exited ok')
-      t.ok(existsSync(path.join(
-        pkg,
-        'node_modules','test-package-with-one-dep'
-      )), 'test-package-with-one-dep installed OK')
-      t.ok(existsSync(path.join(
-        pkg,
-        'node_modules','test-package'
-      )), 'test-pacakge subdep installed OK')
+      t.ok(
+        existsSync(path.join(pkg, 'node_modules', 'test-package-with-one-dep')),
+        'test-package-with-one-dep installed OK'
+      )
+      t.ok(
+        existsSync(path.join(pkg, 'node_modules', 'test-package')),
+        'test-pacakge subdep installed OK'
+      )
       t.end()
     }
   )