src: make the npm source comply with `standard`

This is a huge set of mostly mechanical changes. Going forward, all
changes to the npm source base are expected to comply with `standard`,
and it's been integrated into the test suite to enforce that. There are
a few notes below about specific classes of changes that need to be
handled specially for npm's code base.

standard: "Expected error to be handled."

`standard` only expects errors spelled "err" to be handled.
`npm-registry-mock` never actually invokes its callback with an error,
so in some cases I just changed it to be spelled "er" and called it
good.

standard: "Expected a "break" statement before 'case'."

This behavior is actually on purpose, and I don't feel like rewriting
the affected code right now (or, you know, ever). So I added code
comments disabling the checks in the three applicable changes.

standard: "x is a function."

Rebinding functions created via declarations (as opposed to expressions)
is a no-no?

PR-URL: https://github.com/npm/npm/pull/8668

1 files changed, 15 insertions, 15 deletions

diff --git a/test/tap/nerf-dart.js b/test/tap/nerf-dart.js
index 157f6c7df..a6df7272c 100644
--- a/test/tap/nerf-dart.js
+++ b/test/tap/nerf-dart.js
@@ -1,32 +1,32 @@
 // taken from https://raw.githubusercontent.com/indexzero/npm/bd3cad01fbd3ab481d2f5da441b9eead16029123/test/tap/config-nerf-dart.js
 // originally written by Charlie Robbins, https://github.com/indexzero
-var test = require("tap").test
-var toNerfDart = require("../../lib/config/nerf-dart.js")
+var test = require('tap').test
+var toNerfDart = require('../../lib/config/nerf-dart.js')
 
 function validNerfDart (uri, valid) {
-  if (!valid) valid = "//registry.npmjs.org/"
+  if (!valid) valid = '//registry.npmjs.org/'
   test(uri, function (t) {
     t.equal(toNerfDart(uri), valid)
     t.end()
   })
 }
 
-validNerfDart("http://registry.npmjs.org")
-validNerfDart("http://registry.npmjs.org/some-package")
-validNerfDart("http://registry.npmjs.org/some-package?write=true")
-validNerfDart("http://user:pass@registry.npmjs.org/some-package?write=true")
-validNerfDart("http://registry.npmjs.org/#random-hash")
-validNerfDart("http://registry.npmjs.org/some-package#random-hash")
+validNerfDart('http://registry.npmjs.org')
+validNerfDart('http://registry.npmjs.org/some-package')
+validNerfDart('http://registry.npmjs.org/some-package?write=true')
+validNerfDart('http://user:pass@registry.npmjs.org/some-package?write=true')
+validNerfDart('http://registry.npmjs.org/#random-hash')
+validNerfDart('http://registry.npmjs.org/some-package#random-hash')
 
 validNerfDart(
-  "http://relative.couchapp.npm/design/-/rewrite/",
-       "//relative.couchapp.npm/design/-/rewrite/"
+  'http://relative.couchapp.npm/design/-/rewrite/',
+       '//relative.couchapp.npm/design/-/rewrite/'
 )
 validNerfDart(
-  "http://relative.couchapp.npm:8080/design/-/rewrite/",
-       "//relative.couchapp.npm:8080/design/-/rewrite/"
+  'http://relative.couchapp.npm:8080/design/-/rewrite/',
+       '//relative.couchapp.npm:8080/design/-/rewrite/'
 )
 validNerfDart(
-  "http://relative.couchapp.npm:8080/design/-/rewrite/some-package",
-       "//relative.couchapp.npm:8080/design/-/rewrite/"
+  'http://relative.couchapp.npm:8080/design/-/rewrite/some-package',
+       '//relative.couchapp.npm:8080/design/-/rewrite/'
 )