src: make the npm source comply with `standard`

This is a huge set of mostly mechanical changes. Going forward, all
changes to the npm source base are expected to comply with `standard`,
and it's been integrated into the test suite to enforce that. There are
a few notes below about specific classes of changes that need to be
handled specially for npm's code base.

standard: "Expected error to be handled."

`standard` only expects errors spelled "err" to be handled.
`npm-registry-mock` never actually invokes its callback with an error,
so in some cases I just changed it to be spelled "er" and called it
good.

standard: "Expected a "break" statement before 'case'."

This behavior is actually on purpose, and I don't feel like rewriting
the affected code right now (or, you know, ever). So I added code
comments disabling the checks in the three applicable changes.

standard: "x is a function."

Rebinding functions created via declarations (as opposed to expressions)
is a no-no?

PR-URL: https://github.com/npm/npm/pull/8668

1 files changed, 23 insertions, 23 deletions

diff --git a/test/tap/nested-extraneous.js b/test/tap/nested-extraneous.js
index fcba0418e..99d4bea5b 100644
--- a/test/tap/nested-extraneous.js
+++ b/test/tap/nested-extraneous.js
@@ -1,42 +1,42 @@
-var common = require("../common-tap.js")
-var test = require("tap").test
-var mkdirp = require("mkdirp")
-var fs = require("fs")
-var rimraf = require("rimraf")
-var path = require("path")
+var common = require('../common-tap.js')
+var test = require('tap').test
+var mkdirp = require('mkdirp')
+var fs = require('fs')
+var rimraf = require('rimraf')
+var path = require('path')
 
-var pkg = path.resolve(__dirname, "nested-extraneous")
+var pkg = path.resolve(__dirname, 'nested-extraneous')
 var pj = {
-  name: "nested-extraneous",
-  version: "1.2.3"
+  name: 'nested-extraneous',
+  version: '1.2.3'
 }
 
-var dep = path.resolve(pkg, "node_modules", "dep")
+var dep = path.resolve(pkg, 'node_modules', 'dep')
 var deppj = {
-  name: "nested-extraneous-dep",
-  version: "1.2.3",
+  name: 'nested-extraneous-dep',
+  version: '1.2.3',
   dependencies: {
-    "nested-extra-depdep": "*"
+    'nested-extra-depdep': '*'
   }
 }
 
-var depdep = path.resolve(dep, "node_modules", "depdep")
+var depdep = path.resolve(dep, 'node_modules', 'depdep')
 var depdeppj = {
-  name: "nested-extra-depdep",
-  version: "1.2.3"
+  name: 'nested-extra-depdep',
+  version: '1.2.3'
 }
 
-test("setup", function (t) {
+test('setup', function (t) {
   rimraf.sync(pkg)
   mkdirp.sync(depdep)
-  fs.writeFileSync(path.resolve(pkg, "package.json"), JSON.stringify(pj))
-  fs.writeFileSync(path.resolve(dep, "package.json"), JSON.stringify(deppj))
-  fs.writeFileSync(path.resolve(depdep, "package.json"), JSON.stringify(depdeppj))
+  fs.writeFileSync(path.resolve(pkg, 'package.json'), JSON.stringify(pj))
+  fs.writeFileSync(path.resolve(dep, 'package.json'), JSON.stringify(deppj))
+  fs.writeFileSync(path.resolve(depdep, 'package.json'), JSON.stringify(depdeppj))
   t.end()
 })
 
-test("test", function (t) {
-  common.npm(["ls"], {
+test('test', function (t) {
+  common.npm(['ls'], {
     cwd: pkg
   }, function (er, code, sto, ste) {
     if (er) throw er
@@ -47,7 +47,7 @@ test("test", function (t) {
   })
 })
 
-test("clean", function (t) {
+test('clean', function (t) {
   rimraf.sync(pkg)
   t.end()
 })