src: make the npm source comply with `standard`

This is a huge set of mostly mechanical changes. Going forward, all
changes to the npm source base are expected to comply with `standard`,
and it's been integrated into the test suite to enforce that. There are
a few notes below about specific classes of changes that need to be
handled specially for npm's code base.

standard: "Expected error to be handled."

`standard` only expects errors spelled "err" to be handled.
`npm-registry-mock` never actually invokes its callback with an error,
so in some cases I just changed it to be spelled "er" and called it
good.

standard: "Expected a "break" statement before 'case'."

This behavior is actually on purpose, and I don't feel like rewriting
the affected code right now (or, you know, ever). So I added code
comments disabling the checks in the three applicable changes.

standard: "x is a function."

Rebinding functions created via declarations (as opposed to expressions)
is a no-no?

PR-URL: https://github.com/npm/npm/pull/8668

1 files changed, 39 insertions, 37 deletions

diff --git a/test/tap/prepublish.js b/test/tap/prepublish.js
index 36391beeb..f065a656a 100644
--- a/test/tap/prepublish.js
+++ b/test/tap/prepublish.js
@@ -1,16 +1,16 @@
 // verify that prepublish runs on pack and publish
-var common = require("../common-tap")
-var test = require("tap").test
-var fs = require("graceful-fs")
-var join = require("path").join
-var mkdirp = require("mkdirp")
-var rimraf = require("rimraf")
+var common = require('../common-tap')
+var test = require('tap').test
+var fs = require('graceful-fs')
+var join = require('path').join
+var mkdirp = require('mkdirp')
+var rimraf = require('rimraf')
 
-var pkg = join(__dirname, "prepublish_package")
-var tmp = join(pkg, "tmp")
-var cache = join(pkg, "cache")
+var pkg = join(__dirname, 'prepublish_package')
+var tmp = join(pkg, 'tmp')
+var cache = join(pkg, 'cache')
 
-test("setup", function (t) {
+test('setup', function (t) {
   var n = 0
   cleanup()
   mkdirp(pkg, then())
@@ -25,58 +25,60 @@ test("setup", function (t) {
   }
 
   function next () {
-    fs.writeFile(join(pkg, "package.json"), JSON.stringify({
-      name: "npm-test-prepublish",
-      version: "1.2.5",
-      scripts: { prepublish: "echo ok" }
-    }), "ascii", function (er) {
+    fs.writeFile(join(pkg, 'package.json'), JSON.stringify({
+      name: 'npm-test-prepublish',
+      version: '1.2.5',
+      scripts: { prepublish: 'echo ok' }
+    }), 'ascii', function (er) {
       if (er) throw er
 
-      t.pass("setup done")
+      t.pass('setup done')
       t.end()
     })
   }
 })
 
-test("test", function (t) {
+test('test', function (t) {
   var env = {
-    "npm_config_cache"  : cache,
-    "npm_config_tmp"    : tmp,
-    "npm_config_prefix" : pkg,
-    "npm_config_global" : "false"
+    'npm_config_cache': cache,
+    'npm_config_tmp': tmp,
+    'npm_config_prefix': pkg,
+    'npm_config_global': 'false'
   }
+
   for (var i in process.env) {
-    if (!/^npm_config_/.test(i))
+    if (!/^npm_config_/.test(i)) {
       env[i] = process.env[i]
+    }
   }
 
   common.npm([
-      "pack",
-      "--loglevel", "warn"
-    ], { cwd: pkg, env: env }, function(err, code, stdout, stderr) {
-    t.equal(code, 0, "pack finished successfully")
-    t.ifErr(err, "pack finished successfully")
+      'pack',
+      '--loglevel', 'warn'
+    ], { cwd: pkg, env: env }, function (err, code, stdout, stderr) {
+    t.equal(code, 0, 'pack finished successfully')
+    t.ifErr(err, 'pack finished successfully')
 
-    t.notOk(stderr, "got stderr data:" + JSON.stringify("" + stderr))
+    t.notOk(stderr, 'got stderr data:' + JSON.stringify('' + stderr))
     var c = stdout.trim()
-    var regex = new RegExp("" +
-      "> npm-test-prepublish@1.2.5 prepublish [^\\r\\n]+\\r?\\n" +
-      "> echo ok\\r?\\n" +
-      "\\r?\\n" +
-      "ok\\r?\\n" +
-      "npm-test-prepublish-1.2.5.tgz", "ig")
+    var regex = new RegExp('' +
+      '> npm-test-prepublish@1.2.5 prepublish [^\\r\\n]+\\r?\\n' +
+      '> echo ok\\r?\\n' +
+      '\\r?\\n' +
+      'ok\\r?\\n' +
+      'npm-test-prepublish-1.2.5.tgz', 'ig')
 
     t.ok(c.match(regex))
     t.end()
   })
 })
 
-test("cleanup", function (t) {
+test('cleanup', function (t) {
   cleanup()
-  t.pass("cleaned up")
+  t.pass('cleaned up')
   t.end()
 })
 
-function cleanup() {
+function cleanup () {
   rimraf.sync(pkg)
 }