src: make the npm source comply with `standard`

This is a huge set of mostly mechanical changes. Going forward, all
changes to the npm source base are expected to comply with `standard`,
and it's been integrated into the test suite to enforce that. There are
a few notes below about specific classes of changes that need to be
handled specially for npm's code base.

standard: "Expected error to be handled."

`standard` only expects errors spelled "err" to be handled.
`npm-registry-mock` never actually invokes its callback with an error,
so in some cases I just changed it to be spelled "er" and called it
good.

standard: "Expected a "break" statement before 'case'."

This behavior is actually on purpose, and I don't feel like rewriting
the affected code right now (or, you know, ever). So I added code
comments disabling the checks in the three applicable changes.

standard: "x is a function."

Rebinding functions created via declarations (as opposed to expressions)
is a no-no?

PR-URL: https://github.com/npm/npm/pull/8668

1 files changed, 22 insertions, 25 deletions

diff --git a/test/tap/registry.js b/test/tap/registry.js
index 060d9b67b..7ff4075bf 100644
--- a/test/tap/registry.js
+++ b/test/tap/registry.js
@@ -1,34 +1,31 @@
 // Run all the tests in the `npm-registry-couchapp` suite
 // This verifies that the server-side stuff still works.
 
-var common = require("../common-tap")
-var test = require("tap").test
+var common = require('../common-tap')
+var test = require('tap').test
 
-var npmExec = require.resolve("../../bin/npm-cli.js")
-var path = require("path")
-var ca = path.resolve(__dirname, "../../node_modules/npm-registry-couchapp")
+var npmExec = require.resolve('../../bin/npm-cli.js')
+var path = require('path')
+var ca = path.resolve(__dirname, '../../node_modules/npm-registry-couchapp')
 
-var which = require("which")
+var which = require('which')
 
-var v = process.versions.node.split(".").map(function (n) { return parseInt(n, 10) })
+var v = process.versions.node.split('.').map(function (n) { return parseInt(n, 10) })
 if (v[0] === 0 && v[1] < 10) {
   console.error(
-    "WARNING: need a recent Node for npm-registry-couchapp tests to run, have",
+    'WARNING: need a recent Node for npm-registry-couchapp tests to run, have',
     process.versions.node
   )
-}
-else {
-  which("couchdb", function (er) {
+} else {
+  which('couchdb', function (er) {
     if (er) {
-      console.error("WARNING: need couch to run test: " + er.message)
-    }
-    else {
+      console.error('WARNING: need couch to run test: ' + er.message)
+    } else {
       runTests()
     }
   })
 }
 
-
 function runTests () {
   var env = { TAP: 1 }
   for (var i in process.env) env[i] = process.env[i]
@@ -36,13 +33,13 @@ function runTests () {
 
   var opts = {
     cwd: ca,
-    stdio: "inherit"
+    stdio: 'inherit'
   }
-  common.npm(["install"], opts, function (err, code) {
+  common.npm(['install'], opts, function (err, code) {
     if (err) { throw err }
     if (code) {
-      return test("need install to work", function (t) {
-        t.fail("install failed with: " + code)
+      return test('need install to work', function (t) {
+        t.fail('install failed with: ' + code)
         t.end()
       })
 
@@ -50,22 +47,22 @@ function runTests () {
       opts = {
         cwd: ca,
         env: env,
-        stdio: "inherit"
+        stdio: 'inherit'
       }
-      common.npm(["test", "--", "-Rtap"], opts, function (err, code) {
+      common.npm(['test', '--', '-Rtap'], opts, function (err, code) {
         if (err) { throw err }
         if (code) {
-          return test("need test to work", function (t) {
-            t.fail("test failed with: " + code)
+          return test('need test to work', function (t) {
+            t.fail('test failed with: ' + code)
             t.end()
           })
         }
         opts = {
           cwd: ca,
           env: env,
-          stdio: "inherit"
+          stdio: 'inherit'
         }
-        common.npm(["prune", "--production"], opts, function (err, code) {
+        common.npm(['prune', '--production'], opts, function (err, code) {
           if (err) { throw err }
           process.exit(code || 0)
         })