src: make the npm source comply with `standard`

This is a huge set of mostly mechanical changes. Going forward, all
changes to the npm source base are expected to comply with `standard`,
and it's been integrated into the test suite to enforce that. There are
a few notes below about specific classes of changes that need to be
handled specially for npm's code base.

standard: "Expected error to be handled."

`standard` only expects errors spelled "err" to be handled.
`npm-registry-mock` never actually invokes its callback with an error,
so in some cases I just changed it to be spelled "er" and called it
good.

standard: "Expected a "break" statement before 'case'."

This behavior is actually on purpose, and I don't feel like rewriting
the affected code right now (or, you know, ever). So I added code
comments disabling the checks in the three applicable changes.

standard: "x is a function."

Rebinding functions created via declarations (as opposed to expressions)
is a no-no?

PR-URL: https://github.com/npm/npm/pull/8668

1 files changed, 17 insertions, 18 deletions

diff --git a/test/tap/spawn-enoent.js b/test/tap/spawn-enoent.js
index 29b70f6f8..320e477e0 100644
--- a/test/tap/spawn-enoent.js
+++ b/test/tap/spawn-enoent.js
@@ -1,32 +1,31 @@
-var path = require("path")
-var test = require("tap").test
-var fs = require("fs")
-var rimraf = require("rimraf")
-var mkdirp = require("mkdirp")
-var common = require("../common-tap.js")
+var path = require('path')
+var test = require('tap').test
+var fs = require('fs')
+var rimraf = require('rimraf')
+var mkdirp = require('mkdirp')
+var common = require('../common-tap.js')
 
-var pkg = path.resolve(__dirname, "spawn-enoent")
+var pkg = path.resolve(__dirname, 'spawn-enoent')
 var pj = JSON.stringify({
-  name:"x",
-  version: "1.2.3",
-  scripts: { start: "wharble-garble-blorst" }
-}, null, 2) + "\n"
+  name: 'x',
+  version: '1.2.3',
+  scripts: { start: 'wharble-garble-blorst' }
+}, null, 2) + '\n'
 
-
-test("setup", function (t) {
+test('setup', function (t) {
   rimraf.sync(pkg)
   mkdirp.sync(pkg)
-  fs.writeFileSync(pkg + "/package.json", pj)
+  fs.writeFileSync(pkg + '/package.json', pj)
   t.end()
 })
 
-test("enoent script", function (t) {
-  common.npm(["start"], {
+test('enoent script', function (t) {
+  common.npm(['start'], {
     cwd: pkg,
     env: {
       PATH: process.env.PATH,
       Path: process.env.Path,
-      "npm_config_loglevel": "warn"
+      'npm_config_loglevel': 'warn'
     }
   }, function (er, code, sout, serr) {
     t.similar(serr, /npm ERR! Failed at the x@1\.2\.3 start script 'wharble-garble-blorst'\./)
@@ -34,7 +33,7 @@ test("enoent script", function (t) {
   })
 })
 
-test("clean", function (t) {
+test('clean', function (t) {
   rimraf.sync(pkg)
   t.end()
 })