Age | Commit message (Collapse) | Author |
|
* Update to eslint@8 and and @npmcli/eslint-config@2.0.0
* Remove eslint-plugin-node.
Also remove an unused script that was failing linting. We don't use the
update-dist-tags script anymore as part of our release process.
PR-URL: https://github.com/npm/cli/pull/4016
Credit: @wraithgar
Close: #4016
Reviewed-by: @lukekarrys
|
|
This brings us in line with the rest of the linting rules we are wanting
to use on the npm cli repos.
There were several hundred over-length lines and instead of editing them
all by hand I piped the failing file through `prettier` and back through
`eslint` just to save some time and energy. This means there may be
some quirks in the linting those files have, but we can fix those if we
see them and they bother us.
Other than that there were about 50 lines that are legitimately
over-length, all are now explicitly overridden. Many are tests that
could be snapshots.
PR-URL: https://github.com/npm/cli/pull/3995
Credit: @wraithgar
Close: #3995
Reviewed-by: @lukekarrys
|
|
The install script will gracefully fail if things don't work. This is
especially important for versions of npm that won't work in your current
node version.
PR-URL: https://github.com/npm/cli/pull/3748
Credit: @wraithgar
Close: #3748
Reviewed-by: @isaacs
|
|
When we accidentally edit the auto-generated portions of the docs, this
will catch the error and cause CI to fail.
Later phase automated safety check that the early-stage human commenting
in the last commit also addresses.
Re: #3654
Re: #3630
PR-URL: https://github.com/npm/cli/pull/3655
Credit: @isaacs
Close: #3655
Reviewed-by: @nlf
|
|
This should prevent the kind of thing we've seen where people edit the
generated docs, as in #3654 and #3630, and provide them with a helpful
pointer so they put the config documentation changes in the right place.
|
|
Two files got into node_modules in a way that changes if you are on a
system that is case sensitive. One was a readme that is now properly
being ignored, the other is a typescript file that is upper case in some
instances
PR-URL: https://github.com/npm/cli/pull/3540
Credit: @wraithgar
Close: #3540
Reviewed-by: @ruyadorno
|
|
- Setup ./packages/* as workspaces
- Moved source from: https://github.com/npm/libnpmdiff to
./packages/libnpmdiff
- Added CI target for workspaces
Relates to: https://github.com/npm/statusboard/issues/362
PR-URL: https://github.com/npm/cli/pull/3386
Credit: @ruyadorno
Close: #3386
Reviewed-by: @wraithgar
|
|
We bundle our deps, but we don't need to bundle docs, changelogs,
editorconfigs, test coverage reports, .github workflow definitions,
lint configurations, and all the rest, which we never use.
This cuts about 10% off of our publish artifact file size.
```
$ ls -laF npm-7.16.0-*.tgz
-rw-r--r-- 1 isaacs staff 7174497 Jun 3 13:01 npm-7.16.0-release-next.tgz
-rw-r--r-- 1 isaacs staff 6782377 Jun 3 13:00 npm-7.16.0-trim-node-modules.tgz
$ ls -laF npm-7.16.0-*.tar
-rw-r--r-- 1 isaacs staff 19020288 Jun 3 13:01 npm-7.16.0-release-next.tar
-rw-r--r-- 1 isaacs staff 17474048 Jun 3 13:00 npm-7.16.0-trim-node-modules.tar
```
PR-URL: https://github.com/npm/cli/pull/3362
Credit: @isaacs
Close: #3362
Reviewed-by: @nlf
|
|
There is code in all of these places we control so it should be linted
PR-URL: https://github.com/npm/cli/pull/3367
Credit: @wraithgar
Close: #3367
Reviewed-by: @isaacs
|
|
- Add `./docs` as a workspace
- Reinstate `./docs/package.json` to manage docs deps
- Ignore `docs/content` markdown source folder from published tarball
- Tweaked `make docs` to use `npm run` to run docs build step
- Tweaked "bundle and gitignore" script to ignore symlinks in nm folder
- Removed outdated `package.json` comment
Relates to: https://github.com/npm/statusboard/issues/362
PR-URL: https://github.com/npm/cli/pull/3342
Credit: @ruyadorno
Close: #3342
Reviewed-by: @wraithgar
|
|
Add a script and Makefile rule to build the "Configuration" section for
all command documentation based on the command classes' `params` list.
Also correct several minor problems in the documentation, and add
`params` listings for commands that were lacking them, to match the
existing documentation and/or behavior within the code.
PR-URL: https://github.com/npm/cli/pull/3243
Credit: @isaacs
Close: #3243
Reviewed-by: @wraithgar
|
|
This adds the 'en' locale to all instances of String.localeCompare
within the CLI codebase.
Tests added for the cases where we're sorting arbitrary user-generated
data. The tests rely on the fact that 'ch' sorts after 'd' in the
`'sk'` locale, but ahead of `'d'` in the `'en'` locale. To ensure that
this is the default behavior if no locale is specified, `LC_ALL=sk` is
set in the test environment.
Other instances of `localeCompare` sort data that the cli controls, so
no tests were added.
Re: https://github.com/npm/cli/issues/2829
PR-URL: https://github.com/npm/cli/pull/3203
Credit: @isaacs
Close: #3203
Reviewed-by: @ruyadorno
|
|
|
|
PR-URL: https://github.com/npm/cli/pull/2613
Credit: @nlf
Close: #2613
Reviewed-by: @ljharb, @wraithgar
|
|
PR-URL: https://github.com/npm/cli/pull/2121
Credit: @nlf
Close: #2121
Reviewed-by: @isaacs
|
|
Less manual effort paper cuts.
|
|
|
|
Looks like the latest version of node-gyp has the .pyc in a
__pycache__ directory rather than with the other python files.
There is currently a non-exiting error when running the release
script due to this.
PR-URL: https://github.com/npm/cli/pull/2049
Credit: @MylesBorins
Close: #2049
Reviewed-by: @nlf
|
|
These links now reflect the reality of the filesystem and their paths.
|
|
Update the `docs-build.js` script to parse the name, man page section,
and description out of the frontmatter and use that for the generated
man page. This helps avoid repetition between the frontmatter section
and the body of the page itself.
Update the docs pages themselves to remove the H1 (title) and H2
(description). Finally, ensure that the frontmatter begins in column
0 on each page.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Fix #1037
|
|
Some of these are used under a somewhat ambiguous license, and we're
moving away from the WeAll* stuff to just rely on the centralized npm
code of conduct anyhow. Better to leave them out for now, as we go
through and update the deps themselves to have a cleaner and more
consistent project setup.
PR-URL: https://github.com/npm/cli/pull/1054
Credit: @isaacs
Close: #1054
Reviewed-by: @ruyadorno
|
|
PR-URL: https://github.com/npm/cli/pull/736
Credit: @
Close: #736
Reviewed-by: @Darcy Clarke
|
|
PR-URL: https://github.com/npm/cli/pull/656
Credit: @isaacs
Close: #656
Reviewed-by: @mikemimik
|
|
- Fixes ability to run tests using an arbitrary node bin
- Fixes `make test-npm` in nodejs repo
- Added `tap-snapshots` folder
- Added required `.npmrc` root file
Fixes npm/statusboard#45
PR-URL: https://github.com/npm/cli/pull/696
Credit: @ruyadorno
Close: #696
Reviewed-by: @mikemimik
|
|
PR-URL: https://github.com/npm/cli/pull/182
Credit: @Hoidberg
Close: #182
Reviewed-by: @mikemimik
|
|
chore(docs): fix styling issues on man and html docs
chore(docs): fix absolute links on cli docs
|
|
PR-URL: https://github.com/npm/cli/pull/283
Credit: @isaacs
Close: #283
Reviewed-by: @ruyadorno
|
|
|
|
- chore(docs): remove html from docs build
- feat(docs): migrate new Gatsby site to cli/docs
- chore(docs): fix docs url path
- chore(docs): add new build doc step
- chore(docs): add static linking
- chore(docs): add npm favicon
- chore(docs): update files for tests
- chore(docs): make relative paths absolute
- chore(docs): fix routing on docs dependant tests
- chore(docs): add prepublishOnly docs building step
- chore(docs): add docs/public to .gitignore
- chore(docs): rename dot json markdown files with hyphen names
- chore(docs): clean package.json
- chore(docs): highlight scripts in list
- chore(docs): add strong styles
- chore(docs): fix .json links on markdown
- Added copy to the features page
- Added an install page (copied from existing online docs)
- Added a FeatureLink component to components/links.js
- feat(docs): replace docs sh script with node
- chore(docs): fix docs building process
- chore(docs): docs folder cleanup
PR-URL: https://github.com/npm/cli/pull/274
Credit: @claudiahdz
Close: #274
Reviewed-by: @ruyadorno
|
|
|
|
|
|
|
|
On BSD platforms, there is a clear seperation between the OS and third
party packages. Here, bash is a third party package so it won't be
installed to /bin.
FreeBSD: /usr/local/bin/bash
NetBSD: /usr/pkg/bin/bash
OpenBSD: /usr/ports/bin/bash
As such, we need to use /usr/bin/env to launch these scripts.
Credit: @rsmarples
PR-URL: https://github.com/npm/cli/pull/212
Close: #212
Reviewed-by: @isaacs
|
|
not all the tar implementations support --version flag
e.g. the one used in openbsd doesn't, so the installation process fails
PR-URL: https://github.com/npm/cli/pull/154
Credit: @agudulin
Reviewed-By: @zkat
|
|
PR-URL: https://github.com/npm/cli/pull/144
Credit: @larsgw
Reviewed-By: @aeschright
|
|
Credit: @iarna
|
|
Credit: @iarna
|
|
Credit: @iarna
|
|
|
|
|
|
|
|
|
|
|