From 761577ef3bd60101abdb0e20691e4e675ed2f813 Mon Sep 17 00:00:00 2001 From: isaacs Date: Tue, 30 May 2017 13:30:40 -0700 Subject: test: test no-global-warns: Use clean env, allow prerelease node warning Credit: @isaacs Reviewed-By: @iarna PR-URL: https://github.com/npm/npm/pull/16804 --- test/tap/no-global-warns.js | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/test/tap/no-global-warns.js b/test/tap/no-global-warns.js index cae62fff9..577b39312 100644 --- a/test/tap/no-global-warns.js +++ b/test/tap/no-global-warns.js @@ -14,7 +14,16 @@ var toInstall = path.join(base, 'to-install') var config = 'prefix = ' + base var configPath = path.join(base, '_npmrc') -var OPTS = { } +// use a clean environment for this test +// otherwise local dev-time npm settings can throw it off +var OPTS = { + env: Object.keys(process.env).filter(function (k) { + return !/^npm_config_/i.test(k) + }).reduce(function (set, k) { + set[k] = process.env[k] + return set + }, {}) +} var installJSON = { name: 'to-install', @@ -43,6 +52,9 @@ test('no-global-warns', function (t) { OPTS, function (err, code, stdout, stderr) { t.ifError(err, 'installed w/o error') + const preWarn = 'npm WARN You are using a pre-release version ' + + 'of node and things may not work as expected' + stderr = stderr.trim().replace(preWarn, '') t.is(stderr, '', 'no warnings printed to stderr') t.end() }) -- cgit v1.2.3