From c0ac83224d49aa62e55577f8f27d53bbfd640dc5 Mon Sep 17 00:00:00 2001 From: isaacs Date: Sun, 2 Feb 2014 20:11:34 -0800 Subject: publishConfig: conf.save() should save actual config, not pubConf This avoids an error when the npm-registry-client gets a new token, and attempts to call conf.save('user'). However, a publishConfig can't save in this way, because it doesn't have a 'user' file source. Binding the save to the parent config *does* avoid the error, but of course, at the cost of making the save in this situation a no-op. --- lib/publish.js | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/publish.js b/lib/publish.js index 00ffdfae3..cede9ff0a 100644 --- a/lib/publish.js +++ b/lib/publish.js @@ -72,6 +72,7 @@ function publish_ (arg, data, isRetry, cachedir, cb) { var registry = npm.registry if (data.publishConfig) { var pubConf = new Conf(npm.config) + pubConf.save = npm.config.save.bind(npm.config) // don't modify the actual publishConfig object, in case we have // to set a login token or some other data. -- cgit v1.2.3