From 9dd369c05a2f899725d4ca3070389061cbcc1e5e Mon Sep 17 00:00:00 2001 From: isaacs Date: Mon, 4 Jun 2012 13:49:28 -0700 Subject: Open bug/doc urls properly on windows --- lib/bugs.js | 24 ++++++++++++++++++------ 1 file changed, 18 insertions(+), 6 deletions(-) (limited to 'lib/bugs.js') diff --git a/lib/bugs.js b/lib/bugs.js index 7982746cf..2a9352632 100644 --- a/lib/bugs.js +++ b/lib/bugs.js @@ -41,10 +41,22 @@ function bugs (args, cb) { } function open (url, cb) { - exec(npm.config.get("browser"), [url], log.er(cb, - "Failed to open "+url+" in a browser. It could be that the\n"+ - "'browser' config is not set. Try doing this:\n"+ - " npm config set browser google-chrome\n"+ - "or:\n"+ - " npm config set browser lynx\n")) + var args = [url] + , browser = npm.config.get("browser") + + if (process.platform === "win32" && browser === "start") { + args = [ "/c", "start" ].concat(args) + browser = "cmd" + } + + if (!browser) { + var er = ["the 'browser' config is not set. Try doing this:" + ," npm config set browser google-chrome" + ,"or:" + ," npm config set browser lynx"].join("\n") + return cb(er) + } + + exec(browser, args, process.env, false, function () {}) + cb() } -- cgit v1.2.3