From 9ab8b8d047792612ae7f9a6079745d51d5283a53 Mon Sep 17 00:00:00 2001 From: Dave Date: Thu, 21 Jan 2016 20:41:04 -0800 Subject: ls: don't subtract dev from production deps If a package is in dependencies and devDependencies, filterByEnv removes it from ls --production. This doesn't make sense, since the package is still a prod dependency. Fixes: #10820 PR-URL: https://github.com/npm/npm/pull/11245 Credit: @davidvgalbraith Reviewed-By: @iarna --- lib/ls.js | 1 - 1 file changed, 1 deletion(-) (limited to 'lib/ls.js') diff --git a/lib/ls.js b/lib/ls.js index 1c9292082..dbaae5190 100644 --- a/lib/ls.js +++ b/lib/ls.js @@ -120,7 +120,6 @@ function filterByEnv (data) { var devDependencies = data.devDependencies || [] Object.keys(data.dependencies).forEach(function (name) { var keys = Object.keys(devDependencies) - if (production && !dev && keys.indexOf(name) !== -1) return if (dev && !production && keys.indexOf(name) === -1) return if (!dev && keys.indexOf(name) !== -1 && data.dependencies[name].missing) return dependencies[name] = data.dependencies[name] -- cgit v1.2.3