From d27c18195478462d7e5dcdbdba220e790e07af12 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kat=20March=C3=A1n?= Date: Fri, 12 May 2017 02:33:31 -0700 Subject: actions: converted actions.js to use mainly promises --- test/tap/install-actions.js | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) (limited to 'test') diff --git a/test/tap/install-actions.js b/test/tap/install-actions.js index 824a31c1b..6ca6e3353 100644 --- a/test/tap/install-actions.js +++ b/test/tap/install-actions.js @@ -56,8 +56,10 @@ test('->optdep:a->dep:b', function (t) { moduleB.parent = tree t.plan(3) - actions.postinstall('/', moduleA, mockLog, function (er) { - t.is(er && er.code, 'ELIFECYCLE', 'Lifecycle failed') + return actions.postinstall('/', moduleA, mockLog).then(() => { + throw new Error('was not supposed to succeed') + }, (err) => { + t.is(err && err.code, 'ELIFECYCLE', 'Lifecycle failed') t.ok(moduleA.failed, 'moduleA (optional dep) is marked failed') t.ok(moduleB.failed, 'moduleB (direct dep of moduleA) is marked as failed') t.end() @@ -108,8 +110,10 @@ test('->dep:b,->optdep:a->dep:b', function (t) { moduleB.parent = tree t.plan(3) - actions.postinstall('/', moduleA, mockLog, function (er) { - t.ok(er && er.code === 'ELIFECYCLE', 'Lifecycle failed') + return actions.postinstall('/', moduleA, mockLog).then(() => { + throw new Error('was not supposed to succeed') + }, (err) => { + t.ok(err && err.code === 'ELIFECYCLE', 'Lifecycle failed') t.ok(moduleA.failed, 'moduleA (optional dep) is marked failed') t.ok(!moduleB.failed, 'moduleB (direct dep of moduleA) is marked as failed') t.end() -- cgit v1.2.3