Don't recreate db after it was closed

2 files changed, 21 insertions, 0 deletions

diff --git a/src/common/syncjournaldb.cpp b/src/common/syncjournaldb.cpp
index b79a038b5..6bafbaa62 100644
--- a/src/common/syncjournaldb.cpp
+++ b/src/common/syncjournaldb.cpp
@@ -250,6 +250,10 @@ bool SyncJournalDb::sqlFail(const QString &log, const SqlQuery &query)
 
 bool SyncJournalDb::checkConnect()
 {
+    if (_closed) {
+        qCWarning(lcDb) << Q_FUNC_INFO << "after the db was closed";
+        return false;
+    }
     if (autotestFailCounter >= 0) {
         if (!autotestFailCounter--) {
             qCInfo(lcDb) << "Error Simulated";
@@ -625,8 +629,14 @@ void SyncJournalDb::close()
     _db.close();
     clearEtagStorageFilter();
     _metadataTableIsEmpty = false;
+    _closed = true;
 }
 
+void SyncJournalDb::allowReopen()
+{
+    Q_ASSERT(_closed);
+    _closed = false;
+}
 
 bool SyncJournalDb::updateDatabaseStructure()
 {
diff --git a/src/common/syncjournaldb.h b/src/common/syncjournaldb.h
index 933fcbbee..ad68c7f11 100644
--- a/src/common/syncjournaldb.h
+++ b/src/common/syncjournaldb.h
@@ -220,6 +220,12 @@ public:
     void close();
 
     /**
+     * allow to reopen/recreate the db after it was closed (unit tests)
+     * This is usually not allowed to prevent accidential recreation of db.
+     */
+    void allowReopen();
+
+    /**
      * Returns the checksum type for an id.
      */
     QByteArray getChecksumType(int checksumTypeId);
@@ -413,6 +419,11 @@ private:
     QByteArray _journalMode;
 
     PreparedSqlQueryManager _queryManager;
+
+    /**
+     * Whether the db was already closed, prevent recreation
+     */
+    bool _closed = false;
 };
 
 bool OCSYNC_EXPORT