Use NtfsPermissionLookupRAII when checking for readable/writeabel

1 files changed, 9 insertions, 0 deletions

diff --git a/src/common/filesystembase.cpp b/src/common/filesystembase.cpp
index 066e20373..640589ca3 100644
--- a/src/common/filesystembase.cpp
+++ b/src/common/filesystembase.cpp
@@ -100,6 +100,7 @@ void FileSystem::setFileReadOnly(const QString &filename, bool readonly)
     if (!readonly) {
         permissions |= defaultWritePermissions;
     }
+    // Warning: This function does not manipulate ACLs, which may limit its effectiveness.
     file.setPermissions(permissions);
 }
 
@@ -197,6 +198,10 @@ bool FileSystem::uncheckedRenameReplace(const QString &originFileName,
 
 #else //Q_OS_WIN
     // You can not overwrite a read-only file on windows.
+
+    Utility::NtfsPermissionLookupRAII ntfs_perm;
+    // Warning: This function does not manipulate ACLs, which may limit its effectiveness.
+    // this renders this check kind of pointless
     if (!QFileInfo(destinationFileName).isWritable()) {
         setFileReadOnly(destinationFileName, false);
     }
@@ -362,6 +367,10 @@ bool FileSystem::remove(const QString &fileName, QString *errorString)
 #ifdef Q_OS_WIN
     // You cannot delete a read-only file on windows, but we want to
     // allow that.
+
+    Utility::NtfsPermissionLookupRAII ntfs_perm;
+    // Warning: This function does not manipulate ACLs, which may limit its effectiveness.
+    // this renders this check kind of pointless
     if (!QFileInfo(fileName).isWritable()) {
         setFileReadOnly(fileName, false);
     }