Replace custom argument parsing with QCommandLineParser (#8632)

* Replace custom argument parsing with QCommandLineParser

* Remove obsolete --logwindow option

* Translate all strings in commandline arguments parsing

* Use QCommandLineParser to display help and version information

This commit further eliminates the now-obsolete showHint function. QCommandLineParser does not show a hint to use --help, so we should no longer do this either in order to provide a unified UX.

* Parse arguments passed to method as parameter

* Ensure correct order of format string arguments

1 files changed, 0 insertions, 15 deletions

diff --git a/src/gui/application.h b/src/gui/application.h
index 547367b4a..30c708c28 100644
--- a/src/gui/application.h
+++ b/src/gui/application.h
@@ -59,14 +59,7 @@ public:
     explicit Application(int &argc, char **argv);
     ~Application() override;
 
-    bool giveHelp();
-    void showHelp();
-    void showHint(const QString &errorHint);
     bool debugMode();
-    bool versionOnly(); // only display the version?
-    void showVersion();
-    bool listAvailableTranslationsOnly();
-    void listAvailableTranslations();
 
     void showSettingsDialog();
 
@@ -110,8 +103,6 @@ protected slots:
     void slotSystemOnlineConfigurationChanged(QNetworkConfiguration);
 
 private:
-    void setHelp();
-
     /**
      * Maybe a newer version of the client was used with this config file:
      * if so, backup, confirm with user and remove the config that can't be read.
@@ -122,17 +113,11 @@ private:
 
     Theme *_theme;
 
-    bool _helpOnly;
-    bool _versionOnly;
-    bool _listAvailableTranslationsOnly;
-
-
 #ifdef Q_OS_LINUX
     QElapsedTimer _startedAt;
 #endif
 
     // options from command line:
-    bool _showLogWindow;
     bool _showSettings = false;
     bool _quitInstance = false;
     QString _logFile;