Use the refcounted AccountStatePtr as much as possible

The AccountManager creates AccountState objects, and stores them in a
shared pointer.

Previously, the raw pointer was given out, and stored in other objects.
That made removal very tricky: when an account gets removed, the
underlying object gets deleted, and then all classes that listen get
notified of the deletion. Those classes would sometimes put a nullptr
into the AccountState pointer they stored, and in each usage would
(hopefully) check for a nullptr. The problem was that a number of checks
were missing, which the clang static analyser pointed out.

This patch changes nearly all uses of a raw pointer into the shared
pointer, thereby making sure all usages have a valid reference, even
when account deletion happens. The two places where a raw pointer is
still used, now put it into a refcounted pointer as soon as possible.

1 files changed, 2 insertions, 2 deletions

diff --git a/src/gui/folderstatusmodel.cpp b/src/gui/folderstatusmodel.cpp
index 06f64118b..f3a2630e6 100644
--- a/src/gui/folderstatusmodel.cpp
+++ b/src/gui/folderstatusmodel.cpp
@@ -62,7 +62,7 @@ static bool sortByFolderHeader(const FolderStatusModel::SubFolderInfo &lhs, cons
         < 0;
 }
 
-void FolderStatusModel::setAccountState(const AccountState *accountState)
+void FolderStatusModel::setAccountState(AccountStatePtr accountState)
 {
     beginResetModel();
     _dirty = false;
@@ -106,7 +106,7 @@ void FolderStatusModel::setAccountState(const AccountState *accountState)
 Qt::ItemFlags FolderStatusModel::flags(const QModelIndex &index) const
 {
     if (!_accountState) {
-        return nullptr;
+        return Qt::NoItemFlags;
     }
 
     // Always enable the item. If it isn't enabled, it cannot be in the selection model, so all