diff options
author | Christian Kamm <mail@ckamm.de> | 2018-04-09 12:02:29 +0300 |
---|---|---|
committer | ckamm <mail@ckamm.de> | 2018-04-10 09:38:59 +0300 |
commit | eef275a1e426809fbe5d276143ca1ca1cc953164 (patch) | |
tree | 788d1aa69a36ff9b4b4e60d2a087a03817cf0533 /src/gui/folderstatusmodel.cpp | |
parent | 1114b8ce0a99c31fb5ce9f2e0df57c4711c58a99 (diff) |
Folders: Use "Problem" icon for unresolved conflicts #6277
Diffstat (limited to 'src/gui/folderstatusmodel.cpp')
-rw-r--r-- | src/gui/folderstatusmodel.cpp | 12 |
1 files changed, 9 insertions, 3 deletions
diff --git a/src/gui/folderstatusmodel.cpp b/src/gui/folderstatusmodel.cpp index 96de011c1..2e784101b 100644 --- a/src/gui/folderstatusmodel.cpp +++ b/src/gui/folderstatusmodel.cpp @@ -245,9 +245,15 @@ QVariant FolderStatusModel::data(const QModelIndex &index, int role) const } else if (status == SyncResult::Undefined) { return theme->syncStateIcon(SyncResult::SyncRunning); } else { - // keep the previous icon for the prepare phase. - if (status == SyncResult::Problem) { - return theme->syncStateIcon(SyncResult::Success); + // The "Problem" *result* just means some files weren't + // synced, so we show "Success" in these cases. But we + // do use the "Problem" *icon* for unresolved conflicts. + if (status == SyncResult::Success || status == SyncResult::Problem) { + if (f->syncResult().hasUnresolvedConflicts()) { + return theme->syncStateIcon(SyncResult::Problem); + } else { + return theme->syncStateIcon(SyncResult::Success); + } } else { return theme->syncStateIcon(status); } |