Remove possible qt containers detach (#8727)

* Replaced obsolete foreach-loops with for-loops

* Added a copy of queries into SqlDatabase::close

* Used const reference to avoid unneeded copying

* Fixed Qt containers possible detach within for-loop

* Removed unneeded copies before for-loops

1 files changed, 2 insertions, 2 deletions

diff --git a/src/gui/ignorelisteditor.cpp b/src/gui/ignorelisteditor.cpp
index 0e1eee22c..0b11543cb 100644
--- a/src/gui/ignorelisteditor.cpp
+++ b/src/gui/ignorelisteditor.cpp
@@ -96,7 +96,7 @@ void IgnoreListEditor::slotUpdateLocalIgnoreList()
             if (patternItem->data(isGlobalRole).toBool())
                 continue;
 
-            QStringList skippedLines = patternItem->data(skippedLinesRole).toStringList();
+            const auto &skippedLines = patternItem->data(skippedLinesRole).toStringList();
             for (const auto &line : skippedLines)
                 ignores.write(line.toUtf8() + '\n');
 
@@ -119,7 +119,7 @@ void IgnoreListEditor::slotUpdateLocalIgnoreList()
     // We need to force a remote discovery after a change of the ignore list.
     // Otherwise we would not download the files/directories that are no longer
     // ignored (because the remote etag did not change)   (issue #3172)
-    foreach (Folder *folder, folderMan->map()) {
+    for (auto *folder : folderMan->map()) {
         folder->journalDb()->forceRemoteDiscoveryNextSync();
         folder->slotNextSyncFullLocalDiscovery();
         folderMan->scheduleFolder(folder);