Network Settings: Adjust the bandwidth limit option with old Qt

- Disable the whole group box
- Add a tooltip explaining why it is disabled
- Make sure it is disabled in the settings in case of upgrade
- Do a runtime check in case the running Qt is greater

1 files changed, 19 insertions, 13 deletions

diff --git a/src/gui/networksettings.cpp b/src/gui/networksettings.cpp
index 2c5a22a71..6a21f0466 100644
--- a/src/gui/networksettings.cpp
+++ b/src/gui/networksettings.cpp
@@ -117,23 +117,29 @@ void NetworkSettings::loadProxySettings()
 
 void NetworkSettings::loadBWLimitSettings()
 {
+    ConfigFile cfgFile;
+
 #if QT_VERSION < QT_VERSION_CHECK(5,3,3)
-    // QNAM bandwith limiting only works with versions of Qt greater or equal to 5.3.3
+    // QNAM bandwidth limiting only works with versions of Qt greater or equal to 5.3.3
     // (It needs Qt commits 097b641 and b99fa32)
-    _ui->noDownloadLimitRadioButton->setChecked(true);
-    _ui->downloadLimitRadioButton->setEnabled(false);
-    _ui->noDownloadLimitRadioButton->setEnabled(false);
-    _ui->autoDownloadLimitRadioButton->setEnabled(false);
-
-    _ui->noUploadLimitRadioButton->setChecked(true);
-    _ui->uploadLimitRadioButton->setEnabled(false);
-    _ui->noUploadLimitRadioButton->setEnabled(false);
-    _ui->autoUploadLimitRadioButton->setEnabled(false);
-    return;
-#endif
 
-    ConfigFile cfgFile;
+    const char *v = qVersion(); // "x.y.z";
+    if (QLatin1String(v) < QLatin1String("5.3.3")) {
+        QString tooltip = tr("Qt >= 5.4 is required in order to use the bandwidth limit");
+        _ui->downloadBox->setEnabled(false);
+        _ui->uploadBox->setEnabled(false);
+        _ui->downloadBox->setToolTip(tooltip);
+        _ui->uploadBox->setToolTip(tooltip);
+        _ui->noDownloadLimitRadioButton->setChecked(true);
+        _ui->noUploadLimitRadioButton->setChecked(true);
+        if (cfgFile.useUploadLimit() != 0 || cfgFile.useDownloadLimit() != 0) {
+            // Update from old mirall that was using neon propagator jobs.
+            saveBWLimitSettings();
+        }
+        return;
+    }
 
+#endif
     int useDownloadLimit = cfgFile.useDownloadLimit();
     if ( useDownloadLimit >= 1 ) {
         _ui->downloadLimitRadioButton->setChecked(true);