Add a more functional error view #5516 (#5861)

* Add a more functional error view #5516

* Allow filtering of ignores and warnings to see only important bits.
* Navigate from the folder view to the error view by clicking on the
  error list with the red background.
* Move the error list into its own ui file to allow easier extension.
* Fix issue around tab id handling in ActivitySettings.
* Rename "Action" column to "Issue".
* Change mouse cursor to hand over button and new error list area

Several OSX fixes provided by guruz.

1 files changed, 4 insertions, 13 deletions

diff --git a/src/gui/protocolwidget.h b/src/gui/protocolwidget.h
index 927a23c4b..7e3a154a5 100644
--- a/src/gui/protocolwidget.h
+++ b/src/gui/protocolwidget.h
@@ -46,12 +46,13 @@ public:
     ~ProtocolWidget();
     QSize sizeHint() const { return ownCloudGui::settingsDialogSize(); }
 
-    QTreeWidget *issueWidget() { return _issueItemView; }
     void storeSyncActivity(QTextStream &ts);
-    void storeSyncIssues(QTextStream &ts);
+
+    // Shared with IssueWidget
+    static QTreeWidgetItem *createCompletedTreewidgetItem(const QString &folder, const SyncFileItem &item);
+    static QString timeString(QDateTime dt, QLocale::FormatType format = QLocale::NarrowFormat);
 
 public slots:
-    void slotProgressInfo(const QString &folder, const ProgressInfo &progress);
     void slotItemCompleted(const QString &folder, const SyncFileItemPtr &item);
     void slotOpenFile(QTreeWidgetItem *item, int);
 
@@ -61,19 +62,9 @@ protected:
 
 signals:
     void copyToClipboard();
-    void issueItemCountUpdated(int);
 
 private:
-    void setSyncResultStatus(const SyncResult &result);
-    void cleanItems(const QString &folder);
-
-    QTreeWidgetItem *createCompletedTreewidgetItem(const QString &folder, const SyncFileItem &item);
-
-    QString timeString(QDateTime dt, QLocale::FormatType format = QLocale::NarrowFormat) const;
-
-    const int IgnoredIndicatorRole;
     Ui::ProtocolWidget *_ui;
-    QTreeWidget *_issueItemView;
 };
 }
 #endif // PROTOCOLWIDGET_H