diff options
author | Olivier Goffart <ogoffart@woboq.com> | 2017-09-20 11:14:48 +0300 |
---|---|---|
committer | Olivier Goffart <olivier@woboq.com> | 2017-09-21 15:05:39 +0300 |
commit | ff4213b59f223b60e87e70af2db6201986f76df8 (patch) | |
tree | 98398cd1a1014b9ef1c47457b9139ccf3a546ace /src/gui/proxyauthhandler.cpp | |
parent | c4e51247d833d4f08df7036fe4a7823a6f6e0ff6 (diff) |
Use the Qt5 connection syntax (automated with clazy)
This is motivated by the fact that QMetaObject::noralizeSignature takes 7.35%
CPU of the LargeSyncBench. (Mostly from ABstractNetworkJob::setupConnections and
PropagateUploadFileV1::startNextChunk). It could be fixed by using normalized
signature in the connection statement, but i tought it was a good oportunity
to modernize the code.
This commit only contains calls that were automatically converted with clazy.
Diffstat (limited to 'src/gui/proxyauthhandler.cpp')
-rw-r--r-- | src/gui/proxyauthhandler.cpp | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/src/gui/proxyauthhandler.cpp b/src/gui/proxyauthhandler.cpp index 5b7d7382d..f2ccd97ac 100644 --- a/src/gui/proxyauthhandler.cpp +++ b/src/gui/proxyauthhandler.cpp @@ -131,8 +131,8 @@ void ProxyAuthHandler::handleProxyAuthenticationRequired( sending_qnam = qnam_alive.data(); if (sending_qnam) { _gaveCredentialsTo.insert(sending_qnam); - connect(sending_qnam, SIGNAL(destroyed(QObject *)), - SLOT(slotSenderDestroyed(QObject *))); + connect(sending_qnam, &QObject::destroyed, + this, &ProxyAuthHandler::slotSenderDestroyed); } } @@ -194,8 +194,8 @@ bool ProxyAuthHandler::getCredsFromKeychain() _readPasswordJob->setInsecureFallback(false); _readPasswordJob->setKey(keychainPasswordKey()); _readPasswordJob->setAutoDelete(false); - connect(_readPasswordJob.data(), SIGNAL(finished(QKeychain::Job *)), - SLOT(slotKeychainJobDone())); + connect(_readPasswordJob.data(), &QKeychain::Job::finished, + this, &ProxyAuthHandler::slotKeychainJobDone); _keychainJobRunning = true; _readPasswordJob->start(); } @@ -242,7 +242,7 @@ void ProxyAuthHandler::storeCredsInKeychain() job->setKey(keychainPasswordKey()); job->setTextData(_password); job->setAutoDelete(false); - connect(job, SIGNAL(finished(QKeychain::Job *)), SLOT(slotKeychainJobDone())); + connect(job, &QKeychain::Job::finished, this, &ProxyAuthHandler::slotKeychainJobDone); _keychainJobRunning = true; job->start(); |