Fix logging of auth type

1 files changed, 13 insertions, 10 deletions

diff --git a/src/libsync/determineauthtypejobfactory.cpp b/src/libsync/determineauthtypejobfactory.cpp
index f83cfd6fa..9ec017089 100644
--- a/src/libsync/determineauthtypejobfactory.cpp
+++ b/src/libsync/determineauthtypejobfactory.cpp
@@ -60,18 +60,21 @@ CoreJob *DetermineAuthTypeJobFactory::startJob(const QUrl &url)
 
         const auto authChallenge = reply->rawHeader(QByteArrayLiteral("WWW-Authenticate")).toLower();
 
-        // we fall back to basic in any case
-        if (authChallenge.contains(QByteArrayLiteral("bearer "))) {
-            setJobResult(job, QVariant::fromValue(AuthType::OAuth));
-        } else {
-            if (authChallenge.isEmpty()) {
-                qCWarning(lcDetermineAuthTypeJob) << "Did not receive WWW-Authenticate reply to auth-test PROPFIND";
+        const AuthType authType = [authChallenge]() {
+            // we fall back to basic in any case
+            if (authChallenge.contains(QByteArrayLiteral("bearer "))) {
+                return AuthType::OAuth;
+            } else {
+                if (authChallenge.isEmpty()) {
+                    qCWarning(lcDetermineAuthTypeJob) << "Did not receive WWW-Authenticate reply to auth-test PROPFIND";
+                }
+
+                return AuthType::Basic;
             }
+        }();
 
-            setJobResult(job, QVariant::fromValue(AuthType::Basic));
-        }
-
-        qCInfo(lcDetermineAuthTypeJob) << "Auth type for" << reply->url() << "is" << job->result();
+        qCInfo(lcDetermineAuthTypeJob) << "Auth type for" << reply->url() << "is" << authType;
+        setJobResult(job, qVariantFromValue(authType));
     });
 
     return job;