Removed unnecessary temporary containers during iteration over QMap values

3 files changed, 10 insertions, 10 deletions

diff --git a/src/gui/accountsettings.cpp b/src/gui/accountsettings.cpp
index 1a398ba71..850719af0 100644
--- a/src/gui/accountsettings.cpp
+++ b/src/gui/accountsettings.cpp
@@ -823,7 +823,7 @@ void AccountSettings::slotAccountStateChanged()
         QUrl safeUrl(account->url());
         safeUrl.setPassword(QString()); // Remove the password from the URL to avoid showing it in the UI
         FolderMan *folderMan = FolderMan::instance();
-        for (Folder *folder : folderMan->map().values()) {
+        for (Folder *folder : folderMan->map()) {
             _model->slotUpdateFolderState(folder);
         }
 
@@ -961,7 +961,7 @@ void AccountSettings::refreshSelectiveSyncStatus()
 {
     QString msg;
     int cnt = 0;
-    for (Folder *folder : FolderMan::instance()->map().values()) {
+    for (Folder *folder : FolderMan::instance()->map()) {
         if (folder->accountState() != _accountState) {
             continue;
         }
diff --git a/src/gui/folderman.cpp b/src/gui/folderman.cpp
index 520b3b6db..7d063a53e 100644
--- a/src/gui/folderman.cpp
+++ b/src/gui/folderman.cpp
@@ -543,7 +543,7 @@ Folder *FolderMan::folder(const QString &alias)
 
 void FolderMan::scheduleAllFolders()
 {
-    foreach (Folder *f, _folderMap.values()) {
+    foreach (Folder *f, _folderMap) {
         if (f && f->canSync()) {
             scheduleFolder(f);
         }
@@ -663,7 +663,7 @@ void FolderMan::slotAccountStateChanged()
     if (accountState->isConnected()) {
         qCInfo(lcFolderMan) << "Account" << accountName << "connected, scheduling its folders";
 
-        foreach (Folder *f, _folderMap.values()) {
+        foreach (Folder *f, _folderMap) {
             if (f
                 && f->canSync()
                 && f->accountState() == accountState) {
@@ -674,7 +674,7 @@ void FolderMan::slotAccountStateChanged()
         qCInfo(lcFolderMan) << "Account" << accountName << "disconnected or paused, "
                                                            "terminating or descheduling sync folders";
 
-        foreach (Folder *f, _folderMap.values()) {
+        foreach (Folder *f, _folderMap) {
             if (f
                 && f->isSyncRunning()
                 && f->accountState() == accountState) {
@@ -1047,7 +1047,7 @@ Folder *FolderMan::folderForPath(const QString &path, QString *relativePath)
 {
     QString absolutePath = QDir::cleanPath(path) + QLatin1Char('/');
 
-    foreach (Folder *folder, this->map().values()) {
+    foreach (Folder *folder, this->map()) {
         const QString folderPath = folder->cleanPath() + QLatin1Char('/');
 
         if (absolutePath.startsWith(folderPath, (Utility::isWindows() || Utility::isMac()) ? Qt::CaseInsensitive : Qt::CaseSensitive)) {
@@ -1073,7 +1073,7 @@ QStringList FolderMan::findFileInLocalFolders(const QString &relPath, const Acco
     if (!serverPath.startsWith('/'))
         serverPath.prepend('/');
 
-    foreach (Folder *folder, this->map().values()) {
+    foreach (Folder *folder, this->map()) {
         if (acc != nullptr && folder->accountState()->account() != acc) {
             continue;
         }
@@ -1206,7 +1206,7 @@ bool FolderMan::startFromScratch(const QString &localFolder)
 
 void FolderMan::setDirtyProxy()
 {
-    foreach (Folder *f, _folderMap.values()) {
+    foreach (Folder *f, _folderMap) {
         if (f) {
             if (f->accountState() && f->accountState()->account()
                 && f->accountState()->account()->networkAccessManager()) {
@@ -1220,7 +1220,7 @@ void FolderMan::setDirtyProxy()
 
 void FolderMan::setDirtyNetworkLimits()
 {
-    foreach (Folder *f, _folderMap.values()) {
+    foreach (Folder *f, _folderMap) {
         // set only in busy folders. Otherwise they read the config anyway.
         if (f && f->isBusy()) {
             f->setDirtyNetworkLimits();
diff --git a/src/gui/owncloudgui.cpp b/src/gui/owncloudgui.cpp
index 83ce47f39..edecdd194 100644
--- a/src/gui/owncloudgui.cpp
+++ b/src/gui/owncloudgui.cpp
@@ -287,7 +287,7 @@ void ownCloudGui::slotComputeOverallSyncStatus()
         trayMessage = folderMan->trayTooltipStatusString(trayOverallStatusResult.overallStatus, trayOverallStatusResult.hasUnresolvedConflicts, false);
 #else
         QStringList allStatusStrings;
-        foreach (Folder *folder, map.values()) {
+        foreach (Folder *folder, map) {
             QString folderMessage = FolderMan::trayTooltipStatusString(
                 folder->syncResult().status(),
                 folder->syncResult().hasUnresolvedConflicts(),