Refactor protocol and issue widget

3 files changed, 50 insertions, 1 deletions

diff --git a/test/modeltests/CMakeLists.txt b/test/modeltests/CMakeLists.txt
index c7f4bc693..e2e5d5934 100644
--- a/test/modeltests/CMakeLists.txt
+++ b/test/modeltests/CMakeLists.txt
@@ -1 +1,2 @@
 owncloud_add_test(ActivityModel)
+owncloud_add_test(ProtocolModel)
diff --git a/test/modeltests/testactivitymodel.cpp b/test/modeltests/testactivitymodel.cpp
index 63cec088b..066a9c9b8 100644
--- a/test/modeltests/testactivitymodel.cpp
+++ b/test/modeltests/testactivitymodel.cpp
@@ -23,7 +23,7 @@ private Q_SLOTS:
     {
         auto model = new ActivityListModel(this);
 
-        auto tester = new QAbstractItemModelTester(model, this);
+        new QAbstractItemModelTester(model, this);
 
         auto manager = AccountManager::instance();
 
diff --git a/test/modeltests/testprotocolmodel.cpp b/test/modeltests/testprotocolmodel.cpp
new file mode 100644
index 000000000..2462827cc
--- /dev/null
+++ b/test/modeltests/testprotocolmodel.cpp
@@ -0,0 +1,48 @@
+
+/*
+ *    This software is in the public domain, furnished "as is", without technical
+ *    support, and with no warranty, express or implied, as to its usefulness for
+ *    any purpose.
+ *
+ */
+
+#include "gui/protocolitemmodel.h"
+
+#include <QTest>
+#include <QAbstractItemModelTester>
+
+namespace OCC {
+
+class TestProtocolModel : public QObject
+{
+    Q_OBJECT
+
+private Q_SLOTS:
+    void testInsertAndRemove()
+    {
+        // no need to test with 20000 lines
+        const auto TestBacklogSize = 111;
+        auto model = new ProtocolItemModel(this, false, TestBacklogSize);
+
+        new QAbstractItemModelTester(model, this);
+
+        // populate with dummy data
+        auto item = SyncFileItemPtr::create();
+        for (int i = 0; i < TestBacklogSize * 1.1; ++i) {
+            model->addProtocolItem({ ProtocolItem(QStringLiteral("foo") + QString::number(i), item) });
+        }
+
+        const auto oldSize = model->rowCount();
+        QCOMPARE(oldSize, TestBacklogSize);
+        // pick one from the middle
+        const auto toBeRemoved = model->protocolItem(model->index(TestBacklogSize / 2, 0));
+        model->remove([&toBeRemoved](const ProtocolItem &pi) {
+            return pi.folderName() == toBeRemoved.folderName();
+        });
+        QCOMPARE(oldSize - 1, model->rowCount());
+    }
+};
+}
+
+QTEST_GUILESS_MAIN(OCC::TestProtocolModel)
+#include "testprotocolmodel.moc"