| Age | Commit message (Collapse) | Author |
|---|
|
This matches the old behaviour
|
|
That way we can use it to check for ssl errors
|
|
|
|
|
|
Needed to be able to access planned TLS certificate handling related methods.
|
|
|
|
|
|
|
|
Fixes: #9545
|
|
|
|
|
|
Not only does that make using the class easier by fixing the DRY problem, but it also makes sure the dialogs look the same no matter how they are initialized.
Another such named constructor will be added later for the new wizard.
|
|
Using inheritance here instead of a factory saves some boilerplate code,
and apparently it's the Qt way of life.
|
|
|
|
|
|
The AccountManager creates AccountState objects, and stores them in a
shared pointer.
Previously, the raw pointer was given out, and stored in other objects.
That made removal very tricky: when an account gets removed, the
underlying object gets deleted, and then all classes that listen get
notified of the deletion. Those classes would sometimes put a nullptr
into the AccountState pointer they stored, and in each usage would
(hopefully) check for a nullptr. The problem was that a number of checks
were missing, which the clang static analyser pointed out.
This patch changes nearly all uses of a raw pointer into the shared
pointer, thereby making sure all usages have a valid reference, even
when account deletion happens. The two places where a raw pointer is
still used, now put it into a refcounted pointer as soon as possible.
|
|
This happened when an URL is updated (e.g. due to a redirect), and the
user does not accept it.
|
|
Co-authored-by: Dominik Schmidt <dschmidt@owncloud.com>
|
|
|
|
|
|
|
|
Fixes #8924
|
|
When the client detects a change of the url we ask the user to accept
the change or if it was only representational change we directly accept the change.
Due to a bug the we aborted the sync only after we updated the url.
This caused the client to idle for one minute.
|
|
This patch only fixes those warnings that we can still build against
Qt 5.12.
|
|
Fixes: #8901
|
|
* Add remotePollInterval capability.
* Use public const int rather than define for default value.
* Honour pollinterval from account capabilities for poll frequency.
With this, admins can change the remote poll interval of desktop
clients with the capability settings.
* Use more efficient invocation of the etag job slot.
* Consider capability value to be in milliseconds.
* Make format check happy.
* Add a ElapsedTimer to measure time since last Etag check.
Also, do the check if one of the folders is due to sync every
second. That way we get a more accurate sync frequency. The
check is very lightweight.
* Extend remotePollInterval config method to accept default value.
With that it is possible to read the value for the remotepollinterval
from the capabilities.
* Add changelog entry for #8777.
* Changes from clang-format
* Fix changelog entry, punctuation at end.
* do not go for assumptions how long the request takes. No magic number.
* Change some method interfaces to seconds rather than microseconds.
Feedback from review.
* Again considering more review feedback
* Remove additional 5s check already performed in ConfigFile::remotePollInterval
Co-authored-by: Hannah von Reth <hannah.vonreth@owncloud.com>
|
|
|
|
is already running
|
|
Fixes: #8645
|
|
Fixes: #8645
|
|
|
|
|
|
|
|
This fixes issues with some middleware
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
not when it was processed by the client, to determine the quality of the connection.
|
|
|
|
|
|
This got inverted accidentally when std::chrono was introduced.
For #7160
|
|
This can happen when the client is started and the internet connection
was not enabled. Then we would fetch the credentials, but we would
no do the refresh token step (because network is down).
So next time we try to connect, we would also not refresh the token
because the credentials are not marked as 'ready'
Reported in
https://github.com/owncloud/client/issues/6522#issuecomment-396845167
|
|
So no need to have a manual conversion to QString
This is only used in debug message anyway.
|
|
|
