| Age | Commit message (Collapse) | Author |
|---|
|
|
|
- replaced "No filter" option text with "All", to avoid the "No filter
is not enabled" situation
- replace the "Filter" label on the button with "1 Filter"/"2 Filters"
when a filter is active, so a user can immediately see that without
having to open the filter pop-up
|
|
The `Models::addFilterMenuItems` method is used in 2 cases, once in the
`ActivityWidget`, and once in the `ProtocolWidget`. Both have their own
item model, so both need their own role passed in for filtering on.
The bug was that `ProtocolItemModel::ProtocolItemRole::Account` was used
forall cases, even when a `ActivityListModel::ActivityRole::Account`
should have been passed in.
Fixes: https://github.com/owncloud/client/issues/9425
|
|
Fixes: #9494
|
|
Fixes: #9367
|
|
|
|
|
|
The AccountManager creates AccountState objects, and stores them in a
shared pointer.
Previously, the raw pointer was given out, and stored in other objects.
That made removal very tricky: when an account gets removed, the
underlying object gets deleted, and then all classes that listen get
notified of the deletion. Those classes would sometimes put a nullptr
into the AccountState pointer they stored, and in each usage would
(hopefully) check for a nullptr. The problem was that a number of checks
were missing, which the clang static analyser pointed out.
This patch changes nearly all uses of a raw pointer into the shared
pointer, thereby making sure all usages have a valid reference, even
when account deletion happens. The two places where a raw pointer is
still used, now put it into a refcounted pointer as soon as possible.
|
|
|
|
Fixes: #9000
|
|
* Replaced obsolete foreach-loops with for-loops
* Added a copy of queries into SqlDatabase::close
* Used const reference to avoid unneeded copying
* Fixed Qt containers possible detach within for-loop
* Removed unneeded copies before for-loops
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
We now hav proper headers and sortig capabilities
Fixes: #8158
|
|
|
|
Fixes: #8085
|
|
|
|
While the change seemed to fix a issue with heme switching on mac, it broke
Windows 100% of the time....
This reverts commit 996bedc3aedc0be5882e02741a0745a3c8f6611f.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Issue #6728
|
|
Issue #6728
|
|
The mingw compiler isn't happy with them.
|
|
the account is removed
Issue #6679
|
|
|
|
(cherry picked from commit e86416fff7c74174e699802cec46da8ca3c3aad5)
|
|
Some slot were protected or private but needed to be public.
Some needed a static_cast (can't use qOverload because it is in Qt 5.7)
This is not only a partial change.
|
|
This is motivated by the fact that QMetaObject::noralizeSignature takes 7.35%
CPU of the LargeSyncBench. (Mostly from ABstractNetworkJob::setupConnections and
PropagateUploadFileV1::startNextChunk). It could be fixed by using normalized
signature in the connection statement, but i tought it was a good oportunity
to modernize the code.
This commit only contains calls that were automatically converted with clazy.
|
|
|
|
Now that csync builds as C++, this will avoid having to implement
functionalities needed by csync mandatorily in csync itself.
This library is built as part of libocsync and symbols exported
through it.
This requires a relicense of Utility as LGPL. All classes moved into
this library from src/libsync will need to be relicensed as well.
|
|
* Add a more functional error view #5516
* Allow filtering of ignores and warnings to see only important bits.
* Navigate from the folder view to the error view by clicking on the
error list with the red background.
* Move the error list into its own ui file to allow easier extension.
* Fix issue around tab id handling in ActivitySettings.
* Rename "Action" column to "Issue".
* Change mouse cursor to hand over button and new error list area
Several OSX fixes provided by guruz.
|
|
That's an undefined behavior.
Since we don't use the return value anyway, we should just use start()
|
|
|
|
Use qCInfo for anything that has general value for support and
development. Use qCWarning for any recoverable error and qCCritical
for anything that could result in data loss or would identify a serious
issue with the code.
Issue #5647
|
|
This gives more insight about the logs and allow setting fine-tuned
logging rules. The categories are set to only output Info by default
so this allows us to provide more concise logging while keeping the
ability to extract more information for a specific category when
developping or debugging customer issues.
Issue #5647
|
|
By default QNetworkReply::errorString() often produces messages like
"Error downloading <url> - server replied: <reason>"
but the "downloading" part invariably confuses people since the
error might very well have been produced by a PUT request.
This commit produces clearer error messages for HTTP errors.
Additionally:
* Remove some unnecessary null checks from slots connected to
network job signals and document that these signals never send
null replies.
* There was a bug where AbstractNetworkJob::_timedout wasn't
set when derived classes overrode slotTimeout. We now ensure
it's always set by disallowing overrides of slotTimeout.
Instead it now calls onTimedOut, which allows custom handling.
* Several subclasses declared errorString, isTimedOut. Move
these to AbstractNetworkJob.
* Unify handling of OC-ErrorString (via the new, general
Job::errorString)
* Add documentation in various places.
|
|
This refers to the message shown when copying the list of unsynced items on the activity tab
|
|
See #5180
|
