Age | Commit message (Collapse) | Author |
|
|
|
|
|
|
|
|
|
Fixes: #9545
|
|
* Integrate Hannah's new DetermineAuthTypeJob2
* Allow use of OAuth class without account
This commit extracts the account-specific code (for use during normal
runtime, i.e., after the wizard has succeeded). Using a derived class
instead of a factory (job) saves some boilerplate code in this scenario.
* Move DetermineUserJobFactory into creds
* Emphasize purpose of class
* Fix file name
* Rename methods
* Split declaration and definition
* Add missing docstrings
* Give core job class a better name
* Document difference between core and other jobs
|
|
|
|
Fixes: #9196
|
|
|
|
|
|
|
|
|
|
|
|
Issue was introduced in 3d878bae27ba22ecdf07313725b085b84c62af1a
|
|
Fixes: #8313
|
|
successful authentication
Fixes: #8041
|
|
warning C4002: too many arguments for function-like macro invocation 'ENFORCE_1'
|
|
Fixes: #7833
|
|
|
|
Issue: #7888
|
|
|
|
And also replace all remaining Q_DECL_OVERRIDE to just override
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
This reverts commit c47af368328e0cbacde7d6abeda4b6f4291cc86f.
It turned out to be a dead end.
|
|
|
|
|
|
|
|
This does not fix a bug, just was found while spotting a bug that was no bug.
For https://github.com/owncloud/enterprise/issues/2951
|
|
It still reads and writes the old format too, but all newly stored
client certs will be in the new form.
For #6776 because Windows limits credential data to 512 bytes in older
versions.
|
|
Conflicts:
VERSION.cmake
src/common/syncjournaldb.cpp
src/libsync/propagatedownload.cpp
|
|
For https://github.com/owncloud/enterprise/issues/2951
|
|
|
|
https://sentry.io/owncloud/desktop-win-and-mac/issues/777907931/
mention a crash in OCC::HttpCredentialsGui::showDialog
One possible explaination is that this is caused by re-entring the event loop.
So don't do that.
|
|
Issue #6451
|
|
We need to use the user id to check if we are connected to the right account.
These might be different from the HTTP Basic Auth login. (LDAP setups)
When the account was configured as an oauth2 account form the wisard, the
http_user was already set correctly to the user id. But when the server is
upgrading from basic auth to oauth2, we need to pick the right login.
Note that Account::davUser() already defaults to the HTTP user when none
is set, so this means the upgrade will be fine if this is not set in the
config.
Issues:
https://github.com/owncloud/oauth2/issues/109
https://github.com/owncloud/enterprise/issues/2781
|
|
There is no real reason to have a timeout. The connection can stay open
as long as we are not authenticated. The User can still re-open a browser
from the UI at any time.
Issue #6612
|
|
Issue #6574
When there is an error in the advanced page, OwncloudAdvancedSetupPage::updateStatus
(and others) call completeChanged(), which is connected to
QWizardPrivate::_q_updateButtonStates which will re-enable the back button from the
last page.
When the user click "back" and re-open the browser, the account's credentials
already have a oauth token set. So the call to the API to get a new token fails
because we use the previous token instead of using the client's secret_id.
Fix this with the HttpCredentials::DontAddCredentialsAttribute.
Now, this is still not working because the session cookies are confusing the
server. So we'll clear the cookies when re-opening the browser
|
|
For QUrl::setQuery is deprecated in Qt5
|
|
If the server support both Shibboleth and OAuth2, upgrades to OAuth2
Issue #6198
|
|
This restores 2.3 behavior. Some servers reply 404 to GETs and PROPFINDs
to the remote.php/webdav/ url and used to work. Being more picky would
break them.
|
|
With some firewalls we can't GET /remote.php/webdav/. Here we keep the
GET request to detect shibboleth through the redirect pattern but then
use PROPFIND to figure out the http auth method.
Currently we prefer OAuth to Shibboleth to Basic auth.
This also restores the fallback behavior of assuming basic auth
when no auth type can be determined.
|
|
Now that we use Qt5, we should do that. It is slightly more efficient
and declares the intent.
(Modified using clazy)
|
|
This is an ugly solution.
|
|
Include a test for PR #6057
|