| Age | Commit message (Collapse) | Author |
|---|
|
|
|
The AccountManager creates AccountState objects, and stores them in a
shared pointer.
Previously, the raw pointer was given out, and stored in other objects.
That made removal very tricky: when an account gets removed, the
underlying object gets deleted, and then all classes that listen get
notified of the deletion. Those classes would sometimes put a nullptr
into the AccountState pointer they stored, and in each usage would
(hopefully) check for a nullptr. The problem was that a number of checks
were missing, which the clang static analyser pointed out.
This patch changes nearly all uses of a raw pointer into the shared
pointer, thereby making sure all usages have a valid reference, even
when account deletion happens. The two places where a raw pointer is
still used, now put it into a refcounted pointer as soon as possible.
|
|
|
|
Conflicts:
CHANGELOG.md
VERSION.cmake
src/gui/MacOSXBundleInfo.plist
src/gui/folderstatusmodel.h
src/gui/settingsdialog.cpp
|
|
The change is based on 97ce20ac028660e6ae3dd0b98d4b487999d8768a
I removed a few lines of code there which are already part of fetchMore()
Fixes: #7336
|
|
|
|
And also replace all remaining Q_DECL_OVERRIDE to just override
|
|
OCC::FolderStatusModel::slotUpdateDirectories: ASSERT: "parentInfo->_fetching" in file /home/olivier/kdegit/owncloud/mirall/src/gui/folderstatusmodel.cpp, line 599
This can happen if the structure of a folder is change while the user
expands the root folder. In this case, resetSubs() is called which
resets _fetching to false.
Instead, we need to keep a pointer to the job so we can abort it by
deleting it.
|
|
|
|
|
|
These would otherwise be line-wrapped by clang-format,
and then consecutive reformattings remove the aligned
comment indentation
Example:
int a; // too long comment
->
int a; // too long
// comment
->
int a; // too long
// comment
|
|
This gives more insight about the logs and allow setting fine-tuned
logging rules. The categories are set to only output Info by default
so this allows us to provide more concise logging while keeping the
ability to extract more information for a specific category when
developping or debugging customer issues.
Issue #5647
|
|
Issue: https://github.com/owncloud/client/pull/5340#issuecomment-274564441
|
|
Instead of using the regular selective-sync UI (where it's unclear what
the "Cancel" button would even mean in this context), provide a
different set of buttons that allow the user to quickly synchronize
all pending big folders, none of them, or perform manual changes
as usual.
|
|
I got into a situation where the model would endlessly request the directory
contents from the server because we did not notice yet that the server
is actually in maintenance mode while we were expanding the tree view when
changing the tab to the account or when just expanding it by clicking.
|
|
|
|
We now show 'Fetching data...' after a second.
This also increased the timeout to 60s, making the error
condition much less likely.
|
|
|
|
We monitor the scheduling queue and show messages like
"Waiting for 5 other folders...".
|
|
Will be usefull to solve #3704
|
|
|
|
|
|
Issue #3420
(The change in Utility just make sure never to use the scientific notation,
even if it should never happen)
|
|
Previously you could get a green folder icon even when the account
was signed out or disconnected for another reason.
|
|
Previously the icon and progress report could easily get
somewhat stale and go out of sync with the tray icon.
|
|
|
|
- rename target "doc-dev"
- group into modules
- move to doc/dev
|
|
This header is not included in Qt4's QAbstractItemModel header
|
|
|
|
|
|
Folder that are over the threshold will appear in red in the
selective sync view and will be deselected by default
|
|
|
|
|
|
This is required to compile with Qt4 because signals were protected.
And the logic anyway belongs to the model
|
|
|
|
It is unused and there were compiler warnings about it not
appearing it various switch() statements.
|
|
|
|
|
|
|
|
Conflicts:
src/CMakeLists.txt
src/gui/accountsettings.cpp
src/gui/folderwizard.cpp
src/gui/settingsdialog.cpp
src/libsync/syncengine.h
|
|
|
