Age | Commit message (Collapse) | Author |
|
|
|
|
|
|
|
|
|
|
|
* Replaced obsolete foreach-loops with for-loops
* Added a copy of queries into SqlDatabase::close
* Used const reference to avoid unneeded copying
* Fixed Qt containers possible detach within for-loop
* Removed unneeded copies before for-loops
|
|
Fixes: #8648
|
|
|
|
Once the slash is gone, an assert is triggered, making the software terminate unexpectedly:
[...] [ fatal default ]: ASSERT: "relativePath.startsWith(QLatin1Char('/'))" in file .../client/src/libsync/abstractnetworkjob.cpp, line 196
This happens when trying to add a directory synchronization, in the second step where the remote directory is selected, once you click on the next button.
|
|
|
|
And also replace all remaining Q_DECL_OVERRIDE to just override
|
|
As far as I'm aware local discovery can be skipped on folders that are
selective-sync blacklisted, so a local discovery is required when an
entry is removed from the blacklist.
Also rename
avoidReadFromDbOnNextSync() -> schedulePathForRemoteDiscovery()
since the old name might also imply it's not read from db in the local
discovery - which is not the case. Use Folder::
schedulePathForLocalDiscovery() for that.
|
|
Since we are now skipping the full local discovery, we also need to
call the method to force a full local discovery while we were making
full remote discovery, for the same reason.
Same applies when applying a selective sync: Normally there should not
be any file or directory with the same same of a blacklisted folder, but
if there is one, it was ignored and now need to be taken in account.
Also make the F6 shortcut do a full local discovery as well.
|
|
Make ExcludedFiles something that is instantiated outside of
the CSYNC context and then given to it as a hook.
ExcludedFiles still lives in csync_exclude and the internal
workings haven't been touched.
|
|
Some slot were protected or private but needed to be public.
Some needed a static_cast (can't use qOverload because it is in Qt 5.7)
This is not only a partial change.
|
|
This is motivated by the fact that QMetaObject::noralizeSignature takes 7.35%
CPU of the LargeSyncBench. (Mostly from ABstractNetworkJob::setupConnections and
PropagateUploadFileV1::startNextChunk). It could be fixed by using normalized
signature in the connection statement, but i tought it was a good oportunity
to modernize the code.
This commit only contains calls that were automatically converted with clazy.
|
|
|
|
|
|
This gives more insight about the logs and allow setting fine-tuned
logging rules. The categories are set to only output Info by default
so this allows us to provide more concise logging while keeping the
ability to extract more information for a specific category when
developping or debugging customer issues.
Issue #5647
|
|
It should be parented to the treeview to be sure that is shows inside of it.
|
|
|
|
Many public slots didn't need to be public or slots.
|
|
|
|
|
|
If there is a read error from the database while trying to get
the list from database, make sure to not behave badly because
the list is empty.
|
|
This will help moving the SyncEngine construction in the constructor
and allow moving functionalities from Folder to SyncEngine or its
delegated objects.
|
|
|
|
Relates to issue #4491
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Mentioned in https://github.com/owncloud/client/issues/3524#issuecomment-132144532
|
|
Issue #3239
The feature to dynamically resize the column only came with Qt5,
But give a better default size of the name column so we can read the
contents.
|
|
Conflicts:
src/gui/folder.cpp
src/gui/folder.h
src/gui/folderman.cpp
|
|
|
|
I want to remove this dependency of alias in the code because we might get
rid of it entierly later
|
|
|
|
|
|
Fixes #3112
|
|
|
|
So the discovery phase don't ask for the quota, and the selective sync
don't ask for all the other properties
Issue #2906
|
|
Relates to issue #2788
|
|
Usefull when the folder does not exist (for example in case the theme
has a defaultServerFolder that does not yet exist, #2788)
But also to avoid confusion (issue #2663)
|
|
Especially the selective sync dialog
Task #2788
|
|
Have different wording depending on the wizardSelectiveSyncDefaultNothing theme option
Relates to #2580
|