From 384f18da3895251fbfc8f69ca02e65db6e8728b7 Mon Sep 17 00:00:00 2001 From: Jocelyn Turcotte Date: Mon, 27 Feb 2017 17:09:29 +0100 Subject: Potential fix for crash in PropagateDirectory::abort (#5564) --- src/libsync/owncloudpropagator.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/libsync/owncloudpropagator.cpp b/src/libsync/owncloudpropagator.cpp index f54d57a33..6e73c0d5d 100644 --- a/src/libsync/owncloudpropagator.cpp +++ b/src/libsync/owncloudpropagator.cpp @@ -661,8 +661,10 @@ void PropagateDirectory::slotSubJobFinished(SyncFileItem::Status status) _firstJob.take(); } else { int i = _subJobs.indexOf(subJob); + // Shouldn't happen but could be -1 if finished was emitted twice for a job. ASSERT(i >= 0); - _subJobs.remove(i); + if (i >= 0) + _subJobs.remove(i); } if (status == SyncFileItem::FatalError || -- cgit v1.2.3