From 31c699be26ea9f2529141232bbbfa80e05b2cd6d Mon Sep 17 00:00:00 2001 From: Christian Kamm Date: Fri, 29 Mar 2019 10:14:31 +0100 Subject: PropagateDirectory: Remove dead code 1. The _firstJob is usually deleted by the time the PropagateDirectory finishes. (deleteLater() is called early) 2. The PropagateDirectory::_item and PropagateRemoteMkdir::_item point to the same SyncFileItem anyway. This code is a leftover from when each job had its own instance. --- src/libsync/owncloudpropagator.cpp | 6 ------ 1 file changed, 6 deletions(-) (limited to 'src/libsync/owncloudpropagator.cpp') diff --git a/src/libsync/owncloudpropagator.cpp b/src/libsync/owncloudpropagator.cpp index f50201020..6f5063ea2 100644 --- a/src/libsync/owncloudpropagator.cpp +++ b/src/libsync/owncloudpropagator.cpp @@ -980,12 +980,6 @@ void PropagateDirectory::slotSubJobsFinished(SyncFileItem::Status status) if (_item->_instruction == CSYNC_INSTRUCTION_RENAME || _item->_instruction == CSYNC_INSTRUCTION_NEW || _item->_instruction == CSYNC_INSTRUCTION_UPDATE_METADATA) { - if (PropagateRemoteMkdir *mkdir = qobject_cast(_firstJob.data())) { - // special case from MKDIR, get the fileId from the job there - if (_item->_fileId.isEmpty() && !mkdir->_item->_fileId.isEmpty()) { - _item->_fileId = mkdir->_item->_fileId; - } - } if (!propagator()->updateMetadata(*_item)) { status = _item->_status = SyncFileItem::FatalError; _item->_errorString = tr("Error writing metadata to the database"); -- cgit v1.2.3