From c8ecbc30ed7942512685f4a8e648748c0df4a0f5 Mon Sep 17 00:00:00 2001 From: Christian Kamm Date: Wed, 15 Aug 2018 12:16:46 +0200 Subject: RemotePermissions: Fix empty vs null Fixes two bugs that appeared since the introduction of the struct: - when reading permissions from the journal, null ("") was read as empty-not-null - when reading permissinos from the server, empty ("") was read as null Addresses #4608 --- test/testsyncjournaldb.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'test/testsyncjournaldb.cpp') diff --git a/test/testsyncjournaldb.cpp b/test/testsyncjournaldb.cpp index 237b3b75a..6abf47761 100644 --- a/test/testsyncjournaldb.cpp +++ b/test/testsyncjournaldb.cpp @@ -57,7 +57,7 @@ private slots: record._type = ItemTypeDirectory; record._etag = "789789"; record._fileId = "abcd"; - record._remotePerm = RemotePermissions("RW"); + record._remotePerm = RemotePermissions::fromDbValue("RW"); record._fileSize = 213089055; record._checksumHeader = "MD5:mychecksum"; QVERIFY(_db.setFileRecord(record)); @@ -79,7 +79,7 @@ private slots: record._type = ItemTypeFile; record._etag = "789FFF"; record._fileId = "efg"; - record._remotePerm = RemotePermissions("NV"); + record._remotePerm = RemotePermissions::fromDbValue("NV"); record._fileSize = 289055; _db.setFileRecordMetadata(record); QVERIFY(_db.getFileRecord(QByteArrayLiteral("foo"), &storedRecord)); @@ -96,7 +96,7 @@ private slots: { SyncJournalFileRecord record; record._path = "foo-checksum"; - record._remotePerm = RemotePermissions("RW"); + record._remotePerm = RemotePermissions::fromDbValue(" "); record._checksumHeader = "MD5:mychecksum"; record._modtime = Utility::qDateTimeToTime_t(QDateTime::currentDateTimeUtc()); QVERIFY(_db.setFileRecord(record)); @@ -117,7 +117,7 @@ private slots: { SyncJournalFileRecord record; record._path = "foo-nochecksum"; - record._remotePerm = RemotePermissions("RWN"); + record._remotePerm = RemotePermissions(); record._modtime = Utility::qDateTimeToTime_t(QDateTime::currentDateTimeUtc()); QVERIFY(_db.setFileRecord(record)); -- cgit v1.2.3