diff options
author | Garvin Hicking <me@supergarv.de> | 2004-04-29 20:25:02 +0400 |
---|---|---|
committer | Garvin Hicking <me@supergarv.de> | 2004-04-29 20:25:02 +0400 |
commit | 6d2d9f64215f082664c7b094b39421a8f4265318 (patch) | |
tree | d1846911207e097a30854c45f8acbea7a8f2c17e | |
parent | f76918063e3a34769c1f1b925a58ff58e9f326f1 (diff) |
Bug #928328 - Use correct urlencoding() of the primary key reference.
-rwxr-xr-x | ChangeLog | 2 | ||||
-rw-r--r-- | browse_foreigners.php | 8 |
2 files changed, 6 insertions, 4 deletions
@@ -8,6 +8,8 @@ $Source$ 2004-04-29 Garvin Hicking <pma@supergarv.de> * db_details_structure.php: Bug #942362 - Colspan off by one * left.php: Modified js function to fit typecasting of Safari + * browse_foreigners.php: Bug #928328 - Use correct urlencoding() of + the primary key reference. 2004-04-29 Marc Delisle <lem9@users.sourceforge.net> * scripts/create-release.sh: keep only one previous version in cvs-prev diff --git a/browse_foreigners.php b/browse_foreigners.php index a69dd2f020..f8845aa8c3 100644 --- a/browse_foreigners.php +++ b/browse_foreigners.php @@ -43,8 +43,8 @@ PMA_setFontSizes(); <script type="text/javascript" language="javascript"> self.focus(); function formupdate(field, key) { - if (opener && opener.document && opener.document.insertForm && opener.document.insertForm.elements['field_' + field + '<?php echo (isset($pk) ? '[multi_edit][' . $pk . ']' : ''); ?>[]']) { - opener.document.insertForm.elements['field_' + field + '<?php echo (isset($pk) ? '[multi_edit][' . $pk . ']' : ''); ?>[]'].value = key; + if (opener && opener.document && opener.document.insertForm && opener.document.insertForm.elements['field_' + field + '<?php echo (isset($pk) ? '[multi_edit][' . urlencode($pk) . ']' : ''); ?>[]']) { + opener.document.insertForm.elements['field_' + field + '<?php echo (isset($pk) ? '[multi_edit][' . urlencode($pk) . ']' : ''); ?>[]'].value = key; self.close(); } else { alert('<?php echo PMA_jsFormat($strWindowNotFound); ?>'); @@ -80,9 +80,9 @@ require('./libraries/get_foreign.lib.php'); <input type="hidden" name="field" value="<?php echo urlencode($field); ?>" /> <?php if (isset($pk)) { - $pk_uri = '&pk=' . $pk; + $pk_uri = '&pk=' . urlencode($pk); ?> -<input type="hidden" name="pk" value="<?php echo $pk; ?>" /> +<input type="hidden" name="pk" value="<?php echo urlencode($pk); ?>" /> <?php } else { $pk_uri = '&'; |