Welcome to mirror list, hosted at ThFree Co, Russian Federation.

github.com/phpmyadmin/phpmyadmin.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMichal Čihař <mcihar@suse.cz>2012-04-26 17:38:34 +0400
committerMichal Čihař <mcihar@suse.cz>2012-04-26 17:38:34 +0400
commit35711845494c6b02d1549488a99ff4ef937cd5bd (patch)
treefb5e32094a2cade42898c4891422dbb371554cf0 /PMAStandard
parent76041ce9ca16ff9a5b3c7fe8e05b462a84912ae1 (diff)
Include PEAR commenting rules
Diffstat (limited to 'PMAStandard')
-rw-r--r--PMAStandard/Sniffs/Commenting/ClassCommentSniff.php233
-rw-r--r--PMAStandard/Sniffs/Commenting/FileCommentSniff.php791
-rw-r--r--PMAStandard/Sniffs/Commenting/FunctionCommentSniff.php490
-rw-r--r--PMAStandard/Sniffs/Commenting/InlineCommentSniff.php70
4 files changed, 1584 insertions, 0 deletions
diff --git a/PMAStandard/Sniffs/Commenting/ClassCommentSniff.php b/PMAStandard/Sniffs/Commenting/ClassCommentSniff.php
new file mode 100644
index 0000000000..0a6249b70e
--- /dev/null
+++ b/PMAStandard/Sniffs/Commenting/ClassCommentSniff.php
@@ -0,0 +1,233 @@
+<?php
+/**
+ * Parses and verifies the doc comments for classes.
+ *
+ * PHP version 5
+ *
+ * @category PHP
+ * @package PHP_CodeSniffer
+ * @author Greg Sherwood <gsherwood@squiz.net>
+ * @author Marc McIntyre <mmcintyre@squiz.net>
+ * @copyright 2006-2011 Squiz Pty Ltd (ABN 77 084 670 600)
+ * @license http://matrix.squiz.net/developer/tools/php_cs/licence BSD Licence
+ * @link http://pear.php.net/package/PHP_CodeSniffer
+ */
+
+if (class_exists('PHP_CodeSniffer_CommentParser_ClassCommentParser', true) === false) {
+ $error = 'Class PHP_CodeSniffer_CommentParser_ClassCommentParser not found';
+ throw new PHP_CodeSniffer_Exception($error);
+}
+
+if (class_exists('PEAR_Sniffs_Commenting_FileCommentSniff', true) === false) {
+ $error = 'Class PEAR_Sniffs_Commenting_FileCommentSniff not found';
+ throw new PHP_CodeSniffer_Exception($error);
+}
+
+/**
+ * Parses and verifies the doc comments for classes.
+ *
+ * Verifies that :
+ * <ul>
+ * <li>A doc comment exists.</li>
+ * <li>There is a blank newline after the short description.</li>
+ * <li>There is a blank newline between the long and short description.</li>
+ * <li>There is a blank newline between the long description and tags.</li>
+ * <li>Check the order of the tags.</li>
+ * <li>Check the indentation of each tag.</li>
+ * <li>Check required and optional tags and the format of their content.</li>
+ * </ul>
+ *
+ * @category PHP
+ * @package PHP_CodeSniffer
+ * @author Greg Sherwood <gsherwood@squiz.net>
+ * @author Marc McIntyre <mmcintyre@squiz.net>
+ * @copyright 2006-2011 Squiz Pty Ltd (ABN 77 084 670 600)
+ * @license http://matrix.squiz.net/developer/tools/php_cs/licence BSD Licence
+ * @version Release: 1.3.3
+ * @link http://pear.php.net/package/PHP_CodeSniffer
+ */
+class PEAR_Sniffs_Commenting_ClassCommentSniff extends PEAR_Sniffs_Commenting_FileCommentSniff
+{
+
+
+ /**
+ * Returns an array of tokens this test wants to listen for.
+ *
+ * @return array
+ */
+ public function register()
+ {
+ return array(
+ T_CLASS,
+ T_INTERFACE,
+ );
+
+ }//end register()
+
+
+ /**
+ * Processes this test, when one of its tokens is encountered.
+ *
+ * @param PHP_CodeSniffer_File $phpcsFile The file being scanned.
+ * @param int $stackPtr The position of the current token
+ * in the stack passed in $tokens.
+ *
+ * @return void
+ */
+ public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
+ {
+ $this->currentFile = $phpcsFile;
+
+ $tokens = $phpcsFile->getTokens();
+ $type = strtolower($tokens[$stackPtr]['content']);
+ $errorData = array($type);
+ $find = array(
+ T_ABSTRACT,
+ T_WHITESPACE,
+ T_FINAL,
+ );
+
+ // Extract the class comment docblock.
+ $commentEnd = $phpcsFile->findPrevious($find, ($stackPtr - 1), null, true);
+
+ if ($commentEnd !== false && $tokens[$commentEnd]['code'] === T_COMMENT) {
+ $error = 'You must use "/**" style comments for a %s comment';
+ $phpcsFile->addError($error, $stackPtr, 'WrongStyle', $errorData);
+ return;
+ } else if ($commentEnd === false
+ || $tokens[$commentEnd]['code'] !== T_DOC_COMMENT
+ ) {
+ $phpcsFile->addError('Missing %s doc comment', $stackPtr, 'Missing', $errorData);
+ return;
+ }
+
+ $commentStart = ($phpcsFile->findPrevious(T_DOC_COMMENT, ($commentEnd - 1), null, true) + 1);
+ $commentNext = $phpcsFile->findPrevious(T_WHITESPACE, ($commentEnd + 1), $stackPtr, false, $phpcsFile->eolChar);
+
+ // Distinguish file and class comment.
+ $prevClassToken = $phpcsFile->findPrevious(T_CLASS, ($stackPtr - 1));
+ if ($prevClassToken === false) {
+ // This is the first class token in this file, need extra checks.
+ $prevNonComment = $phpcsFile->findPrevious(T_DOC_COMMENT, ($commentStart - 1), null, true);
+ if ($prevNonComment !== false) {
+ $prevComment = $phpcsFile->findPrevious(T_DOC_COMMENT, ($prevNonComment - 1));
+ if ($prevComment === false) {
+ // There is only 1 doc comment between open tag and class token.
+ $newlineToken = $phpcsFile->findNext(T_WHITESPACE, ($commentEnd + 1), $stackPtr, false, $phpcsFile->eolChar);
+ if ($newlineToken !== false) {
+ $newlineToken = $phpcsFile->findNext(
+ T_WHITESPACE,
+ ($newlineToken + 1),
+ $stackPtr,
+ false,
+ $phpcsFile->eolChar
+ );
+
+ if ($newlineToken !== false) {
+ // Blank line between the class and the doc block.
+ // The doc block is most likely a file comment.
+ $error = 'Missing %s doc comment';
+ $phpcsFile->addError($error, ($stackPtr + 1), 'Missing', $errorData);
+ return;
+ }
+ }//end if
+ }//end if
+ }//end if
+ }//end if
+
+ $comment = $phpcsFile->getTokensAsString(
+ $commentStart,
+ ($commentEnd - $commentStart + 1)
+ );
+
+ // Parse the class comment.docblock.
+ try {
+ $this->commentParser = new PHP_CodeSniffer_CommentParser_ClassCommentParser($comment, $phpcsFile);
+ $this->commentParser->parse();
+ } catch (PHP_CodeSniffer_CommentParser_ParserException $e) {
+ $line = ($e->getLineWithinComment() + $commentStart);
+ $phpcsFile->addError($e->getMessage(), $line, 'FailedParse');
+ return;
+ }
+
+ $comment = $this->commentParser->getComment();
+ if (is_null($comment) === true) {
+ $error = 'Doc comment is empty for %s';
+ $phpcsFile->addError($error, $commentStart, 'Empty', $errorData);
+ return;
+ }
+
+ // No extra newline before short description.
+ $short = $comment->getShortComment();
+ $newlineCount = 0;
+ $newlineSpan = strspn($short, $phpcsFile->eolChar);
+ if ($short !== '' && $newlineSpan > 0) {
+ $error = 'Extra newline(s) found before %s comment short description';
+ $phpcsFile->addError($error, ($commentStart + 1), 'SpacingBeforeShort', $errorData);
+ }
+
+ $newlineCount = (substr_count($short, $phpcsFile->eolChar) + 1);
+
+ // Exactly one blank line between short and long description.
+ $long = $comment->getLongComment();
+ if (empty($long) === false) {
+ $between = $comment->getWhiteSpaceBetween();
+ $newlineBetween = substr_count($between, $phpcsFile->eolChar);
+ if ($newlineBetween !== 2) {
+ $error = 'There must be exactly one blank line between descriptions in %s comments';
+ $phpcsFile->addError($error, ($commentStart + $newlineCount + 1), 'SpacingAfterShort', $errorData);
+ }
+
+ $newlineCount += $newlineBetween;
+ }
+
+ // Exactly one blank line before tags.
+ $tags = $this->commentParser->getTagOrders();
+ if (count($tags) > 1) {
+ $newlineSpan = $comment->getNewlineAfter();
+ if ($newlineSpan !== 2) {
+ $error = 'There must be exactly one blank line before the tags in %s comments';
+ if ($long !== '') {
+ $newlineCount += (substr_count($long, $phpcsFile->eolChar) - $newlineSpan + 1);
+ }
+
+ $phpcsFile->addError($error, ($commentStart + $newlineCount), 'SpacingBeforeTags', $errorData);
+ $short = rtrim($short, $phpcsFile->eolChar.' ');
+ }
+ }
+
+ // Check each tag.
+ $this->processTags($commentStart, $commentEnd);
+
+ }//end process()
+
+
+ /**
+ * Process the version tag.
+ *
+ * @param int $errorPos The line number where the error occurs.
+ *
+ * @return void
+ */
+ protected function processVersion($errorPos)
+ {
+ $version = $this->commentParser->getVersion();
+ if ($version !== null) {
+ $content = $version->getContent();
+ $matches = array();
+ if (empty($content) === true) {
+ $error = 'Content missing for @version tag in doc comment';
+ $this->currentFile->addError($error, $errorPos, 'EmptyVersion');
+ } else if ((strstr($content, 'Release:') === false)) {
+ $error = 'Invalid version "%s" in doc comment; consider "Release: <package_version>" instead';
+ $data = array($content);
+ $this->currentFile->addWarning($error, $errorPos, 'InvalidVersion', $data);
+ }
+ }
+
+ }//end processVersion()
+
+
+}//end class
+
+?>
diff --git a/PMAStandard/Sniffs/Commenting/FileCommentSniff.php b/PMAStandard/Sniffs/Commenting/FileCommentSniff.php
new file mode 100644
index 0000000000..fbef7f3e60
--- /dev/null
+++ b/PMAStandard/Sniffs/Commenting/FileCommentSniff.php
@@ -0,0 +1,791 @@
+<?php
+/**
+ * Parses and verifies the doc comments for files.
+ *
+ * PHP version 5
+ *
+ * @category PHP
+ * @package PHP_CodeSniffer
+ * @author Greg Sherwood <gsherwood@squiz.net>
+ * @author Marc McIntyre <mmcintyre@squiz.net>
+ * @copyright 2006-2011 Squiz Pty Ltd (ABN 77 084 670 600)
+ * @license http://matrix.squiz.net/developer/tools/php_cs/licence BSD Licence
+ * @link http://pear.php.net/package/PHP_CodeSniffer
+ */
+
+if (class_exists('PHP_CodeSniffer_CommentParser_ClassCommentParser', true) === false) {
+ throw new PHP_CodeSniffer_Exception('Class PHP_CodeSniffer_CommentParser_ClassCommentParser not found');
+}
+
+/**
+ * Parses and verifies the doc comments for files.
+ *
+ * Verifies that :
+ * <ul>
+ * <li>A doc comment exists.</li>
+ * <li>There is a blank newline after the short description.</li>
+ * <li>There is a blank newline between the long and short description.</li>
+ * <li>There is a blank newline between the long description and tags.</li>
+ * <li>A PHP version is specified.</li>
+ * <li>Check the order of the tags.</li>
+ * <li>Check the indentation of each tag.</li>
+ * <li>Check required and optional tags and the format of their content.</li>
+ * </ul>
+ *
+ * @category PHP
+ * @package PHP_CodeSniffer
+ * @author Greg Sherwood <gsherwood@squiz.net>
+ * @author Marc McIntyre <mmcintyre@squiz.net>
+ * @copyright 2006-2011 Squiz Pty Ltd (ABN 77 084 670 600)
+ * @license http://matrix.squiz.net/developer/tools/php_cs/licence BSD Licence
+ * @version Release: 1.3.3
+ * @link http://pear.php.net/package/PHP_CodeSniffer
+ */
+
+class PEAR_Sniffs_Commenting_FileCommentSniff implements PHP_CodeSniffer_Sniff
+{
+
+ /**
+ * The header comment parser for the current file.
+ *
+ * @var PHP_CodeSniffer_Comment_Parser_ClassCommentParser
+ */
+ protected $commentParser = null;
+
+ /**
+ * The current PHP_CodeSniffer_File object we are processing.
+ *
+ * @var PHP_CodeSniffer_File
+ */
+ protected $currentFile = null;
+
+ /**
+ * Tags in correct order and related info.
+ *
+ * @var array
+ */
+ protected $tags = array(
+ 'category' => array(
+ 'required' => true,
+ 'allow_multiple' => false,
+ 'order_text' => 'precedes @package',
+ ),
+ 'package' => array(
+ 'required' => true,
+ 'allow_multiple' => false,
+ 'order_text' => 'follows @category',
+ ),
+ 'subpackage' => array(
+ 'required' => false,
+ 'allow_multiple' => false,
+ 'order_text' => 'follows @package',
+ ),
+ 'author' => array(
+ 'required' => true,
+ 'allow_multiple' => true,
+ 'order_text' => 'follows @subpackage (if used) or @package',
+ ),
+ 'copyright' => array(
+ 'required' => false,
+ 'allow_multiple' => true,
+ 'order_text' => 'follows @author',
+ ),
+ 'license' => array(
+ 'required' => true,
+ 'allow_multiple' => false,
+ 'order_text' => 'follows @copyright (if used) or @author',
+ ),
+ 'version' => array(
+ 'required' => false,
+ 'allow_multiple' => false,
+ 'order_text' => 'follows @license',
+ ),
+ 'link' => array(
+ 'required' => true,
+ 'allow_multiple' => true,
+ 'order_text' => 'follows @version',
+ ),
+ 'see' => array(
+ 'required' => false,
+ 'allow_multiple' => true,
+ 'order_text' => 'follows @link',
+ ),
+ 'since' => array(
+ 'required' => false,
+ 'allow_multiple' => false,
+ 'order_text' => 'follows @see (if used) or @link',
+ ),
+ 'deprecated' => array(
+ 'required' => false,
+ 'allow_multiple' => false,
+ 'order_text' => 'follows @since (if used) or @see (if used) or @link',
+ ),
+ );
+
+
+ /**
+ * Returns an array of tokens this test wants to listen for.
+ *
+ * @return array
+ */
+ public function register()
+ {
+ return array(T_OPEN_TAG);
+
+ }//end register()
+
+
+ /**
+ * Processes this test, when one of its tokens is encountered.
+ *
+ * @param PHP_CodeSniffer_File $phpcsFile The file being scanned.
+ * @param int $stackPtr The position of the current token
+ * in the stack passed in $tokens.
+ *
+ * @return void
+ */
+ public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
+ {
+ $this->currentFile = $phpcsFile;
+
+ // We are only interested if this is the first open tag.
+ if ($stackPtr !== 0) {
+ if ($phpcsFile->findPrevious(T_OPEN_TAG, ($stackPtr - 1)) !== false) {
+ return;
+ }
+ }
+
+ $tokens = $phpcsFile->getTokens();
+
+ // Find the next non whitespace token.
+ $commentStart
+ = $phpcsFile->findNext(T_WHITESPACE, ($stackPtr + 1), null, true);
+
+ // Allow declare() statements at the top of the file.
+ if ($tokens[$commentStart]['code'] === T_DECLARE) {
+ $semicolon = $phpcsFile->findNext(T_SEMICOLON, ($commentStart + 1));
+ $commentStart
+ = $phpcsFile->findNext(T_WHITESPACE, ($semicolon + 1), null, true);
+ }
+
+ // Ignore vim header.
+ if ($tokens[$commentStart]['code'] === T_COMMENT) {
+ if (strstr($tokens[$commentStart]['content'], 'vim:') !== false) {
+ $commentStart = $phpcsFile->findNext(
+ T_WHITESPACE,
+ ($commentStart + 1),
+ null,
+ true
+ );
+ }
+ }
+
+ $errorToken = ($stackPtr + 1);
+ if (isset($tokens[$errorToken]) === false) {
+ $errorToken--;
+ }
+
+ if ($tokens[$commentStart]['code'] === T_CLOSE_TAG) {
+ // We are only interested if this is the first open tag.
+ return;
+ } else if ($tokens[$commentStart]['code'] === T_COMMENT) {
+ $error = 'You must use "/**" style comments for a file comment';
+ $phpcsFile->addError($error, $errorToken, 'WrongStyle');
+ return;
+ } else if ($commentStart === false
+ || $tokens[$commentStart]['code'] !== T_DOC_COMMENT
+ ) {
+ $phpcsFile->addError('Missing file doc comment', $errorToken, 'Missing');
+ return;
+ } else {
+
+ // Extract the header comment docblock.
+ $commentEnd = $phpcsFile->findNext(
+ T_DOC_COMMENT,
+ ($commentStart + 1),
+ null,
+ true
+ );
+
+ $commentEnd--;
+
+ // Check if there is only 1 doc comment between the
+ // open tag and class token.
+ $nextToken = array(
+ T_ABSTRACT,
+ T_CLASS,
+ T_FUNCTION,
+ T_DOC_COMMENT,
+ );
+
+ $commentNext = $phpcsFile->findNext($nextToken, ($commentEnd + 1));
+ if ($commentNext !== false
+ && $tokens[$commentNext]['code'] !== T_DOC_COMMENT
+ ) {
+ // Found a class token right after comment doc block.
+ $newlineToken = $phpcsFile->findNext(
+ T_WHITESPACE,
+ ($commentEnd + 1),
+ $commentNext,
+ false,
+ $phpcsFile->eolChar
+ );
+
+ if ($newlineToken !== false) {
+ $newlineToken = $phpcsFile->findNext(
+ T_WHITESPACE,
+ ($newlineToken + 1),
+ $commentNext,
+ false,
+ $phpcsFile->eolChar
+ );
+
+ if ($newlineToken === false) {
+ // No blank line between the class token and the doc block.
+ // The doc block is most likely a class comment.
+ $error = 'Missing file doc comment';
+ $phpcsFile->addError($error, $errorToken, 'Missing');
+ return;
+ }
+ }
+ }//end if
+
+ $comment = $phpcsFile->getTokensAsString(
+ $commentStart,
+ ($commentEnd - $commentStart + 1)
+ );
+
+ // Parse the header comment docblock.
+ try {
+ $this->commentParser = new PHP_CodeSniffer_CommentParser_ClassCommentParser($comment, $phpcsFile);
+ $this->commentParser->parse();
+ } catch (PHP_CodeSniffer_CommentParser_ParserException $e) {
+ $line = ($e->getLineWithinComment() + $commentStart);
+ $phpcsFile->addError($e->getMessage(), $line, 'FailedParse');
+ return;
+ }
+
+ $comment = $this->commentParser->getComment();
+ if (is_null($comment) === true) {
+ $error = 'File doc comment is empty';
+ $phpcsFile->addError($error, $commentStart, 'Empty');
+ return;
+ }
+
+ // No extra newline before short description.
+ $short = $comment->getShortComment();
+ $newlineCount = 0;
+ $newlineSpan = strspn($short, $phpcsFile->eolChar);
+ if ($short !== '' && $newlineSpan > 0) {
+ $error = 'Extra newline(s) found before file comment short description';
+ $phpcsFile->addError($error, ($commentStart + 1), 'SpacingBefore');
+ }
+
+ $newlineCount = (substr_count($short, $phpcsFile->eolChar) + 1);
+
+ // Exactly one blank line between short and long description.
+ $long = $comment->getLongComment();
+ if (empty($long) === false) {
+ $between = $comment->getWhiteSpaceBetween();
+ $newlineBetween = substr_count($between, $phpcsFile->eolChar);
+ if ($newlineBetween !== 2) {
+ $error = 'There must be exactly one blank line between descriptions in file comment';
+ $phpcsFile->addError($error, ($commentStart + $newlineCount + 1), 'DescriptionSpacing');
+ }
+
+ $newlineCount += $newlineBetween;
+ }
+
+ // Exactly one blank line before tags.
+ $tags = $this->commentParser->getTagOrders();
+ if (count($tags) > 1) {
+ $newlineSpan = $comment->getNewlineAfter();
+ if ($newlineSpan !== 2) {
+ $error = 'There must be exactly one blank line before the tags in file comment';
+ if ($long !== '') {
+ $newlineCount += (substr_count($long, $phpcsFile->eolChar) - $newlineSpan + 1);
+ }
+
+ $phpcsFile->addError($error, ($commentStart + $newlineCount), 'SpacingBeforeTags');
+ $short = rtrim($short, $phpcsFile->eolChar.' ');
+ }
+ }
+
+ // Check the PHP Version.
+ $this->processPHPVersion($commentStart, $commentEnd, $long);
+
+ // Check each tag.
+ $this->processTags($commentStart, $commentEnd);
+ }//end if
+
+ }//end process()
+
+
+ /**
+ * Check that the PHP version is specified.
+ *
+ * @param int $commentStart Position in the stack where the comment started.
+ * @param int $commentEnd Position in the stack where the comment ended.
+ * @param string $commentText The text of the function comment.
+ *
+ * @return void
+ */
+ protected function processPHPVersion($commentStart, $commentEnd, $commentText)
+ {
+ if (strstr(strtolower($commentText), 'php version') === false) {
+ $error = 'PHP version not specified';
+ $this->currentFile->addWarning($error, $commentEnd, 'MissingVersion');
+ }
+
+ }//end processPHPVersion()
+
+
+ /**
+ * Processes each required or optional tag.
+ *
+ * @param int $commentStart Position in the stack where the comment started.
+ * @param int $commentEnd Position in the stack where the comment ended.
+ *
+ * @return void
+ */
+ protected function processTags($commentStart, $commentEnd)
+ {
+ $docBlock = (get_class($this) === 'PEAR_Sniffs_Commenting_FileCommentSniff') ? 'file' : 'class';
+ $foundTags = $this->commentParser->getTagOrders();
+ $orderIndex = 0;
+ $indentation = array();
+ $longestTag = 0;
+ $errorPos = 0;
+
+ foreach ($this->tags as $tag => $info) {
+
+ // Required tag missing.
+ if ($info['required'] === true && in_array($tag, $foundTags) === false) {
+ $error = 'Missing @%s tag in %s comment';
+ $data = array(
+ $tag,
+ $docBlock,
+ );
+ $this->currentFile->addError($error, $commentEnd, 'MissingTag', $data);
+ continue;
+ }
+
+ // Get the line number for current tag.
+ $tagName = ucfirst($tag);
+ if ($info['allow_multiple'] === true) {
+ $tagName .= 's';
+ }
+
+ $getMethod = 'get'.$tagName;
+ $tagElement = $this->commentParser->$getMethod();
+ if (is_null($tagElement) === true || empty($tagElement) === true) {
+ continue;
+ }
+
+ $errorPos = $commentStart;
+ if (is_array($tagElement) === false) {
+ $errorPos = ($commentStart + $tagElement->getLine());
+ }
+
+ // Get the tag order.
+ $foundIndexes = array_keys($foundTags, $tag);
+
+ if (count($foundIndexes) > 1) {
+ // Multiple occurance not allowed.
+ if ($info['allow_multiple'] === false) {
+ $error = 'Only 1 @%s tag is allowed in a %s comment';
+ $data = array(
+ $tag,
+ $docBlock,
+ );
+ $this->currentFile->addError($error, $errorPos, 'DuplicateTag', $data);
+ } else {
+ // Make sure same tags are grouped together.
+ $i = 0;
+ $count = $foundIndexes[0];
+ foreach ($foundIndexes as $index) {
+ if ($index !== $count) {
+ $errorPosIndex
+ = ($errorPos + $tagElement[$i]->getLine());
+ $error = '@%s tags must be grouped together';
+ $data = array($tag);
+ $this->currentFile->addError($error, $errorPosIndex, 'TagsNotGrouped', $data);
+ }
+
+ $i++;
+ $count++;
+ }
+ }
+ }//end if
+
+ // Check tag order.
+ if ($foundIndexes[0] > $orderIndex) {
+ $orderIndex = $foundIndexes[0];
+ } else {
+ if (is_array($tagElement) === true && empty($tagElement) === false) {
+ $errorPos += $tagElement[0]->getLine();
+ }
+
+ $error = 'The @%s tag is in the wrong order; the tag %s';
+ $data = array(
+ $tag,
+ $info['order_text'],
+ );
+ $this->currentFile->addError($error, $errorPos, 'WrongTagOrder', $data);
+ }
+
+ // Store the indentation for checking.
+ $len = strlen($tag);
+ if ($len > $longestTag) {
+ $longestTag = $len;
+ }
+
+ if (is_array($tagElement) === true) {
+ foreach ($tagElement as $key => $element) {
+ $indentation[] = array(
+ 'tag' => $tag,
+ 'space' => $this->getIndentation($tag, $element),
+ 'line' => $element->getLine(),
+ );
+ }
+ } else {
+ $indentation[] = array(
+ 'tag' => $tag,
+ 'space' => $this->getIndentation($tag, $tagElement),
+ );
+ }
+
+ $method = 'process'.$tagName;
+ if (method_exists($this, $method) === true) {
+ // Process each tag if a method is defined.
+ call_user_func(array($this, $method), $errorPos);
+ } else {
+ if (is_array($tagElement) === true) {
+ foreach ($tagElement as $key => $element) {
+ $element->process(
+ $this->currentFile,
+ $commentStart,
+ $docBlock
+ );
+ }
+ } else {
+ $tagElement->process(
+ $this->currentFile,
+ $commentStart,
+ $docBlock
+ );
+ }
+ }
+ }//end foreach
+
+ foreach ($indentation as $indentInfo) {
+ if ($indentInfo['space'] !== 0
+ && $indentInfo['space'] !== ($longestTag + 1)
+ ) {
+ $expected = (($longestTag - strlen($indentInfo['tag'])) + 1);
+ $space = ($indentInfo['space'] - strlen($indentInfo['tag']));
+ $error = '@%s tag comment indented incorrectly; expected %s spaces but found %s';
+ $data = array(
+ $indentInfo['tag'],
+ $expected,
+ $space,
+ );
+
+ $getTagMethod = 'get'.ucfirst($indentInfo['tag']);
+
+ if ($this->tags[$indentInfo['tag']]['allow_multiple'] === true) {
+ $line = $indentInfo['line'];
+ } else {
+ $tagElem = $this->commentParser->$getTagMethod();
+ $line = $tagElem->getLine();
+ }
+
+ $this->currentFile->addError($error, ($commentStart + $line), 'TagIndent', $data);
+ }
+ }
+
+ }//end processTags()
+
+
+ /**
+ * Get the indentation information of each tag.
+ *
+ * @param string $tagName The name of the
+ * doc comment
+ * element.
+ * @param PHP_CodeSniffer_CommentParser_DocElement $tagElement The doc comment
+ * element.
+ *
+ * @return void
+ */
+ protected function getIndentation($tagName, $tagElement)
+ {
+ if ($tagElement instanceof PHP_CodeSniffer_CommentParser_SingleElement) {
+ if ($tagElement->getContent() !== '') {
+ return (strlen($tagName) + substr_count($tagElement->getWhitespaceBeforeContent(), ' '));
+ }
+ } else if ($tagElement instanceof PHP_CodeSniffer_CommentParser_PairElement) {
+ if ($tagElement->getValue() !== '') {
+ return (strlen($tagName) + substr_count($tagElement->getWhitespaceBeforeValue(), ' '));
+ }
+ }
+
+ return 0;
+
+ }//end getIndentation()
+
+
+ /**
+ * Process the category tag.
+ *
+ * @param int $errorPos The line number where the error occurs.
+ *
+ * @return void
+ */
+ protected function processCategory($errorPos)
+ {
+ $category = $this->commentParser->getCategory();
+ if ($category !== null) {
+ $content = $category->getContent();
+ if ($content !== '') {
+ if (PHP_CodeSniffer::isUnderscoreName($content) !== true) {
+ $newContent = str_replace(' ', '_', $content);
+ $nameBits = explode('_', $newContent);
+ $firstBit = array_shift($nameBits);
+ $newName = ucfirst($firstBit).'_';
+ foreach ($nameBits as $bit) {
+ $newName .= ucfirst($bit).'_';
+ }
+
+ $error = 'Category name "%s" is not valid; consider "%s" instead';
+ $validName = trim($newName, '_');
+ $data = array(
+ $content,
+ $validName,
+ );
+ $this->currentFile->addError($error, $errorPos, 'InvalidCategory', $data);
+ }
+ } else {
+ $error = '@category tag must contain a name';
+ $this->currentFile->addError($error, $errorPos, 'EmptyCategory');
+ }
+ }
+
+ }//end processCategory()
+
+
+ /**
+ * Process the package tag.
+ *
+ * @param int $errorPos The line number where the error occurs.
+ *
+ * @return void
+ */
+ protected function processPackage($errorPos)
+ {
+ $package = $this->commentParser->getPackage();
+ if ($package !== null) {
+ $content = $package->getContent();
+ if ($content !== '') {
+ if (PHP_CodeSniffer::isUnderscoreName($content) !== true) {
+ $newContent = str_replace(' ', '_', $content);
+ $nameBits = explode('_', $newContent);
+ $firstBit = array_shift($nameBits);
+ $newName = strtoupper($firstBit{0}).substr($firstBit, 1).'_';
+ foreach ($nameBits as $bit) {
+ $newName .= strtoupper($bit{0}).substr($bit, 1).'_';
+ }
+
+ $error = 'Package name "%s" is not valid; consider "%s" instead';
+ $validName = trim($newName, '_');
+ $data = array(
+ $content,
+ $validName,
+ );
+ $this->currentFile->addError($error, $errorPos, 'InvalidPackage', $data);
+ }
+ } else {
+ $error = '@package tag must contain a name';
+ $this->currentFile->addError($error, $errorPos, 'EmptyPackage');
+ }
+ }
+
+ }//end processPackage()
+
+
+ /**
+ * Process the subpackage tag.
+ *
+ * @param int $errorPos The line number where the error occurs.
+ *
+ * @return void
+ */
+ protected function processSubpackage($errorPos)
+ {
+ $package = $this->commentParser->getSubpackage();
+ if ($package !== null) {
+ $content = $package->getContent();
+ if ($content !== '') {
+ if (PHP_CodeSniffer::isUnderscoreName($content) !== true) {
+ $newContent = str_replace(' ', '_', $content);
+ $nameBits = explode('_', $newContent);
+ $firstBit = array_shift($nameBits);
+ $newName = strtoupper($firstBit{0}).substr($firstBit, 1).'_';
+ foreach ($nameBits as $bit) {
+ $newName .= strtoupper($bit{0}).substr($bit, 1).'_';
+ }
+
+ $error = 'Subpackage name "%s" is not valid; consider "%s" instead';
+ $validName = trim($newName, '_');
+ $data = array(
+ $content,
+ $validName,
+ );
+ $this->currentFile->addError($error, $errorPos, 'InvalidSubpackage', $data);
+ }
+ } else {
+ $error = '@subpackage tag must contain a name';
+ $this->currentFile->addError($error, $errorPos, 'EmptySubpackage');
+ }
+ }
+
+ }//end processSubpackage()
+
+
+ /**
+ * Process the author tag(s) that this header comment has.
+ *
+ * This function is different from other _process functions
+ * as $authors is an array of SingleElements, so we work out
+ * the errorPos for each element separately
+ *
+ * @param int $commentStart The position in the stack where
+ * the comment started.
+ *
+ * @return void
+ */
+ protected function processAuthors($commentStart)
+ {
+ $authors = $this->commentParser->getAuthors();
+ // Report missing return.
+ if (empty($authors) === false) {
+ foreach ($authors as $author) {
+ $errorPos = ($commentStart + $author->getLine());
+ $content = $author->getContent();
+ if ($content !== '') {
+ $local = '\da-zA-Z-_+';
+ // Dot character cannot be the first or last character
+ // in the local-part.
+ $localMiddle = $local.'.\w';
+ if (preg_match('/^([^<]*)\s+<(['.$local.']['.$localMiddle.']*['.$local.']@[\da-zA-Z][-.\w]*[\da-zA-Z]\.[a-zA-Z]{2,7})>$/', $content) === 0) {
+ $error = 'Content of the @author tag must be in the form "Display Name <username@example.com>"';
+ $this->currentFile->addError($error, $errorPos, 'InvalidAuthors');
+ }
+ } else {
+ $error = 'Content missing for @author tag in %s comment';
+ $docBlock = (get_class($this) === 'PEAR_Sniffs_Commenting_FileCommentSniff') ? 'file' : 'class';
+ $data = array($docBlock);
+ $this->currentFile->addError($error, $errorPos, 'EmptyAuthors', $data);
+ }
+ }
+ }
+
+ }//end processAuthors()
+
+
+ /**
+ * Process the copyright tags.
+ *
+ * @param int $commentStart The position in the stack where
+ * the comment started.
+ *
+ * @return void
+ */
+ protected function processCopyrights($commentStart)
+ {
+ $copyrights = $this->commentParser->getCopyrights();
+ foreach ($copyrights as $copyright) {
+ $errorPos = ($commentStart + $copyright->getLine());
+ $content = $copyright->getContent();
+ if ($content !== '') {
+ $matches = array();
+ if (preg_match('/^([0-9]{4})((.{1})([0-9]{4}))? (.+)$/', $content, $matches) !== 0) {
+ // Check earliest-latest year order.
+ if ($matches[3] !== '') {
+ if ($matches[3] !== '-') {
+ $error = 'A hyphen must be used between the earliest and latest year';
+ $this->currentFile->addError($error, $errorPos, 'CopyrightHyphen');
+ }
+
+ if ($matches[4] !== '' && $matches[4] < $matches[1]) {
+ $error = "Invalid year span \"$matches[1]$matches[3]$matches[4]\" found; consider \"$matches[4]-$matches[1]\" instead";
+ $this->currentFile->addWarning($error, $errorPos, 'InvalidCopyright');
+ }
+ }
+ } else {
+ $error = '@copyright tag must contain a year and the name of the copyright holder';
+ $this->currentFile->addError($error, $errorPos, 'EmptyCopyright');
+ }
+ } else {
+ $error = '@copyright tag must contain a year and the name of the copyright holder';
+ $this->currentFile->addError($error, $errorPos, 'EmptyCopyright');
+ }//end if
+ }//end if
+
+ }//end processCopyrights()
+
+
+ /**
+ * Process the license tag.
+ *
+ * @param int $errorPos The line number where the error occurs.
+ *
+ * @return void
+ */
+ protected function processLicense($errorPos)
+ {
+ $license = $this->commentParser->getLicense();
+ if ($license !== null) {
+ $value = $license->getValue();
+ $comment = $license->getComment();
+ if ($value === '' || $comment === '') {
+ $error = '@license tag must contain a URL and a license name';
+ $this->currentFile->addError($error, $errorPos, 'EmptyLicense');
+ }
+ }
+
+ }//end processLicense()
+
+
+ /**
+ * Process the version tag.
+ *
+ * @param int $errorPos The line number where the error occurs.
+ *
+ * @return void
+ */
+ protected function processVersion($errorPos)
+ {
+ $version = $this->commentParser->getVersion();
+ if ($version !== null) {
+ $content = $version->getContent();
+ $matches = array();
+ if (empty($content) === true) {
+ $error = 'Content missing for @version tag in file comment';
+ $this->currentFile->addError($error, $errorPos, 'EmptyVersion');
+ } else if (strstr($content, 'CVS:') === false
+ && strstr($content, 'SVN:') === false
+ && strstr($content, 'GIT:') === false
+ ) {
+ $error = 'Invalid version "%s" in file comment; consider "CVS: <cvs_id>" or "SVN: <svn_id>" or "GIT: <git_id>" instead';
+ $data = array($content);
+ $this->currentFile->addWarning($error, $errorPos, 'InvalidVersion', $data);
+ }
+ }
+
+ }//end processVersion()
+
+
+}//end class
+
+?>
diff --git a/PMAStandard/Sniffs/Commenting/FunctionCommentSniff.php b/PMAStandard/Sniffs/Commenting/FunctionCommentSniff.php
new file mode 100644
index 0000000000..081c05d32b
--- /dev/null
+++ b/PMAStandard/Sniffs/Commenting/FunctionCommentSniff.php
@@ -0,0 +1,490 @@
+<?php
+/**
+ * Parses and verifies the doc comments for functions.
+ *
+ * PHP version 5
+ *
+ * @category PHP
+ * @package PHP_CodeSniffer
+ * @author Greg Sherwood <gsherwood@squiz.net>
+ * @author Marc McIntyre <mmcintyre@squiz.net>
+ * @copyright 2006-2011 Squiz Pty Ltd (ABN 77 084 670 600)
+ * @license http://matrix.squiz.net/developer/tools/php_cs/licence BSD Licence
+ * @link http://pear.php.net/package/PHP_CodeSniffer
+ */
+
+if (class_exists('PHP_CodeSniffer_CommentParser_FunctionCommentParser', true) === false) {
+ throw new PHP_CodeSniffer_Exception('Class PHP_CodeSniffer_CommentParser_FunctionCommentParser not found');
+}
+
+/**
+ * Parses and verifies the doc comments for functions.
+ *
+ * Verifies that :
+ * <ul>
+ * <li>A comment exists</li>
+ * <li>There is a blank newline after the short description.</li>
+ * <li>There is a blank newline between the long and short description.</li>
+ * <li>There is a blank newline between the long description and tags.</li>
+ * <li>Parameter names represent those in the method.</li>
+ * <li>Parameter comments are in the correct order</li>
+ * <li>Parameter comments are complete</li>
+ * <li>A space is present before the first and after the last parameter</li>
+ * <li>A return type exists</li>
+ * <li>There must be one blank line between body and headline comments.</li>
+ * <li>Any throw tag must have an exception class.</li>
+ * </ul>
+ *
+ * @category PHP
+ * @package PHP_CodeSniffer
+ * @author Greg Sherwood <gsherwood@squiz.net>
+ * @author Marc McIntyre <mmcintyre@squiz.net>
+ * @copyright 2006-2011 Squiz Pty Ltd (ABN 77 084 670 600)
+ * @license http://matrix.squiz.net/developer/tools/php_cs/licence BSD Licence
+ * @version Release: 1.3.3
+ * @link http://pear.php.net/package/PHP_CodeSniffer
+ */
+class PEAR_Sniffs_Commenting_FunctionCommentSniff implements PHP_CodeSniffer_Sniff
+{
+
+ /**
+ * The name of the method that we are currently processing.
+ *
+ * @var string
+ */
+ private $_methodName = '';
+
+ /**
+ * The position in the stack where the fucntion token was found.
+ *
+ * @var int
+ */
+ private $_functionToken = null;
+
+ /**
+ * The position in the stack where the class token was found.
+ *
+ * @var int
+ */
+ private $_classToken = null;
+
+ /**
+ * The function comment parser for the current method.
+ *
+ * @var PHP_CodeSniffer_Comment_Parser_FunctionCommentParser
+ */
+ protected $commentParser = null;
+
+ /**
+ * The current PHP_CodeSniffer_File object we are processing.
+ *
+ * @var PHP_CodeSniffer_File
+ */
+ protected $currentFile = null;
+
+
+ /**
+ * Returns an array of tokens this test wants to listen for.
+ *
+ * @return array
+ */
+ public function register()
+ {
+ return array(T_FUNCTION);
+
+ }//end register()
+
+
+ /**
+ * Processes this test, when one of its tokens is encountered.
+ *
+ * @param PHP_CodeSniffer_File $phpcsFile The file being scanned.
+ * @param int $stackPtr The position of the current token
+ * in the stack passed in $tokens.
+ *
+ * @return void
+ */
+ public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
+ {
+ $find = array(
+ T_COMMENT,
+ T_DOC_COMMENT,
+ T_CLASS,
+ T_FUNCTION,
+ T_OPEN_TAG,
+ );
+
+ $commentEnd = $phpcsFile->findPrevious($find, ($stackPtr - 1));
+
+ if ($commentEnd === false) {
+ return;
+ }
+
+ $this->currentFile = $phpcsFile;
+ $tokens = $phpcsFile->getTokens();
+
+ // If the token that we found was a class or a function, then this
+ // function has no doc comment.
+ $code = $tokens[$commentEnd]['code'];
+
+ if ($code === T_COMMENT) {
+ $error = 'You must use "/**" style comments for a function comment';
+ $phpcsFile->addError($error, $stackPtr, 'WrongStyle');
+ return;
+ } else if ($code !== T_DOC_COMMENT) {
+ $phpcsFile->addError('Missing function doc comment', $stackPtr, 'Missing');
+ return;
+ }
+
+ // If there is any code between the function keyword and the doc block
+ // then the doc block is not for us.
+ $ignore = PHP_CodeSniffer_Tokens::$scopeModifiers;
+ $ignore[] = T_STATIC;
+ $ignore[] = T_WHITESPACE;
+ $ignore[] = T_ABSTRACT;
+ $ignore[] = T_FINAL;
+ $prevToken = $phpcsFile->findPrevious($ignore, ($stackPtr - 1), null, true);
+ if ($prevToken !== $commentEnd) {
+ $phpcsFile->addError('Missing function doc comment', $stackPtr, 'Missing');
+ return;
+ }
+
+ $this->_functionToken = $stackPtr;
+
+ $this->_classToken = null;
+ foreach ($tokens[$stackPtr]['conditions'] as $condPtr => $condition) {
+ if ($condition === T_CLASS || $condition === T_INTERFACE) {
+ $this->_classToken = $condPtr;
+ break;
+ }
+ }
+
+ // If the first T_OPEN_TAG is right before the comment, it is probably
+ // a file comment.
+ $commentStart = ($phpcsFile->findPrevious(T_DOC_COMMENT, ($commentEnd - 1), null, true) + 1);
+ $prevToken = $phpcsFile->findPrevious(T_WHITESPACE, ($commentStart - 1), null, true);
+ if ($tokens[$prevToken]['code'] === T_OPEN_TAG) {
+ // Is this the first open tag?
+ if ($stackPtr === 0 || $phpcsFile->findPrevious(T_OPEN_TAG, ($prevToken - 1)) === false) {
+ $phpcsFile->addError('Missing function doc comment', $stackPtr, 'Missing');
+ return;
+ }
+ }
+
+ $comment = $phpcsFile->getTokensAsString($commentStart, ($commentEnd - $commentStart + 1));
+ $this->_methodName = $phpcsFile->getDeclarationName($stackPtr);
+
+ try {
+ $this->commentParser = new PHP_CodeSniffer_CommentParser_FunctionCommentParser($comment, $phpcsFile);
+ $this->commentParser->parse();
+ } catch (PHP_CodeSniffer_CommentParser_ParserException $e) {
+ $line = ($e->getLineWithinComment() + $commentStart);
+ $phpcsFile->addError($e->getMessage(), $line, 'FailedParse');
+ return;
+ }
+
+ $comment = $this->commentParser->getComment();
+ if (is_null($comment) === true) {
+ $error = 'Function doc comment is empty';
+ $phpcsFile->addError($error, $commentStart, 'Empty');
+ return;
+ }
+
+ $this->processParams($commentStart);
+ $this->processReturn($commentStart, $commentEnd);
+ $this->processThrows($commentStart);
+
+ // No extra newline before short description.
+ $short = $comment->getShortComment();
+ $newlineCount = 0;
+ $newlineSpan = strspn($short, $phpcsFile->eolChar);
+ if ($short !== '' && $newlineSpan > 0) {
+ $error = 'Extra newline(s) found before function comment short description';
+ $phpcsFile->addError($error, ($commentStart + 1), 'SpacingBeforeShort');
+ }
+
+ $newlineCount = (substr_count($short, $phpcsFile->eolChar) + 1);
+
+ // Exactly one blank line between short and long description.
+ $long = $comment->getLongComment();
+ if (empty($long) === false) {
+ $between = $comment->getWhiteSpaceBetween();
+ $newlineBetween = substr_count($between, $phpcsFile->eolChar);
+ if ($newlineBetween !== 2) {
+ $error = 'There must be exactly one blank line between descriptions in function comment';
+ $phpcsFile->addError($error, ($commentStart + $newlineCount + 1), 'SpacingAfterShort');
+ }
+
+ $newlineCount += $newlineBetween;
+ }
+
+ // Exactly one blank line before tags.
+ $params = $this->commentParser->getTagOrders();
+ if (count($params) > 1) {
+ $newlineSpan = $comment->getNewlineAfter();
+ if ($newlineSpan !== 2) {
+ $error = 'There must be exactly one blank line before the tags in function comment';
+ if ($long !== '') {
+ $newlineCount += (substr_count($long, $phpcsFile->eolChar) - $newlineSpan + 1);
+ }
+
+ $phpcsFile->addError($error, ($commentStart + $newlineCount), 'SpacingBeforeTags');
+ $short = rtrim($short, $phpcsFile->eolChar.' ');
+ }
+ }
+
+ }//end process()
+
+
+ /**
+ * Process any throw tags that this function comment has.
+ *
+ * @param int $commentStart The position in the stack where the
+ * comment started.
+ *
+ * @return void
+ */
+ protected function processThrows($commentStart)
+ {
+ if (count($this->commentParser->getThrows()) === 0) {
+ return;
+ }
+
+ foreach ($this->commentParser->getThrows() as $throw) {
+
+ $exception = $throw->getValue();
+ $errorPos = ($commentStart + $throw->getLine());
+
+ if ($exception === '') {
+ $error = '@throws tag must contain the exception class name';
+ $this->currentFile->addError($error, $errorPos, 'EmptyThrows');
+ }
+ }
+
+ }//end processThrows()
+
+
+ /**
+ * Process the return comment of this function comment.
+ *
+ * @param int $commentStart The position in the stack where the comment started.
+ * @param int $commentEnd The position in the stack where the comment ended.
+ *
+ * @return void
+ */
+ protected function processReturn($commentStart, $commentEnd)
+ {
+ // Skip constructor and destructor.
+ $className = '';
+ if ($this->_classToken !== null) {
+ $className = $this->currentFile->getDeclarationName($this->_classToken);
+ $className = strtolower(ltrim($className, '_'));
+ }
+
+ $methodName = strtolower(ltrim($this->_methodName, '_'));
+ $isSpecialMethod = ($this->_methodName === '__construct' || $this->_methodName === '__destruct');
+
+ if ($isSpecialMethod === false && $methodName !== $className) {
+ // Report missing return tag.
+ if ($this->commentParser->getReturn() === null) {
+ $error = 'Missing @return tag in function comment';
+ $this->currentFile->addError($error, $commentEnd, 'MissingReturn');
+ } else if (trim($this->commentParser->getReturn()->getRawContent()) === '') {
+ $error = '@return tag is empty in function comment';
+ $errorPos = ($commentStart + $this->commentParser->getReturn()->getLine());
+ $this->currentFile->addError($error, $errorPos, 'EmptyReturn');
+ }
+ }
+
+ }//end processReturn()
+
+
+ /**
+ * Process the function parameter comments.
+ *
+ * @param int $commentStart The position in the stack where
+ * the comment started.
+ *
+ * @return void
+ */
+ protected function processParams($commentStart)
+ {
+ $realParams = $this->currentFile->getMethodParameters($this->_functionToken);
+
+ $params = $this->commentParser->getParams();
+ $foundParams = array();
+
+ if (empty($params) === false) {
+
+ $lastParm = (count($params) - 1);
+ if (substr_count($params[$lastParm]->getWhitespaceAfter(), $this->currentFile->eolChar) !== 2) {
+ $error = 'Last parameter comment requires a blank newline after it';
+ $errorPos = ($params[$lastParm]->getLine() + $commentStart);
+ $this->currentFile->addError($error, $errorPos, 'SpacingAfterParams');
+ }
+
+ // Parameters must appear immediately after the comment.
+ if ($params[0]->getOrder() !== 2) {
+ $error = 'Parameters must appear immediately after the comment';
+ $errorPos = ($params[0]->getLine() + $commentStart);
+ $this->currentFile->addError($error, $errorPos, 'SpacingBeforeParams');
+ }
+
+ $previousParam = null;
+ $spaceBeforeVar = 10000;
+ $spaceBeforeComment = 10000;
+ $longestType = 0;
+ $longestVar = 0;
+
+ foreach ($params as $param) {
+
+ $paramComment = trim($param->getComment());
+ $errorPos = ($param->getLine() + $commentStart);
+
+ // Make sure that there is only one space before the var type.
+ if ($param->getWhitespaceBeforeType() !== ' ') {
+ $error = 'Expected 1 space before variable type';
+ $this->currentFile->addError($error, $errorPos, 'SpacingBeforeParamType');
+ }
+
+ $spaceCount = substr_count($param->getWhitespaceBeforeVarName(), ' ');
+ if ($spaceCount < $spaceBeforeVar) {
+ $spaceBeforeVar = $spaceCount;
+ $longestType = $errorPos;
+ }
+
+ $spaceCount = substr_count($param->getWhitespaceBeforeComment(), ' ');
+
+ if ($spaceCount < $spaceBeforeComment && $paramComment !== '') {
+ $spaceBeforeComment = $spaceCount;
+ $longestVar = $errorPos;
+ }
+
+ // Make sure they are in the correct order,
+ // and have the correct name.
+ $pos = $param->getPosition();
+
+ $paramName = ($param->getVarName() !== '') ? $param->getVarName() : '[ UNKNOWN ]';
+
+ if ($previousParam !== null) {
+ $previousName = ($previousParam->getVarName() !== '') ? $previousParam->getVarName() : 'UNKNOWN';
+
+ // Check to see if the parameters align properly.
+ if ($param->alignsVariableWith($previousParam) === false) {
+ $error = 'The variable names for parameters %s (%s) and %s (%s) do not align';
+ $data = array(
+ $previousName,
+ ($pos - 1),
+ $paramName,
+ $pos,
+ );
+ $this->currentFile->addError($error, $errorPos, 'ParameterNamesNotAligned', $data);
+ }
+
+ if ($param->alignsCommentWith($previousParam) === false) {
+ $error = 'The comments for parameters %s (%s) and %s (%s) do not align';
+ $data = array(
+ $previousName,
+ ($pos - 1),
+ $paramName,
+ $pos,
+ );
+ $this->currentFile->addError($error, $errorPos, 'ParameterCommentsNotAligned', $data);
+ }
+ }//end if
+
+ // Make sure the names of the parameter comment matches the
+ // actual parameter.
+ if (isset($realParams[($pos - 1)]) === true) {
+ $realName = $realParams[($pos - 1)]['name'];
+ $foundParams[] = $realName;
+
+ // Append ampersand to name if passing by reference.
+ if ($realParams[($pos - 1)]['pass_by_reference'] === true) {
+ $realName = '&'.$realName;
+ }
+
+ if ($realName !== $paramName) {
+ $code = 'ParamNameNoMatch';
+ $data = array(
+ $paramName,
+ $realName,
+ $pos,
+ );
+
+ $error = 'Doc comment for var %s does not match ';
+ if (strtolower($paramName) === strtolower($realName)) {
+ $error .= 'case of ';
+ $code = 'ParamNameNoCaseMatch';
+ }
+
+ $error .= 'actual variable name %s at position %s';
+
+ $this->currentFile->addError($error, $errorPos, $code, $data);
+ }
+ } else {
+ // We must have an extra parameter comment.
+ $error = 'Superfluous doc comment at position '.$pos;
+ $this->currentFile->addError($error, $errorPos, 'ExtraParamComment');
+ }
+
+ if ($param->getVarName() === '') {
+ $error = 'Missing parameter name at position '.$pos;
+ $this->currentFile->addError($error, $errorPos, 'MissingParamName');
+ }
+
+ if ($param->getType() === '') {
+ $error = 'Missing type at position '.$pos;
+ $this->currentFile->addError($error, $errorPos, 'MissingParamType');
+ }
+
+ if ($paramComment === '') {
+ $error = 'Missing comment for param "%s" at position %s';
+ $data = array(
+ $paramName,
+ $pos,
+ );
+ $this->currentFile->addError($error, $errorPos, 'MissingParamComment', $data);
+ }
+
+ $previousParam = $param;
+
+ }//end foreach
+
+ if ($spaceBeforeVar !== 1 && $spaceBeforeVar !== 10000 && $spaceBeforeComment !== 10000) {
+ $error = 'Expected 1 space after the longest type';
+ $this->currentFile->addError($error, $longestType, 'SpacingAfterLongType');
+ }
+
+ if ($spaceBeforeComment !== 1 && $spaceBeforeComment !== 10000) {
+ $error = 'Expected 1 space after the longest variable name';
+ $this->currentFile->addError($error, $longestVar, 'SpacingAfterLongName');
+ }
+
+ }//end if
+
+ $realNames = array();
+ foreach ($realParams as $realParam) {
+ $realNames[] = $realParam['name'];
+ }
+
+ // Report and missing comments.
+ $diff = array_diff($realNames, $foundParams);
+ foreach ($diff as $neededParam) {
+ if (count($params) !== 0) {
+ $errorPos = ($params[(count($params) - 1)]->getLine() + $commentStart);
+ } else {
+ $errorPos = $commentStart;
+ }
+
+ $error = 'Doc comment for "%s" missing';
+ $data = array($neededParam);
+ $this->currentFile->addError($error, $errorPos, 'MissingParamTag', $data);
+ }
+
+ }//end processParams()
+
+
+}//end class
+
+?>
diff --git a/PMAStandard/Sniffs/Commenting/InlineCommentSniff.php b/PMAStandard/Sniffs/Commenting/InlineCommentSniff.php
new file mode 100644
index 0000000000..3499be80d2
--- /dev/null
+++ b/PMAStandard/Sniffs/Commenting/InlineCommentSniff.php
@@ -0,0 +1,70 @@
+<?php
+/**
+ * PHP_CodeSniffer_Sniffs_PEAR_Commenting_InlineCommentSniff.
+ *
+ * PHP version 5
+ *
+ * @category PHP
+ * @package PHP_CodeSniffer
+ * @author Greg Sherwood <gsherwood@squiz.net>
+ * @author Marc McIntyre <mmcintyre@squiz.net>
+ * @copyright 2006-2011 Squiz Pty Ltd (ABN 77 084 670 600)
+ * @license http://matrix.squiz.net/developer/tools/php_cs/licence BSD Licence
+ * @link http://pear.php.net/package/PHP_CodeSniffer
+ */
+
+/**
+ * PHP_CodeSniffer_Sniffs_PEAR_Commenting_InlineCommentSniff.
+ *
+ * Checks that no perl-style comments are used.
+ *
+ * @category PHP
+ * @package PHP_CodeSniffer
+ * @author Greg Sherwood <gsherwood@squiz.net>
+ * @author Marc McIntyre <mmcintyre@squiz.net>
+ * @copyright 2006-2011 Squiz Pty Ltd (ABN 77 084 670 600)
+ * @license http://matrix.squiz.net/developer/tools/php_cs/licence BSD Licence
+ * @version Release: 1.3.3
+ * @link http://pear.php.net/package/PHP_CodeSniffer
+ */
+class PEAR_Sniffs_Commenting_InlineCommentSniff implements PHP_CodeSniffer_Sniff
+{
+
+
+ /**
+ * Returns an array of tokens this test wants to listen for.
+ *
+ * @return array
+ */
+ public function register()
+ {
+ return array(T_COMMENT);
+
+ }//end register()
+
+
+ /**
+ * Processes this test, when one of its tokens is encountered.
+ *
+ * @param PHP_CodeSniffer_File $phpcsFile The file being scanned.
+ * @param int $stackPtr The position of the current token
+ * in the stack passed in $tokens.
+ *
+ * @return void
+ */
+ public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
+ {
+ $tokens = $phpcsFile->getTokens();
+
+ if ($tokens[$stackPtr]['content']{0} === '#') {
+ $error = 'Perl-style comments are not allowed. Use "// Comment."';
+ $error .= ' or "/* comment */" instead.';
+ $phpcsFile->addError($error, $stackPtr, 'WrongStyle');
+ }
+
+ }//end process()
+
+
+}//end class
+
+?>