Fix bug #3799 [interface] Incorrect select field change on ctrl key navigation in Firefox

1 files changed, 19 insertions, 7 deletions

diff --git a/js/keyhandler.js b/js/keyhandler.js
index 8f9ccec527..6b9933d427 100644
--- a/js/keyhandler.js
+++ b/js/keyhandler.js
@@ -6,19 +6,19 @@
   */
 
 AJAX.registerTeardown('keyhandler.js', function() {
-    $('#table_columns').die('keydown');
-    $('table.insertRowTable').die('keydown');
+    $('#table_columns').die('keydown keyup');
+    $('table.insertRowTable').die('keydown keyup');
 });
 
 AJAX.registerOnload('keyhandler.js', function() {
-    $('#table_columns').live('keydown', function(event) {
+    $('#table_columns').live('keydown keyup', function(event) {
         onKeyDownArrowsHandler(event.originalEvent);
     });
-    $('table.insertRowTable').live('keydown', function(event) {
+    $('table.insertRowTable').live('keydown keyup', function(event) {
         onKeyDownArrowsHandler(event.originalEvent);
     });
 });
-
+console.log("cd");
 function onKeyDownArrowsHandler(e)
 {
     e = e||window.event;
@@ -28,7 +28,7 @@ function onKeyDownArrowsHandler(e)
     }
     if (o.tagName != "TEXTAREA" && o.tagName != "INPUT" && o.tagName != "SELECT") {
         return;
-    }
+    }console.log(e);
     if (navigator.userAgent.toLowerCase().indexOf('applewebkit/') != -1) {
         if (e.ctrlKey || e.shiftKey || !e.altKey) {
             return;
@@ -72,6 +72,13 @@ function onKeyDownArrowsHandler(e)
             return;
     }
 
+    var is_firefox = navigator.userAgent.toLowerCase().indexOf("firefox/") > -1;
+
+    // restore selected index, bug #3799
+    if (is_firefox && e.type == "keyup") {
+        o.selectedIndex = window["selectedIndex_" + o.id];
+    }
+
     var id = "field_" + y + "_" + x;
     nO = document.getElementById(id);
     if (! nO) {
@@ -83,7 +90,12 @@ function onKeyDownArrowsHandler(e)
     if (! nO) {
         return;
     }
-    nO.focus();
+    if (e.type == "keydown") {
+        nO.focus();
+        if (is_firefox) {
+            window["selectedIndex_" + nO.id] = nO.selectedIndex;
+        }
+    }
     if (nO.tagName != 'SELECT') {
         nO.select();
     }