bug #4626 Ctrl + click on a column not in sort triggers a server call to erroneous url

Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>

1 files changed, 5 insertions, 3 deletions

diff --git a/js/multi_column_sort.js b/js/multi_column_sort.js
index e72728fe21..58e197ef97 100644
--- a/js/multi_column_sort.js
+++ b/js/multi_column_sort.js
@@ -37,7 +37,7 @@ function removeColumnFromMultiSort(target, parent)
     // If the given column is not part of the order clause exit from this function
     var index = parent.find('small').length ? parent.find('small').text() : '';
     if (index === ''){
-        return;
+        return '';
     }
     // Remove the current clicked column
     columns.splice(index-1, 1);
@@ -62,8 +62,10 @@ AJAX.registerOnload('keyhandler.js', function () {
         if (event.ctrlKey) {
             event.preventDefault();
             url = removeColumnFromMultiSort(url, $(this).parent());
-            AJAX.source = $(this);
-            $.get(url, {'ajax_request' : true, 'ajax_page_request' : true}, AJAX.responseHandler);
+            if (url) {
+                AJAX.source = $(this);
+                $.get(url, {'ajax_request' : true, 'ajax_page_request' : true}, AJAX.responseHandler);
+            }
         } else if (event.shiftKey) {
             event.preventDefault();
             AJAX.source = $(this);