Reduce nested levels.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>

1 files changed, 52 insertions, 40 deletions

diff --git a/setup/lib/form_processing.lib.php b/setup/lib/form_processing.lib.php
index 9ca3b5317a..6a7aed37a1 100644
--- a/setup/lib/form_processing.lib.php
+++ b/setup/lib/form_processing.lib.php
@@ -9,7 +9,7 @@
 /**
  * Processes forms registered in $form_display, handles error correction
  *
- * @param FormDisplay $form_display
+ * @param FormDisplay $form_display Form to display
  *
  * @return void
  */
@@ -18,50 +18,62 @@ function process_formset(FormDisplay $form_display)
     if (filter_input(INPUT_GET, 'mode') == 'revert') {
         // revert erroneous fields to their default values
         $form_display->fixErrors();
-        // drop post data
-        header('HTTP/1.1 303 See Other');
-        header('Location: index.php');
-
-        if (!defined('TESTSUITE')) {
-            exit;
-        }
+        generateHeader303();
     }
+
     if (!$form_display->process(false)) {
         // handle form view and failed POST
         $form_display->display(true, true);
-    } else {
-        // check for form errors
-        if ($form_display->hasErrors()) {
-            // form has errors, show warning
-            $separator = PMA_URL_getArgSeparator('html');
-            $page = filter_input(INPUT_GET, 'page');
-            $formset = filter_input(INPUT_GET, 'formset');
-            $formset = $formset ? "{$separator}formset=$formset" : '';
-            $id = filter_input(INPUT_GET, 'id', FILTER_VALIDATE_INT);
-            if ($id === null && $page == 'servers') {
-                // we've just added a new server, get it's id
-                $id = $form_display->getConfigFile()->getServerCount();
-            }
-            $id = $id ? "{$separator}id=$id" : '';
+        return;
+    }
+
+    // check for form errors
+    if (!$form_display->hasErrors()) {
+        generateHeader303();
+        return;
+    }
+
+    // form has errors, show warning
+    $separator = PMA_URL_getArgSeparator('html');
+    $page = filter_input(INPUT_GET, 'page');
+    $formset = filter_input(INPUT_GET, 'formset');
+    $formset = $formset ? "{$separator}formset=$formset" : '';
+    $id = filter_input(INPUT_GET, 'id', FILTER_VALIDATE_INT);
+    if ($id === null && $page == 'servers') {
+        // we've just added a new server, get it's id
+        $id = $form_display->getConfigFile()->getServerCount();
+    }
+    $id = $id ? "{$separator}id=$id" : '';
+    ?>
+    <div class="error">
+        <h4><?php echo __('Warning') ?></h4>
+        <?php echo __('Submitted form contains errors') ?><br />
+        <a href="?page=<?php echo $page . $formset . $id . $separator ?>mode=revert">
+            <?php echo __('Try to revert erroneous fields to their default values')
             ?>
-            <div class="error">
-                <h4><?php echo __('Warning') ?></h4>
-                <?php echo __('Submitted form contains errors') ?><br />
-                <a href="?page=<?php echo $page . $formset . $id . $separator ?>mode=revert"><?php echo __('Try to revert erroneous fields to their default values') ?></a>
-            </div>
-            <?php $form_display->displayErrors() ?>
-            <a class="btn" href="index.php"><?php echo __('Ignore errors') ?></a>
-            &nbsp;
-            <a class="btn" href="?page=<?php echo $page . $formset . $id . $separator ?>mode=edit"><?php echo __('Show form') ?></a>
-            <?php
-        } else {
-            // drop post data
-            header('HTTP/1.1 303 See Other');
-            header('Location: index.php');
-            if (!defined('TESTSUITE')) {
-                exit;
-            }
-        }
+        </a>
+    </div>
+    <?php $form_display->displayErrors() ?>
+    <a class="btn" href="index.php"><?php echo __('Ignore errors') ?></a>
+    &nbsp;
+    <a class="btn" href="?page=<?php echo $page . $formset . $id
+        . $separator ?>mode=edit"><?php echo __('Show form') ?></a>
+    <?php
+}
+
+/**
+ * Generate header for 303
+ *
+ * @return void
+ */
+function generateHeader303()
+{
+    // drop post data
+    header('HTTP/1.1 303 See Other');
+    header('Location: index.php');
+
+    if (!defined('TESTSUITE')) {
+        exit;
     }
 }
 ?>