Welcome to mirror list, hosted at ThFree Co, Russian Federation.

github.com/phpmyadmin/phpmyadmin.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-10-04Merge branch 'QA_5_2'Maurício Meneghini Fauth
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-01Fix exception for invalid db and table names for the privileges pageMaurício Meneghini Fauth
Related to #17729 Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-01Issue #17727 Started refactoring uses of $db and $table (#17729)Solomon Okunuga
* Issue #17727 Started refactoring uses of $db and $table to use the Objects - DatabaseName and TableName Changed uses related to Privileges Signed-off-by: Solomon Okunuga <soloistic1@gmail.com> * Apply suggestions from code review Co-authored-by: Maurício Meneghini Fauth <mauricio@fauth.dev> Signed-off-by: Solomon Okunuga <soloistic1@gmail.com> Co-authored-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-10-01Merge #17657 - Supporting the column compression option on MariaDBWilliam Desportes
Pull-request: #17657 Ref: #14956 Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-10-01Document why zlib is the only value for a compressed columnWilliam Desportes
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-10-01Move compatibility logic into the Compatibility classWilliam Desportes
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-10-01Supporting the compressed option for MariaDBFawzi E. Abdulfattah
Ref: #14956 Signed-off-by: Fawzi E. Abdulfattah <iifawzie@gmail.com>
2022-09-30Reduce usage of the containerBuilder global variableMaurício Meneghini Fauth
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-09-30Remove the containerBuilder global var from the Template classMaurício Meneghini Fauth
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-09-29Merge branch 'QA_5_2'Maurício Meneghini Fauth
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-09-29Fix #17736 - Add utf8mb3 as an alias of utf8 on the charset description pageWilliam Desportes
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-09-26Allow longer cookie encryption keys to be usedMaurício Meneghini Fauth
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-09-26Update the docs to reflect the blowfish_secret changesMaurício Meneghini Fauth
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-09-26Update setup page to generate better blowfish_secret keysMaurício Meneghini Fauth
Instead of generating a printable string, it generates a binary string and converts it to an hexadecimal string. Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-09-26Remove `trigger_error` calls from `HomeController`Maurício Meneghini Fauth
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev> (cherry picked from commit c5611531c03a5c9dfe13510e7fc5b901daa77039) Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-09-26Merge branch 'QA_5_2'Maurício Meneghini Fauth
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-09-26Hide deprecation noticesMaurício Meneghini Fauth
Do not show deprecation notices when not in a development environment. Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-09-21Extract /console/bookmark/add action from ImportControllerMaurício Meneghini Fauth
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-09-21Extract /console/bookmark/refresh action from ImportControllerMaurício Meneghini Fauth
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-09-20Merge branch 'QA_5_2'Maurício Meneghini Fauth
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-09-20Use Psalm annotation for ResultInterface::getIteratorMaurício Meneghini Fauth
Adds Psalm's prefix for the return annotation to avoid lint errors. Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-09-18Add tryFromValue method to DatabaseName and TableName classesMaurício Meneghini Fauth
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-09-14Use DatabaseName for the newname param in OperationsControllerMaurício Meneghini Fauth
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-09-13Remove crlf global variableMaurício Meneghini Fauth
The crlf global variable is only diferent for SQL export method, otherwise is always the value of the PHP_EOL constant. Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-09-13Get 'newname' param from ServerRequest objectMaurício Meneghini Fauth
Instead of the $_POST superglobal in OperationsController and Operations classes. Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-09-11Move DBI's getProceduresOrFunctions into Routines classMaurício Meneghini Fauth
Splits the method into Routines::getFunctionNames and Routines::getProcedureNames and adds tests. Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-09-11Move DBI's getDefinition into the Routines and Events classesMaurício Meneghini Fauth
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-09-11Inline $isProcOrFunc variable in Routines::handleRequestCreateOrEditMaurício Meneghini Fauth
Improves type inference of item_original_type POST param Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-09-11Improve type inference of exportRoutineSQL's $type paramMaurício Meneghini Fauth
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-09-11Refactor Plugins\Export\ExportXml::exportDefinitions methodMaurício Meneghini Fauth
Improve type inference of the parameters. Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-09-10Move DBI getTriggers method into the Triggers classMaurício Meneghini Fauth
DatabaseInterface::getTriggers -> Database\Triggers::getDetails Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-09-10Move DBI getEvents method into the Events classMaurício Meneghini Fauth
DatabaseInterface::getEvents -> Database\Events::getDetails Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-09-10Fix PHP warning on GIS visualization when there is only one GIS columnWilliam Desportes
``` Warning in ./libraries/classes/Controllers/Table/GisVisualizationController.php#174 Undefined array key "labelColumn" Backtrace Routing.php#191: PhpMyAdmin\Controllers\Table\GisVisualizationController->__invoke( , array, ) ./../../../../index.php#43: PhpMyAdmin\Routing::callControllerForRoute( , string '/table/gis-visualization', , , ) ``` Structure: - A table with only one GIS column Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-09-10Move DBI getRoutines method to the Routines classMaurício Meneghini Fauth
DatabaseInterface::getRoutines -> Database\Routines::getDetails Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-09-09Improve type declaration of Index::getCompareData methodMaurício Meneghini Fauth
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-09-08Improve return type of Index::getPrimary methodMaurício Meneghini Fauth
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-09-08Extract dbi global variable from Index::loadIndexesMaurício Meneghini Fauth
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-09-07Add better type description for Dbal\DbalInterface::getTableIndexesMaurício Meneghini Fauth
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-09-07Add better type description for Index::$columnsMaurício Meneghini Fauth
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-09-07Add better type description to Index::$registryMaurício Meneghini Fauth
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-09-07Clean up autocomplete controllerKamil Tekiela
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-09-04Fix some errors found by PHPStan in ZipExtensionTest classMaurício Meneghini Fauth
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-09-02Fix an error found by PsalmMaurício Meneghini Fauth
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-08-30Refactor DbiMysqli::connect to use Server value objectMaurício Meneghini Fauth
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-08-23Fix some errors in Common class found by PsalmMaurício Meneghini Fauth
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-08-23Refactor insert edit (#17684)Kamil Tekiela
This is a major redesign of the code that handles these four actions: in-place edit(AJAX), edit of multiple rows, copying of rows, and insertion of new rows. The goal is to make the code easier to read and more understandable. I introduced a new DTO for better readability. Some of the methods were made private to the model The controller has access to two methods for getting the value for INSERT and for UPDATE Unfortunately, I have introduced method envy on EditField, but I do not want to move the functionality away from InsertEdit.php Unit tests have not improved in readability but I added helpful comments explaining what we are testing. There's probably a way to improve it too. I will probably merge all commits once I decide it's ready for review. Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-08-23Merge pull request #17691 from kamil-tekiela/Fix-incomplete-testMaurício Meneghini Fauth
Fix incomplete Privileges test
2022-08-20Extract Console dependencies from constructorMaurício Meneghini Fauth
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-08-19Fix incomplete Privileges testKamil Tekiela
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-08-19Merge branch 'QA_5_2'Maurício Meneghini Fauth
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>