Age | Commit message (Collapse) | Author |
|
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
|
Related to #17729
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
|
* Issue #17727 Started refactoring uses of $db and $table to use the Objects -
DatabaseName and TableName
Changed uses related to Privileges
Signed-off-by: Solomon Okunuga <soloistic1@gmail.com>
* Apply suggestions from code review
Co-authored-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
Signed-off-by: Solomon Okunuga <soloistic1@gmail.com>
Co-authored-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
|
Pull-request: #17657
Ref: #14956
Signed-off-by: William Desportes <williamdes@wdes.fr>
|
|
Signed-off-by: William Desportes <williamdes@wdes.fr>
|
|
Signed-off-by: William Desportes <williamdes@wdes.fr>
|
|
Ref: #14956
Signed-off-by: Fawzi E. Abdulfattah <iifawzie@gmail.com>
|
|
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
|
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
|
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
|
Signed-off-by: William Desportes <williamdes@wdes.fr>
|
|
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
|
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
|
Instead of generating a printable string, it generates a binary string
and converts it to an hexadecimal string.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
|
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
(cherry picked from commit c5611531c03a5c9dfe13510e7fc5b901daa77039)
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
|
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
|
Do not show deprecation notices when not in a development environment.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
|
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
|
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
|
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
|
Adds Psalm's prefix for the return annotation to avoid lint errors.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
|
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
|
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
|
The crlf global variable is only diferent for SQL export method,
otherwise is always the value of the PHP_EOL constant.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
|
Instead of the $_POST superglobal in OperationsController and Operations
classes.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
|
Splits the method into Routines::getFunctionNames and
Routines::getProcedureNames and adds tests.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
|
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
|
Improves type inference of item_original_type POST param
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
|
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
|
Improve type inference of the parameters.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
|
DatabaseInterface::getTriggers -> Database\Triggers::getDetails
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
|
DatabaseInterface::getEvents -> Database\Events::getDetails
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
|
```
Warning in ./libraries/classes/Controllers/Table/GisVisualizationController.php#174
Undefined array key "labelColumn"
Backtrace
Routing.php#191: PhpMyAdmin\Controllers\Table\GisVisualizationController->__invoke(
,
array,
)
./../../../../index.php#43: PhpMyAdmin\Routing::callControllerForRoute(
,
string '/table/gis-visualization',
,
,
)
```
Structure:
- A table with only one GIS column
Signed-off-by: William Desportes <williamdes@wdes.fr>
|
|
DatabaseInterface::getRoutines -> Database\Routines::getDetails
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
|
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
|
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
|
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
|
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
|
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
|
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
|
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
|
|
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
|
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
|
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
|
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
|
This is a major redesign of the code that handles these four actions: in-place edit(AJAX), edit of multiple rows, copying of rows, and insertion of new rows. The goal is to make the code easier to read and more understandable.
I introduced a new DTO for better readability.
Some of the methods were made private to the model
The controller has access to two methods for getting the value for INSERT and for UPDATE
Unfortunately, I have introduced method envy on EditField, but I do not want to move the functionality away from InsertEdit.php
Unit tests have not improved in readability but I added helpful comments explaining what we are testing. There's probably a way to improve it too.
I will probably merge all commits once I decide it's ready for review.
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
|
|
Fix incomplete Privileges test
|
|
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|
|
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
|
|
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
|