Welcome to mirror list, hosted at ThFree Co, Russian Federation.

github.com/phpmyadmin/phpmyadmin.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
path: root/test
AgeCommit message (Collapse)Author
2021-11-25Redesign the export/import pages to use Bootstrap componentsMaurício Meneghini Fauth
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-11-19Refactor destroy controller (#17194)Kamil Tekiela
* Remove redundant conditions They were always true. First, the variable is set to -1. If the variable is -1, then set it to Message. If the variable is Message then set the JSON array. All of this is redundant. Signed-off-by: Kamil Tekiela <tekiela246@gmail.com> * $sqlQuery is not used anywhere Signed-off-by: Kamil Tekiela <tekiela246@gmail.com> * Enforce $selected to be an array I can't remove it as it is a global. Previously, it was set to a POST variable. Since we validate that the variable is set and is not null, we can use the value from $params. If we validate that it's also an array we can replace for loop with foreach. There is no passing by reference, so this change should be safe. Signed-off-by: Kamil Tekiela <tekiela246@gmail.com> * Replace $rebuildDatabaseList with input validation The validation message says 'No databases selected.' so I assume that we should check that we actually got at least one entry in the list. If that is true, then the $rebuildDatabaseList is not needed and the condition redundant. Signed-off-by: Kamil Tekiela <tekiela246@gmail.com> * drop_selected_dbs is always set and is redundant I am not sure if this is necessary. The AJAX request sends a value of "1" but the code doesn't really do anything with it other than checking if it is actually set. Is there some other path possible? Signed-off-by: Kamil Tekiela <tekiela246@gmail.com> * Flatten the array with a single element Signed-off-by: Kamil Tekiela <tekiela246@gmail.com> * Remove redundant isset The variable is set, so !isset === is_null. Why check for null if we can check just for !is_array. Signed-off-by: Kamil Tekiela <tekiela246@gmail.com> * Update psalm-baseline.xml Signed-off-by: Kamil Tekiela <tekiela246@gmail.com> * Adhere to the coding standard Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2021-11-16Fix some issues found by PHPStanMaurício Meneghini Fauth
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-11-16Add test for `Sql::executeQueryAndSendQueryResponse`Maurício Meneghini Fauth
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-11-15Create the `RelationParameters` value objectMaurício Meneghini Fauth
Replaces the $cfgRelation array with the RelationParameters value object. Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-11-11Remove array support from `Util::backquote`Maurício Meneghini Fauth
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-11-09Fix SessionCacheTest's failing testMaurício Meneghini Fauth
https://github.com/phpmyadmin/phpmyadmin/runs/4134608655#step:6:617 Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-11-03Fix ChangePasswordTest failing Selenium testMaurício Meneghini Fauth
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-11-02Bump Jest version to 27.3.1Maurício Meneghini Fauth
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-10-31Remove printview.css theme filesMaurício Meneghini Fauth
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-10-31Remove print view modeMaurício Meneghini Fauth
- Removes the print.css file. - Data ditionary now opens like other pages. Printing the page works like before. Fixes #17169 Closes #17170 Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-10-30Change create table form to use Bootstrap's cardMaurício Meneghini Fauth
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-10-28Merge branch 'QA_5_1'Maurício Meneghini Fauth
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-10-28Remove connection parameter from getClientInfoMaurício Meneghini Fauth
Related to #16911 Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-10-11Remove exception throw from Dbal\Warning classMaurício Meneghini Fauth
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-10-09Add Warning value object for SHOW WARNINGS rowsMaurício Meneghini Fauth
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-10-07Use `@requires` annotation for required extensionsMaurício Meneghini Fauth
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-10-06Add Table\Maintenance\Message value objectMaurício Meneghini Fauth
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-10-01Rename TableName|DatabaseName create method to fromStringMaurício Meneghini Fauth
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-30Use ServerRequest for Table\Partition controllersMaurício Meneghini Fauth
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-30Get default config values from `Config\Settings` classesMaurício Meneghini Fauth
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-28Remove useless string concatenationsMaurício Meneghini Fauth
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-28Group multiple expeption catches into a single catchMaurício Meneghini Fauth
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-28Replace class strings with the `::class` constantMaurício Meneghini Fauth
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-28Replace `rand` functions with `random_int`Maurício Meneghini Fauth
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-26Remove bypass flag from `Util::backquote` methodMaurício Meneghini Fauth
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-23Merge branch 'QA_5_1'Maurício Meneghini Fauth
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-23Fix a PHP notice when logging outMaurício Meneghini Fauth
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-22Add `PhpMyAdmin\Dbal\TableName` value object classMaurício Meneghini Fauth
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-19Extract Console, Debug and SqlQueryBox classes from SettingsMaurício Meneghini Fauth
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-18Extract setter methods from Config\Settings classesMaurício Meneghini Fauth
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-15Remove useless whitespacesMaurício Meneghini Fauth
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-15Add `bool` return type where possibleMaurício Meneghini Fauth
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-13Add `void` return type where possibleMaurício Meneghini Fauth
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-13Fix failing unit testsMaurício Meneghini Fauth
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-12Inline some phpcs ignores and remove deprecated annotationsMaurício Meneghini Fauth
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-11Use only callable controllersMaurício Meneghini Fauth
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-11Extract `IndexesController::doSaveData` methodMaurício Meneghini Fauth
Creates the Table\Indexes class. Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-10Extract actions from controllers to new controllersMaurício Meneghini Fauth
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-10Extract Processes class from ProcessesControllerMaurício Meneghini Fauth
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-09Extract the `Server\ShowEngineController` classMaurício Meneghini Fauth
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-09Extract actions from Table\StructureControllerMaurício Meneghini Fauth
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-08Extract actions from controllers to new controllersMaurício Meneghini Fauth
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-07Extract actions from controllers to new ctrlsMaurício Meneghini Fauth
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-05Extract controllers from HomeControllerMaurício Meneghini Fauth
Extracts CollationConnectionController, GitInfoController and RecentTablesListController controllers from HomeController. Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-03Remove some assignments to the `$_POST` globalMaurício Meneghini Fauth
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-02Remove the `Core::isValid` methodMaurício Meneghini Fauth
This improves the type checking and simplifies the code. Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-01Inline `Core::ifSetOr` methodMaurício Meneghini Fauth
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-01Access POST params from the ServerRequest classMaurício Meneghini Fauth
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-08-31Merge branch 'QA_5_1'William Desportes
Also fixed tests from previous merge: 2d307ed06285528375be24eb1b6dc43006a5259d Signed-off-by: William Desportes <williamdes@wdes.fr>