Fixes a memory leak, and possible undefined behavior if we have

a serialization failure and just return the raw contents of a key.

Addresses issue #315

1 files changed, 4 insertions, 3 deletions

diff --git a/library.c b/library.c
index 5018a365..856a8055 100644
--- a/library.c
+++ b/library.c
@@ -808,7 +808,7 @@ PHPAPI void redis_string_response(INTERNAL_FUNCTION_PARAMETERS, RedisSock *redis
 		}
     } else {
 		if(redis_unserialize(redis_sock, response, response_len, &return_value TSRMLS_CC) == 0) {
-			RETURN_STRINGL(response, response_len, 0);
+		    RETURN_STRINGL(response, response_len, 0);
 		} else {
 			efree(response);
 		}
@@ -1367,7 +1367,7 @@ PHPAPI int
 redis_unserialize(RedisSock *redis_sock, const char *val, int val_len, zval **return_value TSRMLS_DC) {
 
 	php_unserialize_data_t var_hash;
-	int ret;
+	int ret, rv_free = 0;
 
 	switch(redis_sock->serializer) {
 		case REDIS_SERIALIZER_NONE:
@@ -1376,6 +1376,7 @@ redis_unserialize(RedisSock *redis_sock, const char *val, int val_len, zval **re
 		case REDIS_SERIALIZER_PHP:
 			if(!*return_value) {
 				MAKE_STD_ZVAL(*return_value);
+				rv_free = 1;
 			}
 #if ZEND_MODULE_API_NO >= 20100000
 			PHP_VAR_UNSERIALIZE_INIT(var_hash);
@@ -1384,7 +1385,7 @@ redis_unserialize(RedisSock *redis_sock, const char *val, int val_len, zval **re
 #endif
 			if(!php_var_unserialize(return_value, (const unsigned char**)&val,
 					(const unsigned char*)val + val_len, &var_hash TSRMLS_CC)) {
-				efree(*return_value);
+				if(rv_free==1) efree(*return_value);
 				ret = 0;
 			} else {
 				ret = 1;