should fix #258: Crash with OfflineException when app is in background

2 files changed, 17 insertions, 5 deletions

diff --git a/app/src/main/java/it/niedermann/nextcloud/deck/persistence/sync/SyncManager.java b/app/src/main/java/it/niedermann/nextcloud/deck/persistence/sync/SyncManager.java
index 68f595103..0a6002731 100644
--- a/app/src/main/java/it/niedermann/nextcloud/deck/persistence/sync/SyncManager.java
+++ b/app/src/main/java/it/niedermann/nextcloud/deck/persistence/sync/SyncManager.java
@@ -139,7 +139,14 @@ public class SyncManager {
                             responseCallback.onError(throwable);
                         }
                     });
-                    doAsync(() -> syncHelper.doUpSyncFor(new BoardDataProvider()));
+                    doAsync(() -> {
+                        try {
+                            syncHelper.doUpSyncFor(new BoardDataProvider());
+                        } catch (Throwable e) {
+                            DeckLog.logError(e);
+                            responseCallback.onError(e);
+                        }
+                    });
 
                 }
 
@@ -152,7 +159,12 @@ public class SyncManager {
 
             syncHelper.setResponseCallback(callback);
 
-            syncHelper.doSyncFor(new BoardDataProvider());
+            try {
+                syncHelper.doSyncFor(new BoardDataProvider());
+            } catch (Throwable e) {
+                DeckLog.logError(e);
+                responseCallback.onError(e);
+            }
         });
     }
 
diff --git a/app/src/main/java/it/niedermann/nextcloud/deck/ui/card/CardActivityFragment.java b/app/src/main/java/it/niedermann/nextcloud/deck/ui/card/CardActivityFragment.java
index 8d7daf628..40d470331 100644
--- a/app/src/main/java/it/niedermann/nextcloud/deck/ui/card/CardActivityFragment.java
+++ b/app/src/main/java/it/niedermann/nextcloud/deck/ui/card/CardActivityFragment.java
@@ -13,7 +13,6 @@ import androidx.fragment.app.Fragment;
 import androidx.recyclerview.widget.RecyclerView;
 
 import com.google.android.material.floatingactionbutton.FloatingActionButton;
-import com.google.android.material.snackbar.Snackbar;
 
 import java.util.Objects;
 
@@ -97,8 +96,9 @@ public class CardActivityFragment extends Fragment {
             });
             if (canEdit) {
                 fab.setOnClickListener(v -> {
-                    Snackbar.make(coordinatorLayout, "Adding comments is not yet implemented", Snackbar.LENGTH_LONG).show();
-//                    CommentDialogFragment.newInstance().show(getActivity().getSupportFragmentManager(), addComment);
+//                    Snackbar.make(coordinatorLayout, "Adding comments is not yet implemented", Snackbar.LENGTH_LONG).show();
+                    CommentDialogFragment.newInstance().show(getActivity().getSupportFragmentManager(), addComment);
+                    syncManager.addCommentToCard();
                 });
                 activitiesList.addOnScrollListener(new RecyclerView.OnScrollListener() {
                     @Override